From: Christoph Hellwig <hch@lst.de> To: "J. Bruce Fields" <bfields@fieldses.org> Cc: Eric Sandeen <sandeen@sandeen.net>, linux-nfs@vger.kernel.org, Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com Subject: Re: panic on 4.20 server exporting xfs filesystem Date: Fri, 20 Mar 2015 07:49:25 +0100 [thread overview] Message-ID: <20150320064925.GB626@lst.de> (raw) In-Reply-To: <20150319184714.GB20852@fieldses.org> On Thu, Mar 19, 2015 at 02:47:14PM -0400, J. Bruce Fields wrote: > Also, there's the problem that when this is turned on a client can end > up doing unnecessary LAYOUTGET. Do we have a plan for that? > > Possibilities: > > - Just depend on export flags: but some clients may have direct > access and some not. If the clients with direct access or all > easily identifiable by IP subnet, maybe it's not a big deal. > Still, seems like an administrative hassle. We defintively want this to avoid getting into problems. > > - Do nothing, assume the client can deal with this with some > kind of heuristics, and/or that the GETLAYOUT calls can be > made very cheap. Not sure if that's true. The calls itself are cheap, the cliet processing of them isn't. I think we should just stop issueing GETLAYOUT calls on the client side if we keep errors again and again. One option might be to add negative device id cache entries, similar to how negative dentries work in the dcache. > - Use something like GETDEVLICELIST so the client can figure out > in one go whether any layouts on a given filesystem will work. > I forget what the problems with GETDEVICELIST were. The way the device IDs rules are written in NFS it is inherently racy. If I could go back 10 years in time I'd rewrite device ids to be stateids bound to a fsid, and a lot of things could be fixed up neatly that way.. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: "J. Bruce Fields" <bfields@fieldses.org> Cc: Christoph Hellwig <hch@lst.de>, Dave Chinner <david@fromorbit.com>, Eric Sandeen <sandeen@sandeen.net>, linux-nfs@vger.kernel.org, xfs@oss.sgi.com Subject: Re: panic on 4.20 server exporting xfs filesystem Date: Fri, 20 Mar 2015 07:49:25 +0100 [thread overview] Message-ID: <20150320064925.GB626@lst.de> (raw) In-Reply-To: <20150319184714.GB20852@fieldses.org> On Thu, Mar 19, 2015 at 02:47:14PM -0400, J. Bruce Fields wrote: > Also, there's the problem that when this is turned on a client can end > up doing unnecessary LAYOUTGET. Do we have a plan for that? > > Possibilities: > > - Just depend on export flags: but some clients may have direct > access and some not. If the clients with direct access or all > easily identifiable by IP subnet, maybe it's not a big deal. > Still, seems like an administrative hassle. We defintively want this to avoid getting into problems. > > - Do nothing, assume the client can deal with this with some > kind of heuristics, and/or that the GETLAYOUT calls can be > made very cheap. Not sure if that's true. The calls itself are cheap, the cliet processing of them isn't. I think we should just stop issueing GETLAYOUT calls on the client side if we keep errors again and again. One option might be to add negative device id cache entries, similar to how negative dentries work in the dcache. > - Use something like GETDEVLICELIST so the client can figure out > in one go whether any layouts on a given filesystem will work. > I forget what the problems with GETDEVICELIST were. The way the device IDs rules are written in NFS it is inherently racy. If I could go back 10 years in time I'd rewrite device ids to be stateids bound to a fsid, and a lot of things could be fixed up neatly that way..
next prev parent reply other threads:[~2015-03-20 6:49 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-03 22:10 panic on 4.20 server exporting xfs filesystem J. Bruce Fields 2015-03-03 22:10 ` J. Bruce Fields 2015-03-03 22:44 ` Dave Chinner 2015-03-03 22:44 ` Dave Chinner 2015-03-04 2:08 ` J. Bruce Fields 2015-03-04 2:08 ` J. Bruce Fields 2015-03-04 4:41 ` Dave Chinner 2015-03-04 4:41 ` Dave Chinner 2015-03-05 13:19 ` Christoph Hellwig 2015-03-05 13:19 ` Christoph Hellwig 2015-03-05 15:21 ` J. Bruce Fields 2015-03-05 15:21 ` J. Bruce Fields 2015-03-08 13:08 ` Tom Haynes 2015-03-08 13:08 ` Tom Haynes 2015-03-04 15:54 ` J. Bruce Fields 2015-03-04 15:54 ` J. Bruce Fields 2015-03-04 22:09 ` Dave Chinner 2015-03-04 22:09 ` Dave Chinner 2015-03-04 22:27 ` J. Bruce Fields 2015-03-04 22:27 ` J. Bruce Fields 2015-03-04 22:45 ` Dave Chinner 2015-03-04 22:45 ` Dave Chinner 2015-03-04 22:49 ` Eric Sandeen 2015-03-04 22:49 ` Eric Sandeen 2015-03-04 22:56 ` Dave Chinner 2015-03-04 22:56 ` Dave Chinner 2015-03-05 4:08 ` J. Bruce Fields 2015-03-05 4:08 ` J. Bruce Fields 2015-03-05 13:17 ` Christoph Hellwig 2015-03-05 13:17 ` Christoph Hellwig 2015-03-05 15:01 ` J. Bruce Fields 2015-03-05 15:01 ` J. Bruce Fields 2015-03-05 17:02 ` J. Bruce Fields 2015-03-05 17:02 ` J. Bruce Fields 2015-03-05 20:47 ` J. Bruce Fields 2015-03-05 20:47 ` J. Bruce Fields 2015-03-05 20:59 ` Dave Chinner 2015-03-05 20:59 ` Dave Chinner 2015-03-06 20:47 ` J. Bruce Fields 2015-03-06 20:47 ` J. Bruce Fields 2015-03-19 17:27 ` Christoph Hellwig 2015-03-19 17:27 ` Christoph Hellwig 2015-03-19 18:47 ` J. Bruce Fields 2015-03-19 18:47 ` J. Bruce Fields 2015-03-20 6:49 ` Christoph Hellwig [this message] 2015-03-20 6:49 ` Christoph Hellwig 2015-03-08 15:30 ` Christoph Hellwig 2015-03-08 15:30 ` Christoph Hellwig 2015-03-09 19:45 ` J. Bruce Fields 2015-03-09 19:45 ` J. Bruce Fields 2015-03-20 4:06 ` Kinglong Mee 2015-03-20 4:06 ` Kinglong Mee 2015-03-20 6:50 ` Christoph Hellwig 2015-03-20 6:50 ` Christoph Hellwig 2015-03-20 7:56 ` [PATCH] NFSD: Fix infinite loop in nfsd4_cb_layout_fail() Kinglong Mee 2015-03-20 7:56 ` Kinglong Mee 2015-03-15 12:58 ` panic on 4.20 server exporting xfs filesystem Christoph Hellwig 2015-03-15 12:58 ` Christoph Hellwig 2015-03-16 14:27 ` J. Bruce Fields 2015-03-16 14:27 ` J. Bruce Fields 2015-03-17 10:30 ` Christoph Hellwig 2015-03-17 10:30 ` Christoph Hellwig 2015-03-18 10:50 ` Christoph Hellwig 2015-03-18 10:50 ` Christoph Hellwig 2015-03-27 10:41 ` Christoph Hellwig 2015-03-27 14:50 ` Jeff Layton 2015-03-30 16:44 ` Christoph Hellwig 2015-03-27 15:13 ` J. Bruce Fields 2015-04-26 16:19 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150320064925.GB626@lst.de \ --to=hch@lst.de \ --cc=bfields@fieldses.org \ --cc=linux-nfs@vger.kernel.org \ --cc=sandeen@sandeen.net \ --cc=xfs@oss.sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.