From: Eduardo Valentin <edubezval@gmail.com> To: Nishanth Menon <nm@ti.com> Cc: "Tony Lindgren" <tony@atomide.com>, "Benoît Cousson" <bcousson@baylibre.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, Keerthy <j-keerthy@ti.com>, "Tero Kristo" <t-kristo@ti.com> Subject: Re: [PATCH 1/3] ARM: dts: OMAP5+: separate the cpu thermal zone definition from omap4 Date: Fri, 20 Mar 2015 17:54:03 -0400 [thread overview] Message-ID: <20150320215402.GB7346@developer.amazonguestwifi.org> (raw) In-Reply-To: <1426880861-9266-2-git-send-email-nm@ti.com> [-- Attachment #1: Type: text/plain, Size: 2731 bytes --] On Fri, Mar 20, 2015 at 02:47:39PM -0500, Nishanth Menon wrote: > From: Tero Kristo <t-kristo@ti.com> > > OMAP4 has a finer counter granularity, which allows for a delay of 1000ms > in the thermal zone polling intervals. OMAP5/DRA7 have different counter > mechanism, which allows at maximum a 500ms timer. Adjust the cpu thermal > zone accordingly for OMAP5/DRA7. > > Signed-off-by: Tero Kristo <t-kristo@ti.com> > Signed-off-by: Nishanth Menon <nm@ti.com> > --- > arch/arm/boot/dts/omap5-cpu-thermal.dtsi | 41 ++++++++++++++++++++++++++++++ > arch/arm/boot/dts/omap5.dtsi | 2 +- > 2 files changed, 42 insertions(+), 1 deletion(-) > create mode 100644 arch/arm/boot/dts/omap5-cpu-thermal.dtsi > > diff --git a/arch/arm/boot/dts/omap5-cpu-thermal.dtsi b/arch/arm/boot/dts/omap5-cpu-thermal.dtsi > new file mode 100644 > index 000000000000..4a6427c1e47e > --- /dev/null > +++ b/arch/arm/boot/dts/omap5-cpu-thermal.dtsi > @@ -0,0 +1,41 @@ > +/* > + * Device Tree Source for OMAP4/5 SoC CPU thermal > + * > + * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/ > + * Contact: Tero Kristo <t-kristo@ti.com> > + * > + * This file is licensed under the terms of the GNU General Public License > + * version 2. This program is licensed "as is" without any warranty of any > + * kind, whether express or implied. > + */ > + > +#include <dt-bindings/thermal/thermal.h> > + > +cpu_thermal: cpu_thermal { > + polling-delay-passive = <250>; /* milliseconds */ > + polling-delay = <500>; /* milliseconds */ > + > + /* sensor ID */ > + thermal-sensors = <&bandgap 0>; > + > + cpu_trips: trips { > + cpu_alert0: cpu_alert { > + temperature = <100000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "passive"; > + }; > + cpu_crit: cpu_crit { > + temperature = <125000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "critical"; > + }; > + }; > + > + cpu_cooling_maps: cooling-maps { > + map0 { > + trip = <&cpu_alert0>; > + cooling-device = > + <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > +}; > diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi > index ddff674bd05e..e650d4eb59dd 100644 > --- a/arch/arm/boot/dts/omap5.dtsi > +++ b/arch/arm/boot/dts/omap5.dtsi > @@ -67,7 +67,7 @@ > }; > > thermal-zones { > - #include "omap4-cpu-thermal.dtsi" > + #include "omap5-cpu-thermal.dtsi" Can't we simple change the polling value for the omap5 case and reuse the omap4 file? > #include "omap5-gpu-thermal.dtsi" > #include "omap5-core-thermal.dtsi" > }; > -- > 1.7.9.5 > [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: edubezval@gmail.com (Eduardo Valentin) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] ARM: dts: OMAP5+: separate the cpu thermal zone definition from omap4 Date: Fri, 20 Mar 2015 17:54:03 -0400 [thread overview] Message-ID: <20150320215402.GB7346@developer.amazonguestwifi.org> (raw) In-Reply-To: <1426880861-9266-2-git-send-email-nm@ti.com> On Fri, Mar 20, 2015 at 02:47:39PM -0500, Nishanth Menon wrote: > From: Tero Kristo <t-kristo@ti.com> > > OMAP4 has a finer counter granularity, which allows for a delay of 1000ms > in the thermal zone polling intervals. OMAP5/DRA7 have different counter > mechanism, which allows at maximum a 500ms timer. Adjust the cpu thermal > zone accordingly for OMAP5/DRA7. > > Signed-off-by: Tero Kristo <t-kristo@ti.com> > Signed-off-by: Nishanth Menon <nm@ti.com> > --- > arch/arm/boot/dts/omap5-cpu-thermal.dtsi | 41 ++++++++++++++++++++++++++++++ > arch/arm/boot/dts/omap5.dtsi | 2 +- > 2 files changed, 42 insertions(+), 1 deletion(-) > create mode 100644 arch/arm/boot/dts/omap5-cpu-thermal.dtsi > > diff --git a/arch/arm/boot/dts/omap5-cpu-thermal.dtsi b/arch/arm/boot/dts/omap5-cpu-thermal.dtsi > new file mode 100644 > index 000000000000..4a6427c1e47e > --- /dev/null > +++ b/arch/arm/boot/dts/omap5-cpu-thermal.dtsi > @@ -0,0 +1,41 @@ > +/* > + * Device Tree Source for OMAP4/5 SoC CPU thermal > + * > + * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/ > + * Contact: Tero Kristo <t-kristo@ti.com> > + * > + * This file is licensed under the terms of the GNU General Public License > + * version 2. This program is licensed "as is" without any warranty of any > + * kind, whether express or implied. > + */ > + > +#include <dt-bindings/thermal/thermal.h> > + > +cpu_thermal: cpu_thermal { > + polling-delay-passive = <250>; /* milliseconds */ > + polling-delay = <500>; /* milliseconds */ > + > + /* sensor ID */ > + thermal-sensors = <&bandgap 0>; > + > + cpu_trips: trips { > + cpu_alert0: cpu_alert { > + temperature = <100000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "passive"; > + }; > + cpu_crit: cpu_crit { > + temperature = <125000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "critical"; > + }; > + }; > + > + cpu_cooling_maps: cooling-maps { > + map0 { > + trip = <&cpu_alert0>; > + cooling-device = > + <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > +}; > diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi > index ddff674bd05e..e650d4eb59dd 100644 > --- a/arch/arm/boot/dts/omap5.dtsi > +++ b/arch/arm/boot/dts/omap5.dtsi > @@ -67,7 +67,7 @@ > }; > > thermal-zones { > - #include "omap4-cpu-thermal.dtsi" > + #include "omap5-cpu-thermal.dtsi" Can't we simple change the polling value for the omap5 case and reuse the omap4 file? > #include "omap5-gpu-thermal.dtsi" > #include "omap5-core-thermal.dtsi" > }; > -- > 1.7.9.5 > -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150320/96b13faf/attachment-0001.sig>
next prev parent reply other threads:[~2015-03-20 21:54 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-20 19:47 [PATCH 0/3] ARM: omap5/dra7/x15: Thermal dts patches Nishanth Menon 2015-03-20 19:47 ` Nishanth Menon 2015-03-20 19:47 ` Nishanth Menon 2015-03-20 19:47 ` [PATCH 1/3] ARM: dts: OMAP5+: separate the cpu thermal zone definition from omap4 Nishanth Menon 2015-03-20 19:47 ` Nishanth Menon 2015-03-20 19:47 ` Nishanth Menon 2015-03-20 21:54 ` Eduardo Valentin [this message] 2015-03-20 21:54 ` Eduardo Valentin 2015-03-23 10:16 ` Tero Kristo 2015-03-23 10:16 ` Tero Kristo 2015-03-23 17:00 ` Nishanth Menon 2015-03-23 17:00 ` Nishanth Menon 2015-03-20 19:47 ` [PATCH 2/3] ARM: dts: DRA7: Add bandgap and related thermal nodes Nishanth Menon 2015-03-20 19:47 ` Nishanth Menon 2015-03-20 19:47 ` Nishanth Menon 2015-03-20 21:51 ` Eduardo Valentin 2015-03-20 21:51 ` Eduardo Valentin 2015-03-20 19:47 ` [PATCH 3/3] ARM: dts: am57xx-beagle-x15: Add thermal map Nishanth Menon 2015-03-20 19:47 ` Nishanth Menon 2015-03-20 19:47 ` Nishanth Menon 2015-03-20 21:50 ` Eduardo Valentin 2015-03-20 21:50 ` Eduardo Valentin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150320215402.GB7346@developer.amazonguestwifi.org \ --to=edubezval@gmail.com \ --cc=bcousson@baylibre.com \ --cc=devicetree@vger.kernel.org \ --cc=j-keerthy@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=nm@ti.com \ --cc=t-kristo@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.