From: Michal Hocko <mhocko@suse.cz>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Huang Ying <ying.huang@intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Dave Chinner <david@fromorbit.com>,
"Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [patch 06/12] mm: oom_kill: simplify OOM killer locking
Date: Thu, 26 Mar 2015 17:07:42 +0100 [thread overview]
Message-ID: <20150326160742.GR15257@dhcp22.suse.cz> (raw)
In-Reply-To: <20150326151746.GC23973@cmpxchg.org>
On Thu 26-03-15 11:17:46, Johannes Weiner wrote:
> On Thu, Mar 26, 2015 at 02:31:11PM +0100, Michal Hocko wrote:
[...]
> > > @@ -795,27 +728,21 @@ bool out_of_memory(struct zonelist *zonelist, gfp_t gfp_mask,
> > > */
> > > void pagefault_out_of_memory(void)
> > > {
> > > - struct zonelist *zonelist;
> > > -
> > > - down_read(&oom_sem);
> > > if (mem_cgroup_oom_synchronize(true))
> > > - goto unlock;
> > > + return;
> >
> > OK, so we are back to what David has asked previously. We do not need
> > the lock for memcg and oom_killer_disabled because we know that no tasks
> > (except for potential oom victim) are lurking around at the time
> > oom_killer_disable() is called. So I guess we want to stick a comment
> > into mem_cgroup_oom_synchronize before we check for oom_killer_disabled.
>
> I would prefer everybody that sets TIF_MEMDIE and kills a task to hold
> the lock, including memcg. Simplicity is one thing, but also a global
> OOM kill might not even be necessary when it's racing with the memcg.
sure I am find with that.
> > After those are fixed, feel free to add
> > Acked-by: Michal Hocko <mhocko@suse.cz>
>
> Thanks.
--
Michal Hocko
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@suse.cz>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Huang Ying <ying.huang@intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Dave Chinner <david@fromorbit.com>, Theodore Ts'o <tytso@mit.edu>
Subject: Re: [patch 06/12] mm: oom_kill: simplify OOM killer locking
Date: Thu, 26 Mar 2015 17:07:42 +0100 [thread overview]
Message-ID: <20150326160742.GR15257@dhcp22.suse.cz> (raw)
In-Reply-To: <20150326151746.GC23973@cmpxchg.org>
On Thu 26-03-15 11:17:46, Johannes Weiner wrote:
> On Thu, Mar 26, 2015 at 02:31:11PM +0100, Michal Hocko wrote:
[...]
> > > @@ -795,27 +728,21 @@ bool out_of_memory(struct zonelist *zonelist, gfp_t gfp_mask,
> > > */
> > > void pagefault_out_of_memory(void)
> > > {
> > > - struct zonelist *zonelist;
> > > -
> > > - down_read(&oom_sem);
> > > if (mem_cgroup_oom_synchronize(true))
> > > - goto unlock;
> > > + return;
> >
> > OK, so we are back to what David has asked previously. We do not need
> > the lock for memcg and oom_killer_disabled because we know that no tasks
> > (except for potential oom victim) are lurking around at the time
> > oom_killer_disable() is called. So I guess we want to stick a comment
> > into mem_cgroup_oom_synchronize before we check for oom_killer_disabled.
>
> I would prefer everybody that sets TIF_MEMDIE and kills a task to hold
> the lock, including memcg. Simplicity is one thing, but also a global
> OOM kill might not even be necessary when it's racing with the memcg.
sure I am find with that.
> > After those are fixed, feel free to add
> > Acked-by: Michal Hocko <mhocko@suse.cz>
>
> Thanks.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-03-26 16:07 UTC|newest]
Thread overview: 140+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 6:17 [patch 00/12] mm: page_alloc: improve OOM mechanism and policy Johannes Weiner
2015-03-25 6:17 ` Johannes Weiner
2015-03-25 6:17 ` [patch 01/12] mm: oom_kill: remove unnecessary locking in oom_enable() Johannes Weiner
2015-03-25 6:17 ` Johannes Weiner
2015-03-26 0:51 ` David Rientjes
2015-03-26 0:51 ` David Rientjes
2015-03-26 11:51 ` Michal Hocko
2015-03-26 11:51 ` Michal Hocko
2015-03-26 13:18 ` Michal Hocko
2015-03-26 13:18 ` Michal Hocko
2015-03-26 19:30 ` David Rientjes
2015-03-26 19:30 ` David Rientjes
2015-03-26 11:43 ` Michal Hocko
2015-03-26 11:43 ` Michal Hocko
2015-03-26 20:05 ` David Rientjes
2015-03-26 20:05 ` David Rientjes
2015-03-25 6:17 ` [patch 02/12] mm: oom_kill: clean up victim marking and exiting interfaces Johannes Weiner
2015-03-25 6:17 ` Johannes Weiner
2015-03-26 3:34 ` David Rientjes
2015-03-26 3:34 ` David Rientjes
2015-03-26 11:54 ` Michal Hocko
2015-03-26 11:54 ` Michal Hocko
2015-03-25 6:17 ` [patch 03/12] mm: oom_kill: switch test-and-clear of known TIF_MEMDIE to clear Johannes Weiner
2015-03-25 6:17 ` Johannes Weiner
2015-03-26 3:31 ` David Rientjes
2015-03-26 3:31 ` David Rientjes
2015-03-26 11:05 ` Johannes Weiner
2015-03-26 11:05 ` Johannes Weiner
2015-03-26 19:50 ` David Rientjes
2015-03-26 19:50 ` David Rientjes
2015-03-30 14:48 ` Michal Hocko
2015-03-30 14:48 ` Michal Hocko
2015-04-02 23:01 ` [patch] android, lmk: avoid setting TIF_MEMDIE if process has already exited David Rientjes
2015-04-02 23:01 ` David Rientjes
2015-04-28 22:50 ` [patch resend] " David Rientjes
2015-04-28 22:50 ` David Rientjes
2015-03-26 11:57 ` [patch 03/12] mm: oom_kill: switch test-and-clear of known TIF_MEMDIE to clear Michal Hocko
2015-03-26 11:57 ` Michal Hocko
2015-03-25 6:17 ` [patch 04/12] mm: oom_kill: remove unnecessary locking in exit_oom_victim() Johannes Weiner
2015-03-25 6:17 ` Johannes Weiner
2015-03-26 12:53 ` Michal Hocko
2015-03-26 12:53 ` Michal Hocko
2015-03-26 13:01 ` Michal Hocko
2015-03-26 13:01 ` Michal Hocko
2015-03-26 15:10 ` Johannes Weiner
2015-03-26 15:10 ` Johannes Weiner
2015-03-26 15:04 ` Johannes Weiner
2015-03-26 15:04 ` Johannes Weiner
2015-03-25 6:17 ` [patch 05/12] mm: oom_kill: generalize OOM progress waitqueue Johannes Weiner
2015-03-25 6:17 ` Johannes Weiner
2015-03-26 13:03 ` Michal Hocko
2015-03-26 13:03 ` Michal Hocko
2015-03-25 6:17 ` [patch 06/12] mm: oom_kill: simplify OOM killer locking Johannes Weiner
2015-03-25 6:17 ` Johannes Weiner
2015-03-26 13:31 ` Michal Hocko
2015-03-26 13:31 ` Michal Hocko
2015-03-26 15:17 ` Johannes Weiner
2015-03-26 15:17 ` Johannes Weiner
2015-03-26 16:07 ` Michal Hocko [this message]
2015-03-26 16:07 ` Michal Hocko
2015-03-25 6:17 ` [patch 07/12] mm: page_alloc: inline should_alloc_retry() Johannes Weiner
2015-03-25 6:17 ` Johannes Weiner
2015-03-26 14:11 ` Michal Hocko
2015-03-26 14:11 ` Michal Hocko
2015-03-26 15:18 ` Johannes Weiner
2015-03-26 15:18 ` Johannes Weiner
2015-03-25 6:17 ` [patch 08/12] mm: page_alloc: wait for OOM killer progress before retrying Johannes Weiner
2015-03-25 6:17 ` Johannes Weiner
2015-03-25 14:15 ` Tetsuo Handa
2015-03-25 14:15 ` Tetsuo Handa
2015-03-25 17:01 ` Vlastimil Babka
2015-03-25 17:01 ` Vlastimil Babka
2015-03-26 11:28 ` Johannes Weiner
2015-03-26 11:28 ` Johannes Weiner
2015-03-26 11:24 ` Johannes Weiner
2015-03-26 11:24 ` Johannes Weiner
2015-03-26 14:32 ` Michal Hocko
2015-03-26 14:32 ` Michal Hocko
2015-03-26 15:23 ` Johannes Weiner
2015-03-26 15:23 ` Johannes Weiner
2015-03-26 15:38 ` Michal Hocko
2015-03-26 15:38 ` Michal Hocko
2015-03-26 18:17 ` Johannes Weiner
2015-03-26 18:17 ` Johannes Weiner
2015-03-27 14:01 ` [patch 08/12] mm: page_alloc: wait for OOM killer progressbefore retrying Tetsuo Handa
2015-03-27 14:01 ` Tetsuo Handa
2015-03-26 15:58 ` [patch 08/12] mm: page_alloc: wait for OOM killer progress before retrying Michal Hocko
2015-03-26 15:58 ` Michal Hocko
2015-03-26 18:23 ` Johannes Weiner
2015-03-26 18:23 ` Johannes Weiner
2015-03-25 6:17 ` [patch 09/12] mm: page_alloc: private memory reserves for OOM-killing allocations Johannes Weiner
2015-03-25 6:17 ` Johannes Weiner
2015-04-14 16:49 ` Michal Hocko
2015-04-14 16:49 ` Michal Hocko
2015-04-24 19:13 ` Johannes Weiner
2015-04-24 19:13 ` Johannes Weiner
2015-03-25 6:17 ` [patch 10/12] mm: page_alloc: emergency reserve access for __GFP_NOFAIL allocations Johannes Weiner
2015-03-25 6:17 ` Johannes Weiner
2015-04-14 16:55 ` Michal Hocko
2015-04-14 16:55 ` Michal Hocko
2015-03-25 6:17 ` [patch 11/12] mm: page_alloc: do not lock up GFP_NOFS allocations upon OOM Johannes Weiner
2015-03-25 6:17 ` Johannes Weiner
2015-03-26 14:50 ` Michal Hocko
2015-03-26 14:50 ` Michal Hocko
2015-03-25 6:17 ` [patch 12/12] mm: page_alloc: do not lock up low-order " Johannes Weiner
2015-03-25 6:17 ` Johannes Weiner
2015-03-26 15:32 ` Michal Hocko
2015-03-26 15:32 ` Michal Hocko
2015-03-26 19:58 ` [patch 00/12] mm: page_alloc: improve OOM mechanism and policy Dave Chinner
2015-03-26 19:58 ` Dave Chinner
2015-03-27 15:05 ` Johannes Weiner
2015-03-27 15:05 ` Johannes Weiner
2015-03-30 0:32 ` Dave Chinner
2015-03-30 0:32 ` Dave Chinner
2015-03-30 19:31 ` Johannes Weiner
2015-03-30 19:31 ` Johannes Weiner
2015-04-01 15:19 ` Michal Hocko
2015-04-01 15:19 ` Michal Hocko
2015-04-01 21:39 ` Dave Chinner
2015-04-01 21:39 ` Dave Chinner
2015-04-02 7:29 ` Michal Hocko
2015-04-02 7:29 ` Michal Hocko
2015-04-07 14:18 ` Johannes Weiner
2015-04-07 14:18 ` Johannes Weiner
2015-04-11 7:29 ` Tetsuo Handa
2015-04-11 7:29 ` Tetsuo Handa
2015-04-13 12:49 ` Michal Hocko
2015-04-13 12:49 ` Michal Hocko
2015-04-13 12:46 ` Michal Hocko
2015-04-13 12:46 ` Michal Hocko
2015-04-14 0:11 ` Dave Chinner
2015-04-14 0:11 ` Dave Chinner
2015-04-14 7:20 ` Michal Hocko
2015-04-14 7:20 ` Michal Hocko
2015-04-14 10:36 ` Johannes Weiner
2015-04-14 10:36 ` Johannes Weiner
2015-04-14 14:23 ` Michal Hocko
2015-04-14 14:23 ` Michal Hocko
[not found] <048301d066d1$653e63d0$2fbb2b70$@alibaba-inc.com>
2015-03-25 8:05 ` [patch 06/12] mm: oom_kill: simplify OOM killer locking Hillf Danton
2015-03-25 8:05 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326160742.GR15257@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=hannes@cmpxchg.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.