From: Kenneth Westfield <kwestfie-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> To: Srinivas Kandagatla <srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Cc: Patrick Lai <plai-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>, Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>, Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, Banajit Goswami <bgoswami-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, Kenneth Westfield <kwestfie-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Jaroslav Kysela <perex-/Fr2/VpizcU@public.gmane.org>, Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [RFC PATCH 07/14] ASoC: qcom: add no osr clk flag to lpass variant Date: Sat, 2 May 2015 16:58:09 -0700 [thread overview] Message-ID: <20150502235800.GC27804@kwestfie-linux.qualcomm.com> (raw) In-Reply-To: <1430414244-11168-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> On Thu, Apr 30, 2015 at 06:17:24PM +0100, Srinivas Kandagatla wrote: > Some LPASS integrations like on APQ8016 do not have OSR clk, so adding > no osr clk bit would allow such integrations to use lpass driver. Going forward, as the code is generalized, perhaps having an enable flag for each clock, rather than a flag that negates an existing clock? Or checking that the clock pointer is NULL after probing would be the indication? > sound/soc/qcom/lpass-cpu.c | 49 +++++++++++++++++++++++++++++----------------- > sound/soc/qcom/lpass.h | 2 ++ > 2 files changed, 33 insertions(+), 18 deletions(-) -- Kenneth Westfield Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Kenneth Westfield <kwestfie@codeaurora.org> To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: Patrick Lai <plai@codeaurora.org>, Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Banajit Goswami <bgoswami@codeaurora.org>, Kenneth Westfield <kwestfie@codeaurora.org>, Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org Subject: Re: [RFC PATCH 07/14] ASoC: qcom: add no osr clk flag to lpass variant Date: Sat, 2 May 2015 16:58:09 -0700 [thread overview] Message-ID: <20150502235800.GC27804@kwestfie-linux.qualcomm.com> (raw) In-Reply-To: <1430414244-11168-1-git-send-email-srinivas.kandagatla@linaro.org> On Thu, Apr 30, 2015 at 06:17:24PM +0100, Srinivas Kandagatla wrote: > Some LPASS integrations like on APQ8016 do not have OSR clk, so adding > no osr clk bit would allow such integrations to use lpass driver. Going forward, as the code is generalized, perhaps having an enable flag for each clock, rather than a flag that negates an existing clock? Or checking that the clock pointer is NULL after probing would be the indication? > sound/soc/qcom/lpass-cpu.c | 49 +++++++++++++++++++++++++++++----------------- > sound/soc/qcom/lpass.h | 2 ++ > 2 files changed, 33 insertions(+), 18 deletions(-) -- Kenneth Westfield Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-05-02 23:58 UTC|newest] Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-30 17:15 [RFC PATCH 00/14] ASoC: qcom: add support to apq8016 audio Srinivas Kandagatla 2015-04-30 17:15 ` Srinivas Kandagatla 2015-04-30 17:16 ` [RFC PATCH 01/14] ASoC: qcom: Remove redundant error check Srinivas Kandagatla 2015-05-04 12:24 ` Mark Brown 2015-04-30 17:16 ` [RFC PATCH 02/14] ASoC: qcom: remove unnecessary header files Srinivas Kandagatla 2015-05-04 12:24 ` Mark Brown 2015-04-30 17:16 ` [RFC PATCH 03/14] ASoC: qcom: move ipq806x specific bits out of lpass driver Srinivas Kandagatla 2015-05-02 23:57 ` Kenneth Westfield 2015-05-05 5:19 ` Kenneth Westfield 2015-05-05 7:17 ` Srinivas Kandagatla 2015-05-06 5:43 ` [alsa-devel] " Kenneth Westfield 2015-05-05 7:16 ` Srinivas Kandagatla [not found] ` <55486E5E.4010601-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-05-06 5:35 ` [alsa-devel] " Kenneth Westfield 2015-05-06 5:35 ` Kenneth Westfield 2015-04-30 17:17 ` [RFC PATCH 04/14] ASoC: qcom: remove hardcoded i2s port number Srinivas Kandagatla 2015-04-30 17:17 ` [RFC PATCH 05/14] ASoC: qcom: remove hardcoded dma channel Srinivas Kandagatla 2015-04-30 17:17 ` [RFC PATCH 06/14] ASoC: qcom: support bitclk and osrclk per i2s port Srinivas Kandagatla 2015-04-30 17:17 ` [RFC PATCH 07/14] ASoC: qcom: add no osr clk flag to lpass variant Srinivas Kandagatla [not found] ` <1430414244-11168-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-05-02 23:58 ` Kenneth Westfield [this message] 2015-05-02 23:58 ` Kenneth Westfield 2015-05-05 7:17 ` Srinivas Kandagatla 2015-05-04 12:26 ` Mark Brown 2015-05-05 7:16 ` Srinivas Kandagatla 2015-04-30 17:17 ` [RFC PATCH 08/14] ASoC: qcom: add dma channel control offset to variant data Srinivas Kandagatla [not found] ` <1430414252-11210-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-05-02 23:59 ` Kenneth Westfield 2015-05-02 23:59 ` Kenneth Westfield 2015-05-05 7:16 ` Srinivas Kandagatla 2015-04-30 17:17 ` [RFC PATCH 09/14] ASoC: qcom: Add ability to handle interrupts per dma channel Srinivas Kandagatla 2015-05-03 0:00 ` Kenneth Westfield [not found] ` <20150502235950.GE27804-VfhoOQ2zEbNBVvN7MMdr1KRtKmQZhJ7pQQ4Iyu8u01E@public.gmane.org> 2015-05-05 7:17 ` Srinivas Kandagatla 2015-05-05 7:17 ` Srinivas Kandagatla [not found] ` <1430414148-10869-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-04-30 17:17 ` [RFC PATCH 10/14] ASoC: qcom: add bit map to track static dma channel allocations Srinivas Kandagatla 2015-04-30 17:17 ` Srinivas Kandagatla 2015-05-16 12:31 ` [PATCH v2 00/13] ASoC: qcom: add support to apq8016 audio Srinivas Kandagatla 2015-05-16 12:31 ` Srinivas Kandagatla 2015-05-16 12:32 ` [PATCH v2 01/13] ASoC: qcom: make lpass driver depend on OF Srinivas Kandagatla 2015-05-21 20:10 ` Mark Brown 2015-05-16 12:32 ` [PATCH v2 02/13] ASoC: qcom: move ipq806x specific bits out of lpass driver Srinivas Kandagatla [not found] ` <1431779537-1907-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-05-21 20:11 ` Mark Brown 2015-05-21 20:11 ` Mark Brown 2015-05-16 12:32 ` [PATCH v2 03/13] ASoC: qcom: remove hardcoded i2s port number Srinivas Kandagatla 2015-05-16 12:32 ` [PATCH v2 04/13] ASoC: qcom: remove hardcoded dma channel Srinivas Kandagatla 2015-05-21 20:12 ` Mark Brown 2015-05-16 12:32 ` [PATCH v2 05/13] ASoC: qcom: support bitclk and osrclk per i2s port Srinivas Kandagatla [not found] ` <1431779562-2034-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-05-17 16:14 ` Kenneth Westfield 2015-05-17 16:14 ` Kenneth Westfield 2015-05-16 12:32 ` [PATCH v2 06/13] ASoC: qcom: make osr clock optional Srinivas Kandagatla 2015-05-17 16:15 ` Kenneth Westfield 2015-05-16 12:32 ` [PATCH v2 07/13] ASoC: qcom: add dma channel control offset to variant data Srinivas Kandagatla 2015-05-16 12:33 ` [PATCH v2 08/13] ASoC: qcom: Add ability to handle interrupts per dma channel Srinivas Kandagatla 2015-05-16 12:33 ` [PATCH v2 09/13] ASoC: qcom: add bit map to track static dma channel allocations Srinivas Kandagatla 2015-05-16 12:33 ` [PATCH v2 10/13] ASoC: qcom: Add apq8016 lpass driver support Srinivas Kandagatla 2015-05-16 12:33 ` [PATCH v2 11/13] ASoC: qcom: add apq8016 sound card support Srinivas Kandagatla 2015-05-16 12:33 ` [PATCH v2 12/13] ASoC: qcom: Document apq8016 bindings Srinivas Kandagatla 2015-05-16 12:33 ` [PATCH v2 13/13] ASoC: qcom: document apq8016 sbc machine driver bindings Srinivas Kandagatla [not found] ` <1431779462-1732-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-05-17 16:15 ` [PATCH v2 00/13] ASoC: qcom: add support to apq8016 audio Kenneth Westfield 2015-05-17 16:15 ` Kenneth Westfield 2015-05-21 17:05 ` Mark Brown 2015-04-30 17:17 ` [RFC PATCH 11/14] ASoC: qcom: Add apq8016 lpass driver support Srinivas Kandagatla 2015-04-30 17:18 ` [RFC PATCH 12/14] ASoC: qcom: add apq8016 sound card support Srinivas Kandagatla 2015-05-03 0:01 ` Kenneth Westfield 2015-05-05 7:17 ` Srinivas Kandagatla 2015-04-30 17:18 ` [RFC PATCH 13/14] ASoC: qcom: Document apq8016 bindings Srinivas Kandagatla 2015-04-30 17:18 ` [RFC PATCH 14/14] ASoC: qcom: document apq8016 machine driver bindings Srinivas Kandagatla 2015-05-03 0:03 ` Kenneth Westfield 2015-05-03 3:59 ` Kenneth Westfield 2015-05-05 7:17 ` Srinivas Kandagatla [not found] ` <55486E6D.9010402-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-05-06 5:41 ` [alsa-devel] " Kenneth Westfield 2015-05-06 5:41 ` Kenneth Westfield 2015-05-02 23:57 ` [RFC PATCH 00/14] ASoC: qcom: add support to apq8016 audio Kenneth Westfield [not found] ` <20150502235704.GA27804-VfhoOQ2zEbNBVvN7MMdr1KRtKmQZhJ7pQQ4Iyu8u01E@public.gmane.org> 2015-05-06 5:47 ` Kenneth Westfield 2015-05-06 5:47 ` Kenneth Westfield [not found] ` <20150506054758.GD5639-VfhoOQ2zEbNBVvN7MMdr1KRtKmQZhJ7pQQ4Iyu8u01E@public.gmane.org> 2015-05-06 6:54 ` Srinivas Kandagatla 2015-05-06 6:54 ` Srinivas Kandagatla 2015-05-12 4:06 ` [alsa-devel] " Kenneth Westfield [not found] ` <20150512040600.GA24087-VfhoOQ2zEbNBVvN7MMdr1KRtKmQZhJ7pQQ4Iyu8u01E@public.gmane.org> 2015-05-12 10:21 ` Srinivas Kandagatla 2015-05-12 10:21 ` Srinivas Kandagatla 2015-05-12 17:04 ` Lars-Peter Clausen 2015-05-14 7:55 ` Srinivas Kandagatla 2015-05-12 13:11 ` Srinivas Kandagatla 2015-05-13 11:58 ` [PATCH v1 00/13] " Srinivas Kandagatla 2015-05-13 12:00 ` [PATCH v1 01/13] ASoC: qcom: make lpass driver depend on OF Srinivas Kandagatla 2015-05-13 12:00 ` [PATCH v1 03/13] ASoC: qcom: remove hardcoded i2s port number Srinivas Kandagatla [not found] ` <1431518302-7139-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-05-13 12:00 ` [PATCH v1 02/13] ASoC: qcom: move ipq806x specific bits out of lpass driver Srinivas Kandagatla 2015-05-13 12:00 ` Srinivas Kandagatla 2015-05-15 5:23 ` Kenneth Westfield 2015-05-15 8:48 ` Srinivas Kandagatla 2015-05-13 12:00 ` [PATCH v1 04/13] ASoC: qcom: remove hardcoded dma channel Srinivas Kandagatla 2015-05-13 12:00 ` Srinivas Kandagatla 2015-05-13 12:00 ` [PATCH v1 05/13] ASoC: qcom: support bitclk and osrclk per i2s port Srinivas Kandagatla 2015-05-13 12:00 ` Srinivas Kandagatla 2015-05-15 5:23 ` Kenneth Westfield 2015-05-15 8:44 ` Srinivas Kandagatla 2015-05-13 12:02 ` [PATCH v1 09/13] ASoC: qcom: add bit map to track static dma channel allocations Srinivas Kandagatla 2015-05-13 12:02 ` Srinivas Kandagatla 2015-05-13 12:02 ` [PATCH v1 06/13] ASoC: qcom: make osr clock optional Srinivas Kandagatla 2015-05-13 12:02 ` [PATCH v1 07/13] ASoC: qcom: add dma channel control offset to variant data Srinivas Kandagatla 2015-05-13 12:02 ` [PATCH v1 08/13] ASoC: qcom: Add ability to handle interrupts per dma channel Srinivas Kandagatla 2015-05-13 12:03 ` [PATCH v1 10/13] ASoC: qcom: Add apq8016 lpass driver support Srinivas Kandagatla 2015-05-15 5:23 ` Kenneth Westfield 2015-05-15 8:46 ` Srinivas Kandagatla 2015-05-13 12:03 ` [PATCH v1 11/13] ASoC: qcom: add apq8016 sound card support Srinivas Kandagatla 2015-05-15 5:23 ` Kenneth Westfield [not found] ` <20150515052348.GC31687-VfhoOQ2zEbNBVvN7MMdr1KRtKmQZhJ7pQQ4Iyu8u01E@public.gmane.org> 2015-05-15 8:47 ` Srinivas Kandagatla 2015-05-15 8:47 ` Srinivas Kandagatla 2015-05-13 12:03 ` [PATCH v1 12/13] ASoC: qcom: Document apq8016 bindings Srinivas Kandagatla 2015-05-13 12:03 ` [PATCH v1 13/13] ASoC: qcom: document apq8016 sbc machine driver bindings Srinivas Kandagatla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150502235800.GC27804@kwestfie-linux.qualcomm.com \ --to=kwestfie-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \ --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \ --cc=bgoswami-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \ --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \ --cc=perex-/Fr2/VpizcU@public.gmane.org \ --cc=plai-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=tiwai-l3A5Bk7waGM@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.