From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ricky Liang <jcliang@chromium.org>
Cc: Mike Turquette <mturquette@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Henry Chen <henryc.chen@mediatek.com>,
James Liao <jamesjj.liao@mediatek.com>,
"open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC..."
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC..."
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v3] clk: mediatek: Initialize clk_init_data
Date: Mon, 18 May 2015 16:11:20 +0200 [thread overview]
Message-ID: <20150518141120.GU6325@pengutronix.de> (raw)
In-Reply-To: <1431957632-2182-1-git-send-email-jcliang@chromium.org>
On Mon, May 18, 2015 at 10:00:26PM +0800, Ricky Liang wrote:
> The variable init (struct clk_init_data) is allocated on the stack.
> We weren't initializing the .flags field, so it contains random junk,
> which can cause all kinds of interesting issues when the flags are
> parsed by clk_register.
>
> Signed-off-by: Ricky Liang <jcliang@chromium.org>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] clk: mediatek: Initialize clk_init_data
Date: Mon, 18 May 2015 16:11:20 +0200 [thread overview]
Message-ID: <20150518141120.GU6325@pengutronix.de> (raw)
In-Reply-To: <1431957632-2182-1-git-send-email-jcliang@chromium.org>
On Mon, May 18, 2015 at 10:00:26PM +0800, Ricky Liang wrote:
> The variable init (struct clk_init_data) is allocated on the stack.
> We weren't initializing the .flags field, so it contains random junk,
> which can cause all kinds of interesting issues when the flags are
> parsed by clk_register.
>
> Signed-off-by: Ricky Liang <jcliang@chromium.org>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2015-05-18 14:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 14:00 [PATCH v3] clk: mediatek: Initialize clk_init_data Ricky Liang
2015-05-18 14:00 ` Ricky Liang
2015-05-18 14:00 ` Ricky Liang
2015-05-18 14:11 ` Sascha Hauer [this message]
2015-05-18 14:11 ` Sascha Hauer
2015-05-18 14:11 ` Sascha Hauer
2015-05-20 1:41 ` Stephen Boyd
2015-05-20 1:41 ` Stephen Boyd
2015-05-20 1:41 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518141120.GU6325@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=henryc.chen@mediatek.com \
--cc=jamesjj.liao@mediatek.com \
--cc=jcliang@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@linaro.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.