[rtc-linux] Re: [PATCH v2 0/7] Change snvs rtc and poweroff to use syscon add pwrkey driver - Russell King

From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Shawn Guo <shawnguo@kernel.org>
Cc: a.zummo@towertech.it, Frank.Li@freescale.com,
	rtc-linux@googlegroups.com, linux-pm@vger.kernel.org,
	dmitry.torokhov@gmail.com, devicetree@vger.kernel.org,
	robh+dt@kernel.org, alexandre.belloni@free-electrons.com,
	p.zabel@pengutronix.de, linux-input@vger.kernel.org,
	lznuaa@gmail.com, shawn.guo@linaro.org,
	linux-arm-kernel@lists.infradead.org
Subject: [rtc-linux] Re: [PATCH v2 0/7] Change snvs rtc and poweroff to use syscon add pwrkey driver
Date: Wed, 20 May 2015 19:30:50 +0100	[thread overview]
Message-ID: <20150520183050.GR2067@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20150520182540.GQ2067@n2100.arm.linux.org.uk>

On Wed, May 20, 2015 at 07:25:41PM +0100, Russell King - ARM Linux wrote:
> On Wed, May 20, 2015 at 09:58:51AM +0800, Shawn Guo wrote:
> > On Wed, May 20, 2015 at 01:04:35AM +0800, Frank.Li@freescale.com wrote:
> > > Frank Li (6):
> > >   arm: imx: power-off: change to syscon to access register
> > >   rtc: arm: imx: snvs: change use syscon to access register
> > >   Document: dt: fsl: snvs: change support syscon
> > >   arm: dts: imx: update snvs to use syscon access register
> > >   document: devicetree: input: imx: i.mx snvs power device tree bindings
> > >   arm: dts: imx6sx: enable snvs power key
> > 
> > So, the series will break existing DTBs for RTC and poweroff, right?
> > If this is unavoidable, should we at least have some warning messages
> > telling users about his breakage?
> 
> What's the justification for breaking existing DTBs?  Really, this is
> something we should strive to avoid, _and_ actually avoid by providing
> backwards compatibility.

Looking at the RTC code, it would be pretty trivial to do.

Rather than passing around struct regmap, pass around the private data
structure.

Rename the regmap_* function calls to be private accessors.  Implement
a set of new accessors - if the private data has the regmap, use the
regmap API.  Otherwise, use the old method, and print a warning that an
old DT is being used.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.