From: Felipe Balbi <balbi@ti.com> To: Tony Lindgren <tony@atomide.com> Cc: Felipe Balbi <balbi@ti.com>, Russell King <linux@arm.linux.org.uk>, Linux ARM Kernel Mailing List <linux-arm-kernel@lists.infradead.org>, Linux OMAP Mailing List <linux-omap@vger.kernel.org> Subject: Re: [RFC/NOT FOR MERGING] HACK: add global/private timers for A9 Date: Wed, 3 Jun 2015 22:45:56 -0500 [thread overview] Message-ID: <20150604034550.GA25075@saruman.tx.rr.com> (raw) In-Reply-To: <20150603222619.GY30984@atomide.com> [-- Attachment #1: Type: text/plain, Size: 2832 bytes --] Hi, On Wed, Jun 03, 2015 at 03:26:20PM -0700, Tony Lindgren wrote: > * Felipe Balbi <balbi@ti.com> [150603 13:36]: > > --- a/arch/arm/mach-omap2/timer.c > > +++ b/arch/arm/mach-omap2/timer.c > > @@ -655,20 +655,18 @@ static OMAP_SYS_32K_TIMER_INIT(4, 1, "timer_32k_ck", "ti,timer-alwon", > > static DEFINE_TWD_LOCAL_TIMER(twd_local_timer, OMAP44XX_LOCAL_TWD_BASE, 29); > > void __init omap4_local_timer_init(void) > > { > > + int err; > > + > > omap4_sync32k_timer_init(); > > /* Local timers are not supprted on OMAP4430 ES1.0 */ > > - if (omap_rev() != OMAP4430_REV_ES1_0) { > > - int err; > > - > > - if (of_have_populated_dt()) { > > - clocksource_of_init(); > > - return; > > - } > > - > > - err = twd_local_timer_register(&twd_local_timer); > > - if (err) > > - pr_err("twd_local_timer_register failed %d\n", err); > > + if (of_have_populated_dt()) { > > + clocksource_of_init(); > > + return; > > } > > + > > + err = twd_local_timer_register(&twd_local_timer); > > + if (err) > > + pr_err("twd_local_timer_register failed %d\n", err); > > } > > #else > > void __init omap4_local_timer_init(void) > > Looks like can get rid of even more code here, see the patch below. > > Regards, > > Tony > > 8< ------------------------ > From: Tony Lindgren <tony@atomide.com> > Date: Wed, 3 Jun 2015 14:40:40 -0700 > Subject: [PATCH] ARM: OMAP2+: Clean up omap4_local_timer_init > > Inspired by a patch from Felipe Balbi <balbi@ti.com>, we can > now get rid of most the code in omap4_local_timer_init. > > Omap4 is now device tree only.. And we have not properly supported > omap4 ES1.0 revision for a really long time AFAIK. > > Let's just remove all that code to simplify things. This assumes > we have arm,cortex-a9-twd-timer entry in the omap4.dtsi file, which > we do. > > Signed-off-by: Tony Lindgren <tony@atomide.com> very true Reviewed-by: Felipe Balbi <balbi@ti.com> > --- a/arch/arm/mach-omap2/timer.c > +++ b/arch/arm/mach-omap2/timer.c > @@ -649,23 +649,10 @@ static OMAP_SYS_32K_TIMER_INIT(4, 1, "timer_32k_ck", "ti,timer-alwon", > > #ifdef CONFIG_ARCH_OMAP4 > #ifdef CONFIG_HAVE_ARM_TWD > -static DEFINE_TWD_LOCAL_TIMER(twd_local_timer, OMAP44XX_LOCAL_TWD_BASE, 29); > void __init omap4_local_timer_init(void) > { > omap4_sync32k_timer_init(); > - /* Local timers are not supprted on OMAP4430 ES1.0 */ > - if (omap_rev() != OMAP4430_REV_ES1_0) { > - int err; > - > - if (of_have_populated_dt()) { > - clocksource_of_init(); > - return; > - } > - > - err = twd_local_timer_register(&twd_local_timer); > - if (err) > - pr_err("twd_local_timer_register failed %d\n", err); > - } > + clocksource_of_init(); > } > #else > void __init omap4_local_timer_init(void) -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi) To: linux-arm-kernel@lists.infradead.org Subject: [RFC/NOT FOR MERGING] HACK: add global/private timers for A9 Date: Wed, 3 Jun 2015 22:45:56 -0500 [thread overview] Message-ID: <20150604034550.GA25075@saruman.tx.rr.com> (raw) In-Reply-To: <20150603222619.GY30984@atomide.com> Hi, On Wed, Jun 03, 2015 at 03:26:20PM -0700, Tony Lindgren wrote: > * Felipe Balbi <balbi@ti.com> [150603 13:36]: > > --- a/arch/arm/mach-omap2/timer.c > > +++ b/arch/arm/mach-omap2/timer.c > > @@ -655,20 +655,18 @@ static OMAP_SYS_32K_TIMER_INIT(4, 1, "timer_32k_ck", "ti,timer-alwon", > > static DEFINE_TWD_LOCAL_TIMER(twd_local_timer, OMAP44XX_LOCAL_TWD_BASE, 29); > > void __init omap4_local_timer_init(void) > > { > > + int err; > > + > > omap4_sync32k_timer_init(); > > /* Local timers are not supprted on OMAP4430 ES1.0 */ > > - if (omap_rev() != OMAP4430_REV_ES1_0) { > > - int err; > > - > > - if (of_have_populated_dt()) { > > - clocksource_of_init(); > > - return; > > - } > > - > > - err = twd_local_timer_register(&twd_local_timer); > > - if (err) > > - pr_err("twd_local_timer_register failed %d\n", err); > > + if (of_have_populated_dt()) { > > + clocksource_of_init(); > > + return; > > } > > + > > + err = twd_local_timer_register(&twd_local_timer); > > + if (err) > > + pr_err("twd_local_timer_register failed %d\n", err); > > } > > #else > > void __init omap4_local_timer_init(void) > > Looks like can get rid of even more code here, see the patch below. > > Regards, > > Tony > > 8< ------------------------ > From: Tony Lindgren <tony@atomide.com> > Date: Wed, 3 Jun 2015 14:40:40 -0700 > Subject: [PATCH] ARM: OMAP2+: Clean up omap4_local_timer_init > > Inspired by a patch from Felipe Balbi <balbi@ti.com>, we can > now get rid of most the code in omap4_local_timer_init. > > Omap4 is now device tree only.. And we have not properly supported > omap4 ES1.0 revision for a really long time AFAIK. > > Let's just remove all that code to simplify things. This assumes > we have arm,cortex-a9-twd-timer entry in the omap4.dtsi file, which > we do. > > Signed-off-by: Tony Lindgren <tony@atomide.com> very true Reviewed-by: Felipe Balbi <balbi@ti.com> > --- a/arch/arm/mach-omap2/timer.c > +++ b/arch/arm/mach-omap2/timer.c > @@ -649,23 +649,10 @@ static OMAP_SYS_32K_TIMER_INIT(4, 1, "timer_32k_ck", "ti,timer-alwon", > > #ifdef CONFIG_ARCH_OMAP4 > #ifdef CONFIG_HAVE_ARM_TWD > -static DEFINE_TWD_LOCAL_TIMER(twd_local_timer, OMAP44XX_LOCAL_TWD_BASE, 29); > void __init omap4_local_timer_init(void) > { > omap4_sync32k_timer_init(); > - /* Local timers are not supprted on OMAP4430 ES1.0 */ > - if (omap_rev() != OMAP4430_REV_ES1_0) { > - int err; > - > - if (of_have_populated_dt()) { > - clocksource_of_init(); > - return; > - } > - > - err = twd_local_timer_register(&twd_local_timer); > - if (err) > - pr_err("twd_local_timer_register failed %d\n", err); > - } > + clocksource_of_init(); > } > #else > void __init omap4_local_timer_init(void) -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150603/ac1dcc88/attachment.sig>
next prev parent reply other threads:[~2015-06-04 3:48 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-03 20:32 [RFC/NOT FOR MERGING] HACK: add global/private timers for A9 Felipe Balbi 2015-06-03 20:32 ` Felipe Balbi 2015-06-03 20:44 ` Tony Lindgren 2015-06-03 20:44 ` Tony Lindgren 2015-06-03 20:55 ` Arnd Bergmann 2015-06-03 20:55 ` Arnd Bergmann 2015-06-03 21:04 ` Felipe Balbi 2015-06-03 21:04 ` Felipe Balbi 2015-06-03 21:28 ` Felipe Balbi 2015-06-03 21:28 ` Felipe Balbi 2015-06-03 21:41 ` Stephen Boyd 2015-06-03 21:41 ` Stephen Boyd 2015-06-03 21:54 ` Felipe Balbi 2015-06-03 21:54 ` Felipe Balbi 2015-06-04 9:46 ` Mason 2015-06-04 9:46 ` Mason 2015-06-04 19:05 ` Felipe Balbi 2015-06-04 19:05 ` Felipe Balbi 2015-06-04 20:08 ` Felipe Balbi 2015-06-04 20:08 ` Felipe Balbi 2015-06-04 20:18 ` Felipe Balbi 2015-06-04 20:18 ` Felipe Balbi 2015-06-04 20:29 ` Felipe Balbi 2015-06-04 20:29 ` Felipe Balbi 2015-06-04 22:20 ` Stephen Boyd 2015-06-04 22:20 ` Stephen Boyd 2015-06-05 15:42 ` Felipe Balbi 2015-06-05 15:42 ` Felipe Balbi 2015-06-04 20:32 ` Mason 2015-06-04 20:32 ` Mason 2015-06-04 20:37 ` Felipe Balbi 2015-06-04 20:37 ` Felipe Balbi 2015-06-04 21:00 ` Mason 2015-06-04 21:00 ` Mason 2015-06-04 21:46 ` Tony Lindgren 2015-06-04 21:46 ` Tony Lindgren 2015-06-03 22:26 ` Tony Lindgren 2015-06-03 22:26 ` Tony Lindgren 2015-06-04 3:45 ` Felipe Balbi [this message] 2015-06-04 3:45 ` Felipe Balbi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150604034550.GA25075@saruman.tx.rr.com \ --to=balbi@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.