From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Konstantin Khlebnikov <koct9i@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Paul Cassella <cassella@cray.com>,
Steve Capper <steve.capper@linaro.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
linux-mm@kvack.org
Subject: Re: [PATCH 1/9] mm: Provide new get_vaddr_frames() helper
Date: Thu, 11 Jun 2015 17:01:15 +0900 [thread overview]
Message-ID: <20150611080115.GB515@swordfish> (raw)
In-Reply-To: <f8d212d88c005564f3faedf1c7d6f089fcb3126d.1433927458.git.mchehab@osg.samsung.com>
On (06/10/15 06:20), Mauro Carvalho Chehab wrote:
[..]
> +
> +/**
> + * frame_vector_destroy() - free memory allocated to carry frame vector
> + * @vec: Frame vector to free
> + *
> + * Free structure allocated by frame_vector_create() to carry frames.
> + */
> +void frame_vector_destroy(struct frame_vector *vec)
> +{
> + /* Make sure put_vaddr_frames() got called properly... */
> + VM_BUG_ON(vec->nr_frames > 0);
> + if (!is_vmalloc_addr(vec))
> + kfree(vec);
> + else
> + vfree(vec);
minor: kvfree(vec);
-ss
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Konstantin Khlebnikov <koct9i@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Paul Cassella <cassella@cray.com>,
Steve Capper <steve.capper@linaro.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
linux-mm@kvack.org
Subject: Re: [PATCH 1/9] mm: Provide new get_vaddr_frames() helper
Date: Thu, 11 Jun 2015 17:01:15 +0900 [thread overview]
Message-ID: <20150611080115.GB515@swordfish> (raw)
In-Reply-To: <f8d212d88c005564f3faedf1c7d6f089fcb3126d.1433927458.git.mchehab@osg.samsung.com>
On (06/10/15 06:20), Mauro Carvalho Chehab wrote:
[..]
> +
> +/**
> + * frame_vector_destroy() - free memory allocated to carry frame vector
> + * @vec: Frame vector to free
> + *
> + * Free structure allocated by frame_vector_create() to carry frames.
> + */
> +void frame_vector_destroy(struct frame_vector *vec)
> +{
> + /* Make sure put_vaddr_frames() got called properly... */
> + VM_BUG_ON(vec->nr_frames > 0);
> + if (!is_vmalloc_addr(vec))
> + kfree(vec);
> + else
> + vfree(vec);
minor: kvfree(vec);
-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-06-11 8:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 9:20 [PATCH 0/9] Helper to abstract vma handling in media layer Mauro Carvalho Chehab
2015-06-10 9:20 ` [PATCH 1/9] mm: Provide new get_vaddr_frames() helper Mauro Carvalho Chehab
2015-06-10 9:20 ` Mauro Carvalho Chehab
2015-06-11 8:01 ` Sergey Senozhatsky [this message]
2015-06-11 8:01 ` Sergey Senozhatsky
2015-06-10 9:20 ` [PATCH 2/9] [media] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() Mauro Carvalho Chehab
2015-06-11 4:21 ` Laurent Pinchart
2015-06-11 17:23 ` Hans Verkuil
2015-06-12 9:21 ` Tomi Valkeinen
2015-06-12 9:26 ` Laurent Pinchart
2015-06-12 9:44 ` Tomi Valkeinen
2015-06-10 9:20 ` [PATCH 3/9] [media] vb2: Provide helpers for mapping virtual addresses Mauro Carvalho Chehab
2015-06-10 9:20 ` [PATCH 4/9] [media] media: vb2: Convert vb2_dma_sg_get_userptr() to use frame vector Mauro Carvalho Chehab
2015-06-10 9:20 ` [PATCH 5/9] [media] media: vb2: Convert vb2_vmalloc_get_userptr() " Mauro Carvalho Chehab
2015-06-10 9:20 ` [PATCH 6/9] [media] media: vb2: Convert vb2_dc_get_userptr() " Mauro Carvalho Chehab
2015-06-10 9:20 ` [PATCH 7/9] [media] media: vb2: Remove unused functions Mauro Carvalho Chehab
2015-06-10 9:20 ` [PATCH 8/9] [media] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_frames() Mauro Carvalho Chehab
2015-06-10 9:20 ` Mauro Carvalho Chehab
2015-06-10 9:20 ` [PATCH 9/9] [media] mm: Move get_vaddr_frames() behind a config option Mauro Carvalho Chehab
2015-06-10 9:20 ` Mauro Carvalho Chehab
2015-06-10 9:20 ` Mauro Carvalho Chehab
2015-06-10 9:20 ` Mauro Carvalho Chehab
2015-06-10 16:37 ` Josh Triplett
2015-06-10 16:37 ` Josh Triplett
2015-06-10 16:37 ` Josh Triplett
2015-06-10 16:37 ` Josh Triplett
2015-06-18 13:44 ` Jan Kara
2015-06-18 13:44 ` Jan Kara
2015-06-18 13:44 ` Jan Kara
2015-06-18 13:44 ` Jan Kara
2015-06-11 9:08 ` [PATCH 0/9] Helper to abstract vma handling in media layer Hans Verkuil
2015-06-11 18:54 ` Andrew Morton
2015-06-11 19:51 ` Hans Verkuil
2015-06-15 7:41 ` Hans Verkuil
2015-06-22 22:04 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150611080115.GB515@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cassella@cray.com \
--cc=gorcunov@openvz.org \
--cc=hannes@cmpxchg.org \
--cc=hans.verkuil@cisco.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jack@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=koct9i@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mchehab@infradead.org \
--cc=mchehab@osg.samsung.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=steve.capper@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.