Re: [PATCH 1/2] drm/exynos: ipp: fix wrong index referencing a config element

From: Hyungwon Hwang <human.hwang@samsung.com>
To: Hyungwon Hwang <human.hwang@samsung.com>
Cc: devicetree@vger.kernel.org, sw0312.kim@samsung.com,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/exynos: ipp: fix wrong index referencing a config element
Date: Fri, 12 Jun 2015 22:02:17 +0900	[thread overview]
Message-ID: <20150612220217.481d938e@hwh-ubuntu> (raw)
In-Reply-To: <1434113958-15877-17-git-send-email-human.hwang@samsung.com>

Please ignore this mail. I didn't know that "git send *" includes all
files in the subdirectories. I am very sorry for disturbing you.

Best regards,
Hyungwon Hwang

On Fri, 12 Jun 2015 21:59:11 +0900
Hyungwon Hwang <human.hwang@samsung.com> wrote:

> Config depends on the opreation. So it must be referenced by an
> operation id, not a property id.
> 
> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_ipp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c
> b/drivers/gpu/drm/exynos/exynos_drm_ipp.c index b7f1cbc..54c5cf4
> 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_ipp.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_ipp.c
> @@ -486,8 +486,7 @@ static int ipp_validate_mem_node(struct
> drm_device *drm_dev, unsigned int bpp;
>  	int i;
>  
> -	/* The property id should already be varified */
> -	ipp_cfg = &c_node->property.config[m_node->prop_id];
> +	ipp_cfg = &c_node->property.config[m_node->ops_id];
>  	num_plane = drm_format_num_planes(ipp_cfg->fmt);
>  
>  	/**

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel