From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Yakir Yang <ykk@rock-chips.com>,
linux-rockchip@lists.infradead.org,
alsa-devel <alsa-devel@alsa-project.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Doug Anderson <dianders@chromium.org>,
David Airlie <airlied@linux.ie>,
Philipp Zabel <p.zabel@pengutronix.de>,
Andy Yan <andy.yan@rock-chips.com>,
Daniel Kurtz <djkurtz@chromium.org>,
Fabio Estevam <fabio.estevam@freescale.com>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de>,
Jaroslav Kysela <perex@perex.cz>,
Heiko Stuebner <heiko@sntech.de>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver
Date: Mon, 22 Jun 2015 11:10:38 +0100 [thread overview]
Message-ID: <20150622101038.GV7557@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1434967564.31094.20.camel@x220>
On Mon, Jun 22, 2015 at 12:06:04PM +0200, Paul Bolle wrote:
> But I think there's no platform_device with a "dw-hdmi-i2s-audio" name.
> So I wonder whether this MODULE_ALIAS() is actually needed. What breaks
> if you leave it out?
+ } else if (hdmi_readb(hdmi, HDMI_CONFIG0_ID) & HDMI_CONFIG0_I2S) {
+ pdevinfo.name = "dw-hdmi-ahb-audio";
This should be "dw-hdmi-i2s-audio" to avoid picking up on my AHB audio
driver.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel <alsa-devel@alsa-project.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
dri-devel <dri-devel@lists.freedesktop.org>,
Doug Anderson <dianders@chromium.org>,
linux-rockchip@lists.infradead.org,
Mark Brown <broonie@kernel.org>, Yakir Yang <ykk@rock-chips.com>,
Andy Yan <andy.yan@rock-chips.com>,
Jaroslav Kysela <perex@perex.cz>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver
Date: Mon, 22 Jun 2015 11:10:38 +0100 [thread overview]
Message-ID: <20150622101038.GV7557@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1434967564.31094.20.camel@x220>
On Mon, Jun 22, 2015 at 12:06:04PM +0200, Paul Bolle wrote:
> But I think there's no platform_device with a "dw-hdmi-i2s-audio" name.
> So I wonder whether this MODULE_ALIAS() is actually needed. What breaks
> if you leave it out?
+ } else if (hdmi_readb(hdmi, HDMI_CONFIG0_ID) & HDMI_CONFIG0_I2S) {
+ pdevinfo.name = "dw-hdmi-ahb-audio";
This should be "dw-hdmi-i2s-audio" to avoid picking up on my AHB audio
driver.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver
Date: Mon, 22 Jun 2015 11:10:38 +0100 [thread overview]
Message-ID: <20150622101038.GV7557@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1434967564.31094.20.camel@x220>
On Mon, Jun 22, 2015 at 12:06:04PM +0200, Paul Bolle wrote:
> But I think there's no platform_device with a "dw-hdmi-i2s-audio" name.
> So I wonder whether this MODULE_ALIAS() is actually needed. What breaks
> if you leave it out?
+ } else if (hdmi_readb(hdmi, HDMI_CONFIG0_ID) & HDMI_CONFIG0_I2S) {
+ pdevinfo.name = "dw-hdmi-ahb-audio";
This should be "dw-hdmi-i2s-audio" to avoid picking up on my AHB audio
driver.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-06-22 10:11 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 16:13 [PATCH v5 0/6] Add dw_hdmi i2s audio support Yakir Yang
2015-06-19 16:13 ` Yakir Yang
2015-06-19 16:13 ` Yakir Yang
2015-06-19 16:19 ` [PATCH v5 1/6] drm: bridge/dw_hdmi: add audio support for more display resolutions Yakir Yang
2015-06-19 16:19 ` Yakir Yang
2015-06-19 16:19 ` Yakir Yang
2015-06-19 16:44 ` Russell King - ARM Linux
2015-06-19 16:44 ` Russell King - ARM Linux
2015-06-19 16:44 ` Russell King - ARM Linux
2015-07-22 19:05 ` Russell King - ARM Linux
2015-07-22 19:05 ` Russell King - ARM Linux
2015-07-22 19:05 ` Russell King - ARM Linux
2015-06-19 16:21 ` [PATCH v5 2/6] drm: bridge/dw_hdmi: enable audio when sink device is HDMI and has audio Yakir Yang
2015-06-19 16:21 ` Yakir Yang
2015-06-19 16:21 ` Yakir Yang
2015-06-19 16:24 ` [PATCH v5 3/6] drm: bridge/dw_hdmi: rename dw_hdmi-ahb-audio.h to dw_hdmi-audio.h Yakir Yang
2015-06-19 16:24 ` Yakir Yang
2015-06-19 16:24 ` Yakir Yang
2015-06-19 16:28 ` [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver Yakir Yang
2015-06-19 16:28 ` Yakir Yang
2015-06-19 16:28 ` Yakir Yang
2015-06-22 10:06 ` Paul Bolle
2015-06-22 10:06 ` Paul Bolle
2015-06-22 10:06 ` Paul Bolle
2015-06-22 10:10 ` Russell King - ARM Linux [this message]
2015-06-22 10:10 ` Russell King - ARM Linux
2015-06-22 10:10 ` Russell King - ARM Linux
2015-06-23 3:07 ` Yakir Yang
2015-06-23 3:07 ` Yakir Yang
2015-06-23 3:07 ` Yakir Yang
2015-06-23 3:03 ` Yakir Yang
2015-06-23 3:06 ` Yakir Yang
2015-06-23 3:06 ` Yakir Yang
2015-06-23 3:06 ` Yakir Yang
2015-08-08 15:35 ` Russell King - ARM Linux
2015-08-08 15:35 ` Russell King - ARM Linux
2015-08-08 15:35 ` Russell King - ARM Linux
2015-08-09 6:17 ` Yakir Yang
2015-08-25 6:52 ` Mark Brown
2015-08-25 6:52 ` Mark Brown
2015-08-25 6:52 ` Mark Brown
2015-06-19 16:31 ` [PATCH v5 5/6] ASoC: rockchip/rockchip-hdmi-audio: add sound driver for hdmi audio Yakir Yang
2015-06-19 16:31 ` Yakir Yang
2015-06-19 16:31 ` Yakir Yang
2015-06-19 16:33 ` [PATCH v5 6/6] dt-bindings: Add documentation for rockchip-hdmi-audio driver Yakir Yang
2015-06-19 16:33 ` Yakir Yang
2015-06-19 16:33 ` Yakir Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150622101038.GV7557@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=airlied@linux.ie \
--cc=alsa-devel@alsa-project.org \
--cc=andy.yan@rock-chips.com \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@freescale.com \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=pebolle@tiscali.nl \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.