From: Dan Williams <dan.j.williams@intel.com> To: linux-nvdimm@lists.01.org Cc: axboe@kernel.dk, boaz@plexistor.com, toshi.kani@hp.com, Vishal Verma <vishal.l.verma@linux.intel.com>, linux-kernel@vger.kernel.org, mingo@kernel.org, linux-acpi@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@lst.de Subject: [PATCH v2 10/17] pmem: make_request cleanups Date: Thu, 25 Jun 2015 05:37:11 -0400 [thread overview] Message-ID: <20150625093711.40066.20740.stgit@dwillia2-desk3.jf.intel.com> (raw) In-Reply-To: <20150625090554.40066.69562.stgit@dwillia2-desk3.jf.intel.com> Various cleanups: 1/ Kill the BUG_ON since we've already told the block layer we don't support DISCARD on all these drivers. 2/ Kill the 'rw' variable, no need to cache it. 3/ Kill the local 'sector' variable. bio_for_each_segment() is already advancing the iterator's sector number by the bio_vec length. 4/ Kill the check for accessing past the end of device generic_make_request_checks() already does that. Suggested-by: Christoph Hellwig <hch@lst.de> [hch: kill access past end of the device check] Reviewed-by: Vishal Verma <vishal.l.verma@linux.intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/nvdimm/pmem.c | 26 +++++--------------------- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index d29a42adb95a..e846a627ebdf 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -58,31 +58,15 @@ static void pmem_do_bvec(struct pmem_device *pmem, struct page *page, static void pmem_make_request(struct request_queue *q, struct bio *bio) { - struct block_device *bdev = bio->bi_bdev; - struct pmem_device *pmem = bdev->bd_disk->private_data; - int rw; struct bio_vec bvec; - sector_t sector; struct bvec_iter iter; - int err = 0; - - if (bio_end_sector(bio) > get_capacity(bdev->bd_disk)) { - err = -EIO; - goto out; - } - - BUG_ON(bio->bi_rw & REQ_DISCARD); + struct block_device *bdev = bio->bi_bdev; + struct pmem_device *pmem = bdev->bd_disk->private_data; - rw = bio_data_dir(bio); - sector = bio->bi_iter.bi_sector; - bio_for_each_segment(bvec, bio, iter) { + bio_for_each_segment(bvec, bio, iter) pmem_do_bvec(pmem, bvec.bv_page, bvec.bv_len, bvec.bv_offset, - rw, sector); - sector += bvec.bv_len >> 9; - } - -out: - bio_endio(bio, err); + bio_data_dir(bio), iter.bi_sector); + bio_endio(bio, 0); } static int pmem_rw_page(struct block_device *bdev, sector_t sector,
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com> To: linux-nvdimm@ml01.01.org Cc: axboe@kernel.dk, boaz@plexistor.com, toshi.kani@hp.com, Vishal Verma <vishal.l.verma@linux.intel.com>, linux-kernel@vger.kernel.org, mingo@kernel.org, linux-acpi@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@lst.de Subject: [PATCH v2 10/17] pmem: make_request cleanups Date: Thu, 25 Jun 2015 05:37:11 -0400 [thread overview] Message-ID: <20150625093711.40066.20740.stgit@dwillia2-desk3.jf.intel.com> (raw) In-Reply-To: <20150625090554.40066.69562.stgit@dwillia2-desk3.jf.intel.com> Various cleanups: 1/ Kill the BUG_ON since we've already told the block layer we don't support DISCARD on all these drivers. 2/ Kill the 'rw' variable, no need to cache it. 3/ Kill the local 'sector' variable. bio_for_each_segment() is already advancing the iterator's sector number by the bio_vec length. 4/ Kill the check for accessing past the end of device generic_make_request_checks() already does that. Suggested-by: Christoph Hellwig <hch@lst.de> [hch: kill access past end of the device check] Reviewed-by: Vishal Verma <vishal.l.verma@linux.intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/nvdimm/pmem.c | 26 +++++--------------------- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index d29a42adb95a..e846a627ebdf 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -58,31 +58,15 @@ static void pmem_do_bvec(struct pmem_device *pmem, struct page *page, static void pmem_make_request(struct request_queue *q, struct bio *bio) { - struct block_device *bdev = bio->bi_bdev; - struct pmem_device *pmem = bdev->bd_disk->private_data; - int rw; struct bio_vec bvec; - sector_t sector; struct bvec_iter iter; - int err = 0; - - if (bio_end_sector(bio) > get_capacity(bdev->bd_disk)) { - err = -EIO; - goto out; - } - - BUG_ON(bio->bi_rw & REQ_DISCARD); + struct block_device *bdev = bio->bi_bdev; + struct pmem_device *pmem = bdev->bd_disk->private_data; - rw = bio_data_dir(bio); - sector = bio->bi_iter.bi_sector; - bio_for_each_segment(bvec, bio, iter) { + bio_for_each_segment(bvec, bio, iter) pmem_do_bvec(pmem, bvec.bv_page, bvec.bv_len, bvec.bv_offset, - rw, sector); - sector += bvec.bv_len >> 9; - } - -out: - bio_endio(bio, err); + bio_data_dir(bio), iter.bi_sector); + bio_endio(bio, 0); } static int pmem_rw_page(struct block_device *bdev, sector_t sector,
next prev parent reply other threads:[~2015-06-25 9:37 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-25 9:36 [PATCH v2 00/17] libnvdimm: ->rw_bytes(), BLK, BTT, PMEM api, and unit tests Dan Williams 2015-06-25 9:36 ` Dan Williams 2015-06-25 9:36 ` [PATCH v2 01/17] libnvdimm: infrastructure for btt devices Dan Williams 2015-06-25 9:36 ` Dan Williams 2015-06-25 9:36 ` [PATCH v2 02/17] nd_btt: atomic sector updates Dan Williams 2015-06-25 9:36 ` Dan Williams 2015-06-25 9:36 ` [PATCH v2 03/17] libnvdimm, nfit, nd_blk: driver for BLK-mode access persistent memory Dan Williams 2015-06-25 9:36 ` Dan Williams 2015-06-25 9:36 ` [PATCH v2 04/17] tools/testing/nvdimm: libnvdimm unit test infrastructure Dan Williams 2015-06-25 9:36 ` Dan Williams 2015-06-25 9:36 ` [PATCH v2 05/17] libnvdimm: Non-Volatile Devices Dan Williams 2015-06-25 9:36 ` Dan Williams 2015-06-25 9:36 ` Dan Williams 2015-06-25 9:36 ` [PATCH v2 06/17] fs/block_dev.c: skip rw_page if bdev has integrity Dan Williams 2015-06-25 9:36 ` Dan Williams 2015-06-25 9:36 ` [PATCH v2 07/17] libnvdimm, btt: add support for blk integrity Dan Williams 2015-06-25 9:36 ` Dan Williams 2015-06-25 9:37 ` [PATCH v2 08/17] libnvdimm, blk: " Dan Williams 2015-06-25 9:37 ` Dan Williams 2015-06-25 9:37 ` [PATCH v2 09/17] libnvdimm, pmem: fix up max_hw_sectors Dan Williams 2015-06-25 9:37 ` Dan Williams 2015-06-25 9:37 ` Dan Williams [this message] 2015-06-25 9:37 ` [PATCH v2 10/17] pmem: make_request cleanups Dan Williams 2015-06-25 9:37 ` [PATCH v2 11/17] libnvdimm: enable iostat Dan Williams 2015-06-25 9:37 ` Dan Williams 2015-06-25 9:37 ` [PATCH v2 12/17] pmem: flag pmem block devices as non-rotational Dan Williams 2015-06-25 9:37 ` Dan Williams 2015-06-25 9:37 ` [PATCH v2 13/17] libnvdimm, nfit: handle unarmed dimms, mark namespaces read-only Dan Williams 2015-06-25 9:37 ` Dan Williams 2015-06-25 9:37 ` [PATCH v2 14/17] acpi: Add acpi_map_pxm_to_online_node() Dan Williams 2015-06-25 9:37 ` Dan Williams 2015-06-25 9:37 ` [PATCH v2 15/17] libnvdimm: Set numa_node to NVDIMM devices Dan Williams 2015-06-25 9:37 ` Dan Williams 2015-06-25 17:45 ` Toshi Kani 2015-06-25 17:45 ` Toshi Kani 2015-06-25 17:47 ` Dan Williams 2015-06-25 17:47 ` Dan Williams 2015-06-25 18:34 ` Williams, Dan J 2015-06-25 18:34 ` Williams, Dan J 2015-06-25 21:31 ` Dan Williams 2015-06-25 21:31 ` Dan Williams 2015-06-25 21:51 ` Toshi Kani 2015-06-25 21:51 ` Toshi Kani 2015-06-25 22:00 ` Dan Williams 2015-06-25 22:00 ` Dan Williams 2015-06-25 22:11 ` Toshi Kani 2015-06-25 22:11 ` Toshi Kani 2015-06-25 22:34 ` Dan Williams 2015-06-25 22:34 ` Dan Williams 2015-06-25 22:55 ` Toshi Kani 2015-06-25 22:55 ` Toshi Kani 2015-06-25 23:42 ` Williams, Dan J 2015-06-25 23:42 ` Williams, Dan J 2015-06-26 0:55 ` Toshi Kani 2015-06-26 0:55 ` Toshi Kani 2015-06-26 1:08 ` Dan Williams 2015-06-26 1:08 ` Dan Williams 2015-06-26 1:21 ` Toshi Kani 2015-06-26 1:21 ` Toshi Kani 2015-06-25 9:37 ` [PATCH v2 16/17] libnvdimm: Add sysfs " Dan Williams 2015-06-25 9:37 ` Dan Williams 2015-06-26 2:21 ` Toshi Kani 2015-06-26 2:21 ` Toshi Kani 2015-06-26 15:26 ` Dan Williams 2015-06-26 15:26 ` Dan Williams 2015-06-25 9:37 ` [PATCH v2 17/17] arch, x86: pmem api for ensuring durability of persistent memory updates Dan Williams 2015-06-25 9:37 ` Dan Williams 2015-06-30 10:21 ` Dan Carpenter 2015-06-30 16:23 ` Williams, Dan J 2015-06-30 16:23 ` Williams, Dan J
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150625093711.40066.20740.stgit@dwillia2-desk3.jf.intel.com \ --to=dan.j.williams@intel.com \ --cc=axboe@kernel.dk \ --cc=boaz@plexistor.com \ --cc=hch@lst.de \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=mingo@kernel.org \ --cc=toshi.kani@hp.com \ --cc=vishal.l.verma@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.