From: Lukasz Majewski <l.majewski@samsung.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-pm@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
linux-kernel@vger.kernel.org, Jean Delvare <jdelvare@suse.de>,
Peter Feuerer <peter@piie.net>, Heiko Stuebner <heiko@sntech.de>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Darren Hart <dvhart@infradead.org>,
lm-sensors@lm-sensors.org
Subject: Re: [PATCH] thermal: consistently use int for temperatures
Date: Mon, 06 Jul 2015 12:26:40 +0200 [thread overview]
Message-ID: <20150706122640.2a61ca05@amdc2363> (raw)
In-Reply-To: <1436167189-29835-1-git-send-email-s.hauer@pengutronix.de>
Hi Sascha,
> The thermal code uses int, long and unsigned long for temperatures
> in different places.
>
> Using an unsigned type limits the thermal framework to positive
> temperatures without need. Also several drivers currently will report
> temperatures near UINT_MAX for temperatures below 0°C. This will
> probably immediately shut the machine down due to overtemperature if
> started below 0°C.
>
> 'long' is 64bit on several architectures. This is not needed since
> INT_MAX °mC is above the melting point of all known materials.
>
> Consistently use a plain 'int' for temperatures throughout the
> thermal code and the drivers. This only changes the places in the
> drivers where the temperature is passed around as pointer, when
> drivers internally use another type this is not changed.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha, thanks for this cleanup work.
Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lukasz Majewski <l.majewski@samsung.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-pm@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
linux-kernel@vger.kernel.org, Jean Delvare <jdelvare@suse.de>,
Peter Feuerer <peter@piie.net>, Heiko Stuebner <heiko@sntech.de>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Darren Hart <dvhart@infradead.org>,
lm-sensors@lm-sensors.org
Subject: Re: [PATCH] thermal: consistently use int for temperatures
Date: Mon, 06 Jul 2015 12:26:40 +0200 [thread overview]
Message-ID: <20150706122640.2a61ca05@amdc2363> (raw)
In-Reply-To: <1436167189-29835-1-git-send-email-s.hauer@pengutronix.de>
Hi Sascha,
> The thermal code uses int, long and unsigned long for temperatures
> in different places.
>
> Using an unsigned type limits the thermal framework to positive
> temperatures without need. Also several drivers currently will report
> temperatures near UINT_MAX for temperatures below 0°C. This will
> probably immediately shut the machine down due to overtemperature if
> started below 0°C.
>
> 'long' is 64bit on several architectures. This is not needed since
> INT_MAX °mC is above the melting point of all known materials.
>
> Consistently use a plain 'int' for temperatures throughout the
> thermal code and the drivers. This only changes the places in the
> drivers where the temperature is passed around as pointer, when
> drivers internally use another type this is not changed.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha, thanks for this cleanup work.
Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
WARNING: multiple messages have this Message-ID (diff)
From: l.majewski@samsung.com (Lukasz Majewski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] thermal: consistently use int for temperatures
Date: Mon, 06 Jul 2015 12:26:40 +0200 [thread overview]
Message-ID: <20150706122640.2a61ca05@amdc2363> (raw)
In-Reply-To: <1436167189-29835-1-git-send-email-s.hauer@pengutronix.de>
Hi Sascha,
> The thermal code uses int, long and unsigned long for temperatures
> in different places.
>
> Using an unsigned type limits the thermal framework to positive
> temperatures without need. Also several drivers currently will report
> temperatures near UINT_MAX for temperatures below 0?C. This will
> probably immediately shut the machine down due to overtemperature if
> started below 0?C.
>
> 'long' is 64bit on several architectures. This is not needed since
> INT_MAX ?mC is above the melting point of all known materials.
>
> Consistently use a plain 'int' for temperatures throughout the
> thermal code and the drivers. This only changes the places in the
> drivers where the temperature is passed around as pointer, when
> drivers internally use another type this is not changed.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha, thanks for this cleanup work.
Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
WARNING: multiple messages have this Message-ID (diff)
From: Lukasz Majewski <l.majewski@samsung.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-pm@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
linux-kernel@vger.kernel.org, Jean Delvare <jdelvare@suse.de>,
Peter Feuerer <peter@piie.net>, Heiko Stuebner <heiko@sntech.de>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Darren Hart <dvhart@infradead.org>,
lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH] thermal: consistently use int for temperatures
Date: Mon, 06 Jul 2015 10:26:40 +0000 [thread overview]
Message-ID: <20150706122640.2a61ca05@amdc2363> (raw)
In-Reply-To: <1436167189-29835-1-git-send-email-s.hauer@pengutronix.de>
SGkgU2FzY2hhLAoKPiBUaGUgdGhlcm1hbCBjb2RlIHVzZXMgaW50LCBsb25nIGFuZCB1bnNpZ25l
ZCBsb25nIGZvciB0ZW1wZXJhdHVyZXMKPiBpbiBkaWZmZXJlbnQgcGxhY2VzLgo+IAo+IFVzaW5n
IGFuIHVuc2lnbmVkIHR5cGUgbGltaXRzIHRoZSB0aGVybWFsIGZyYW1ld29yayB0byBwb3NpdGl2
ZQo+IHRlbXBlcmF0dXJlcyB3aXRob3V0IG5lZWQuIEFsc28gc2V2ZXJhbCBkcml2ZXJzIGN1cnJl
bnRseSB3aWxsIHJlcG9ydAo+IHRlbXBlcmF0dXJlcyBuZWFyIFVJTlRfTUFYIGZvciB0ZW1wZXJh
dHVyZXMgYmVsb3cgMMKwQy4gVGhpcyB3aWxsCj4gcHJvYmFibHkgaW1tZWRpYXRlbHkgc2h1dCB0
aGUgbWFjaGluZSBkb3duIGR1ZSB0byBvdmVydGVtcGVyYXR1cmUgaWYKPiBzdGFydGVkIGJlbG93
IDDCsEMuCj4gCj4gJ2xvbmcnIGlzIDY0Yml0IG9uIHNldmVyYWwgYXJjaGl0ZWN0dXJlcy4gVGhp
cyBpcyBub3QgbmVlZGVkIHNpbmNlCj4gSU5UX01BWCDCsG1DIGlzIGFib3ZlIHRoZSBtZWx0aW5n
IHBvaW50IG9mIGFsbCBrbm93biBtYXRlcmlhbHMuCj4gCj4gQ29uc2lzdGVudGx5IHVzZSBhIHBs
YWluICdpbnQnIGZvciB0ZW1wZXJhdHVyZXMgdGhyb3VnaG91dCB0aGUKPiB0aGVybWFsIGNvZGUg
YW5kIHRoZSBkcml2ZXJzLiBUaGlzIG9ubHkgY2hhbmdlcyB0aGUgcGxhY2VzIGluIHRoZQo+IGRy
aXZlcnMgd2hlcmUgdGhlIHRlbXBlcmF0dXJlIGlzIHBhc3NlZCBhcm91bmQgYXMgcG9pbnRlciwg
d2hlbgo+IGRyaXZlcnMgaW50ZXJuYWxseSB1c2UgYW5vdGhlciB0eXBlIHRoaXMgaXMgbm90IGNo
YW5nZWQuCj4gCj4gU2lnbmVkLW9mZi1ieTogU2FzY2hhIEhhdWVyIDxzLmhhdWVyQHBlbmd1dHJv
bml4LmRlPgoKU2FzY2hhLCB0aGFua3MgZm9yIHRoaXMgY2xlYW51cCB3b3JrLiAKClJldmlld2Vk
LWJ5OiBMdWthc3ogTWFqZXdza2kgPGwubWFqZXdza2lAc2Ftc3VuZy5jb20+CgotLSAKQmVzdCBy
ZWdhcmRzLAoKTHVrYXN6IE1hamV3c2tpCgpTYW1zdW5nIFImRCBJbnN0aXR1dGUgUG9sYW5kIChT
UlBPTCkgfCBMaW51eCBQbGF0Zm9ybSBHcm91cAoKX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX18KbG0tc2Vuc29ycyBtYWlsaW5nIGxpc3QKbG0tc2Vuc29yc0Bs
bS1zZW5zb3JzLm9yZwpodHRwOi8vbGlzdHMubG0tc2Vuc29ycy5vcmcvbWFpbG1hbi9saXN0aW5m
by9sbS1zZW5zb3Jz
next prev parent reply other threads:[~2015-07-06 10:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 7:19 [PATCH] thermal: consistently use int for temperatures Sascha Hauer
2015-07-06 7:19 ` [lm-sensors] " Sascha Hauer
2015-07-06 7:19 ` Sascha Hauer
2015-07-06 8:34 ` Geert Uytterhoeven
2015-07-06 8:34 ` [lm-sensors] " Geert Uytterhoeven
2015-07-06 8:34 ` Geert Uytterhoeven
2015-07-06 8:34 ` Geert Uytterhoeven
2015-07-06 8:34 ` Geert Uytterhoeven
2015-07-06 10:25 ` Jean Delvare
2015-07-06 10:25 ` [lm-sensors] " Jean Delvare
2015-07-06 10:25 ` Jean Delvare
2015-07-06 10:26 ` Lukasz Majewski [this message]
2015-07-06 10:26 ` [lm-sensors] " Lukasz Majewski
2015-07-06 10:26 ` Lukasz Majewski
2015-07-06 10:26 ` Lukasz Majewski
2015-07-06 18:18 ` Darren Hart
2015-07-06 18:18 ` [lm-sensors] " Darren Hart
2015-07-06 18:18 ` Darren Hart
2015-07-06 19:07 ` Heiko Stübner
2015-07-06 19:07 ` [lm-sensors] " Heiko Stübner
2015-07-06 19:07 ` Heiko Stübner
2015-07-06 19:07 ` Heiko Stübner
2015-07-08 8:11 ` Peter Feuerer
2015-07-08 8:11 ` [lm-sensors] " Peter Feuerer
2015-07-08 8:11 ` Peter Feuerer
2015-07-08 8:11 ` Peter Feuerer
2015-07-17 11:14 ` Punit Agrawal
2015-07-17 11:14 ` [lm-sensors] " Punit Agrawal
2015-07-17 11:14 ` Punit Agrawal
2015-07-17 11:14 ` Punit Agrawal
2015-07-21 7:31 ` Sascha Hauer
2015-07-21 7:31 ` [lm-sensors] " Sascha Hauer
2015-07-21 7:31 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706122640.2a61ca05@amdc2363 \
--to=l.majewski@samsung.com \
--cc=dvhart@infradead.org \
--cc=edubezval@gmail.com \
--cc=heiko@sntech.de \
--cc=jdelvare@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=maxime.ripard@free-electrons.com \
--cc=peter@piie.net \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.