From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
Cc: Anirudha Sarangi <anirudh@xilinx.com>,
John Linn <John.Linn@xilinx.com>,
Michal Simek <michal.simek@xilinx.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [RFT PATCH] net: axienet: Fix devm_ioremap_resource return value check
Date: Thu, 9 Jul 2015 14:03:58 -0700 [thread overview]
Message-ID: <20150709210358.GG3129@xsjsorenbubuntu> (raw)
In-Reply-To: <1436448080-24775-1-git-send-email-k.kozlowski.k@gmail.com>
On Thu, 2015-07-09 at 10:21PM +0900, Krzysztof Kozlowski wrote:
> Value returned by devm_ioremap_resource() was checked for non-NULL but
> devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of
> error this could lead to dereference of ERR_PTR.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
> Cc: <stable@vger.kernel.org>
> Fixes: 46aa27df8853 ("net: axienet: Use devm_* calls")
Reviewed-by: Sören Brinkmann <soren.brinkmann@xilinx.com>
Sören
WARNING: multiple messages have this Message-ID (diff)
From: soren.brinkmann@xilinx.com (Sören Brinkmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFT PATCH] net: axienet: Fix devm_ioremap_resource return value check
Date: Thu, 9 Jul 2015 14:03:58 -0700 [thread overview]
Message-ID: <20150709210358.GG3129@xsjsorenbubuntu> (raw)
In-Reply-To: <1436448080-24775-1-git-send-email-k.kozlowski.k@gmail.com>
On Thu, 2015-07-09 at 10:21PM +0900, Krzysztof Kozlowski wrote:
> Value returned by devm_ioremap_resource() was checked for non-NULL but
> devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of
> error this could lead to dereference of ERR_PTR.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
> Cc: <stable@vger.kernel.org>
> Fixes: 46aa27df8853 ("net: axienet: Use devm_* calls")
Reviewed-by: S?ren Brinkmann <soren.brinkmann@xilinx.com>
S?ren
next prev parent reply other threads:[~2015-07-09 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 13:21 [RFT PATCH] net: axienet: Fix devm_ioremap_resource return value check Krzysztof Kozlowski
2015-07-09 13:21 ` Krzysztof Kozlowski
2015-07-09 21:03 ` Sören Brinkmann [this message]
2015-07-09 21:03 ` Sören Brinkmann
2015-07-10 4:44 ` David Miller
2015-07-10 4:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709210358.GG3129@xsjsorenbubuntu \
--to=soren.brinkmann@xilinx.com \
--cc=John.Linn@xilinx.com \
--cc=anirudh@xilinx.com \
--cc=k.kozlowski.k@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.