From: Dmitry Torokhov <dmitry.torokhov@gmail.com> To: Zhi Li <lznuaa@gmail.com> Cc: Frank Li <Frank.Li@freescale.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Shawn Guo <shawnguo@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, linux-input@vger.kernel.org Subject: Re: [PATCH] input: snvs_pwrkey: add linux prefix for wakeup property Date: Thu, 16 Jul 2015 11:34:08 -0700 [thread overview] Message-ID: <20150716183408.GD32571@dtor-ws> (raw) In-Reply-To: <CAHrpEqS2o6_B6dNrnWJ06ASWaB0SGxur1o3VuN2A-QywWhbWVA@mail.gmail.com> On Wed, Jul 15, 2015 at 09:00:12AM -0500, Zhi Li wrote: > On Tue, Jul 14, 2015 at 10:20 PM, Shawn Guo <shawnguo@kernel.org> wrote: > > The wakeup capability is somehow linux specific, and all existing > > bindings name the property "linux,wakeup" to reflect that, e.g. > > Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt. Let's > > follow the convention. I do not believe it is Linux specific, it describes desired behavior of hardware regardless of OS. I mean you want your device to wake up if you press power button whether it runes Linux, Windows, FreeBSD or whatever. > > > > Signed-off-by: Shawn Guo <shawnguo@kernel.org> > > --- > > This is a fixup for Frank's patch which is queued on i.MX tree, so I > > will apply it to the same branch. > > > > Shawn > > > > Documentation/devicetree/bindings/crypto/fsl-sec4.txt | 2 +- > > drivers/input/keyboard/snvs_pwrkey.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt > > index 71a39c5bd486..fa821c6a0b5b 100644 > > --- a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt > > +++ b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt > > @@ -408,7 +408,7 @@ System ON/OFF key driver > > Value type: <int> > > Definition: Keycode to emit, KEY_POWER by default. > > > > - - wakeup: > > + - linux,wakeup: > > I remember Dmitry Torokhov said use wakeup, instead of linux, wakeup > when I sent patch to review. I should have said to use "wakeup-source", not simply "wakeup" so that we'd match with I2C annotation. I think I'll go over input driver and convert them (keeping old names for compatibility reasons). Thanks. -- Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: dmitry.torokhov@gmail.com (Dmitry Torokhov) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] input: snvs_pwrkey: add linux prefix for wakeup property Date: Thu, 16 Jul 2015 11:34:08 -0700 [thread overview] Message-ID: <20150716183408.GD32571@dtor-ws> (raw) In-Reply-To: <CAHrpEqS2o6_B6dNrnWJ06ASWaB0SGxur1o3VuN2A-QywWhbWVA@mail.gmail.com> On Wed, Jul 15, 2015 at 09:00:12AM -0500, Zhi Li wrote: > On Tue, Jul 14, 2015 at 10:20 PM, Shawn Guo <shawnguo@kernel.org> wrote: > > The wakeup capability is somehow linux specific, and all existing > > bindings name the property "linux,wakeup" to reflect that, e.g. > > Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt. Let's > > follow the convention. I do not believe it is Linux specific, it describes desired behavior of hardware regardless of OS. I mean you want your device to wake up if you press power button whether it runes Linux, Windows, FreeBSD or whatever. > > > > Signed-off-by: Shawn Guo <shawnguo@kernel.org> > > --- > > This is a fixup for Frank's patch which is queued on i.MX tree, so I > > will apply it to the same branch. > > > > Shawn > > > > Documentation/devicetree/bindings/crypto/fsl-sec4.txt | 2 +- > > drivers/input/keyboard/snvs_pwrkey.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt > > index 71a39c5bd486..fa821c6a0b5b 100644 > > --- a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt > > +++ b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt > > @@ -408,7 +408,7 @@ System ON/OFF key driver > > Value type: <int> > > Definition: Keycode to emit, KEY_POWER by default. > > > > - - wakeup: > > + - linux,wakeup: > > I remember Dmitry Torokhov said use wakeup, instead of linux, wakeup > when I sent patch to review. I should have said to use "wakeup-source", not simply "wakeup" so that we'd match with I2C annotation. I think I'll go over input driver and convert them (keeping old names for compatibility reasons). Thanks. -- Dmitry
next prev parent reply other threads:[~2015-07-16 18:34 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-15 3:20 [PATCH] input: snvs_pwrkey: add linux prefix for wakeup property Shawn Guo 2015-07-15 3:20 ` Shawn Guo 2015-07-15 14:00 ` Zhi Li 2015-07-15 14:00 ` Zhi Li 2015-07-16 18:34 ` Dmitry Torokhov [this message] 2015-07-16 18:34 ` Dmitry Torokhov 2015-07-17 3:46 ` Shawn Guo 2015-07-17 3:46 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150716183408.GD32571@dtor-ws \ --to=dmitry.torokhov@gmail.com \ --cc=Frank.Li@freescale.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-input@vger.kernel.org \ --cc=lznuaa@gmail.com \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.