From: Stephen Boyd <sboyd@codeaurora.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: mturquette@baylibre.com, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
georgi.djakov@linaro.org, svarbanov@mm-sol.com,
srinivas.kandagatla@linaro.org, sviau@codeaurora.org
Subject: Re: [PATCH v6 04/13] clk: qcom: gdsc: Manage clocks with !CONFIG_PM
Date: Wed, 29 Jul 2015 17:13:57 -0700 [thread overview]
Message-ID: <20150730001357.GF3159@codeaurora.org> (raw)
In-Reply-To: <55B85870.7060900@codeaurora.org>
On 07/29, Rajendra Nayak wrote:
>
> On 07/29/2015 06:34 AM, Stephen Boyd wrote:
> >
> >Sorry, I read the thread and I tried to understand what was going on but
> >I'm still lost. Can you clarify further in the commit text somehow?
>
> So I can add this in the commit text, if it seems fine
>
> "The use of pm_clk_add_notifier() isn't appropriate here since we need
> to only manage clocks with valid power domain associations done via
> DT, instead of what pm_clk_add_notifier() does, which is manage clocks
> for all on SoC/off SoC devices associating all of them to a dummy
> power domain instead"
>
Yes that's good, thanks. But I still wonder why the code isn't
generic so that we don't have lots of drivers duplicating the
same logic. I guess we can consolidate another day.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 04/13] clk: qcom: gdsc: Manage clocks with !CONFIG_PM
Date: Wed, 29 Jul 2015 17:13:57 -0700 [thread overview]
Message-ID: <20150730001357.GF3159@codeaurora.org> (raw)
In-Reply-To: <55B85870.7060900@codeaurora.org>
On 07/29, Rajendra Nayak wrote:
>
> On 07/29/2015 06:34 AM, Stephen Boyd wrote:
> >
> >Sorry, I read the thread and I tried to understand what was going on but
> >I'm still lost. Can you clarify further in the commit text somehow?
>
> So I can add this in the commit text, if it seems fine
>
> "The use of pm_clk_add_notifier() isn't appropriate here since we need
> to only manage clocks with valid power domain associations done via
> DT, instead of what pm_clk_add_notifier() does, which is manage clocks
> for all on SoC/off SoC devices associating all of them to a dummy
> power domain instead"
>
Yes that's good, thanks. But I still wonder why the code isn't
generic so that we don't have lots of drivers duplicating the
same logic. I guess we can consolidate another day.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-07-30 0:13 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 7:10 [PATCH v6 00/13] qcom: Add support for GDSCs Rajendra Nayak
2015-07-22 7:10 ` Rajendra Nayak
2015-07-22 7:10 ` [PATCH v6 01/13] clk: " Rajendra Nayak
2015-07-22 7:10 ` Rajendra Nayak
2015-07-23 0:25 ` Stephen Boyd
2015-07-23 0:25 ` Stephen Boyd
2015-07-23 8:37 ` Rajendra Nayak
2015-07-23 8:37 ` Rajendra Nayak
2015-07-23 9:09 ` Stanimir Varbanov
2015-07-23 9:09 ` Stanimir Varbanov
2015-07-23 18:04 ` Stephen Boyd
2015-07-23 18:04 ` Stephen Boyd
2015-07-22 7:10 ` [PATCH v6 02/13] clk: qcom: gdsc: Prepare common clk probe to register gdscs Rajendra Nayak
2015-07-22 7:10 ` Rajendra Nayak
2015-07-23 0:27 ` Stephen Boyd
2015-07-23 0:27 ` Stephen Boyd
2015-07-22 7:10 ` [PATCH v6 03/13] clk: qcom: gdsc: Use PM clocks to control gdsc clocks Rajendra Nayak
2015-07-22 7:10 ` Rajendra Nayak
2015-07-23 1:01 ` Stephen Boyd
2015-07-23 1:01 ` Stephen Boyd
2015-07-23 8:34 ` Rajendra Nayak
2015-07-23 8:34 ` Rajendra Nayak
2015-07-23 9:22 ` Stanimir Varbanov
2015-07-23 9:22 ` Stanimir Varbanov
2015-07-23 10:28 ` Rajendra Nayak
2015-07-23 10:28 ` Rajendra Nayak
2015-07-22 7:11 ` [PATCH v6 04/13] clk: qcom: gdsc: Manage clocks with !CONFIG_PM Rajendra Nayak
2015-07-22 7:11 ` Rajendra Nayak
2015-07-23 1:03 ` Stephen Boyd
2015-07-23 1:03 ` Stephen Boyd
2015-07-23 8:35 ` Rajendra Nayak
2015-07-23 8:35 ` Rajendra Nayak
2015-07-29 1:04 ` Stephen Boyd
2015-07-29 1:04 ` Stephen Boyd
2015-07-29 4:37 ` Rajendra Nayak
2015-07-29 4:37 ` Rajendra Nayak
2015-07-30 0:13 ` Stephen Boyd [this message]
2015-07-30 0:13 ` Stephen Boyd
2015-07-30 1:39 ` Rajendra Nayak
2015-07-30 1:39 ` Rajendra Nayak
2015-07-22 7:11 ` [PATCH v6 05/13] clk: qcom: gdsc: Enable an RCG before turing on the gdsc Rajendra Nayak
2015-07-22 7:11 ` Rajendra Nayak
2015-07-22 7:11 ` [PATCH v6 06/13] clk: qcom: gdsc: Add support for Memory RET/OFF Rajendra Nayak
2015-07-22 7:11 ` Rajendra Nayak
2015-07-22 7:11 ` [PATCH v6 07/13] clk: qcom: gdsc: Add support for ON only state Rajendra Nayak
2015-07-22 7:11 ` Rajendra Nayak
2015-07-23 1:11 ` Stephen Boyd
2015-07-23 1:11 ` Stephen Boyd
2015-07-22 7:11 ` [PATCH v6 08/13] clk: qcom: gdsc: Add GDSCs in msm8916 GCC Rajendra Nayak
2015-07-22 7:11 ` Rajendra Nayak
2015-07-23 1:07 ` Stephen Boyd
2015-07-23 1:07 ` Stephen Boyd
2015-07-23 8:36 ` Rajendra Nayak
2015-07-23 8:36 ` Rajendra Nayak
2015-07-22 7:11 ` [PATCH v6 09/13] clk: qcom: gdsc: Add GDSCs in msm8974 GCC Rajendra Nayak
2015-07-22 7:11 ` Rajendra Nayak
2015-07-23 1:08 ` Stephen Boyd
2015-07-23 1:08 ` Stephen Boyd
2015-07-22 7:11 ` [PATCH v6 10/13] clk: qcom: gdsc: Add GDSCs in msm8974 MMCC Rajendra Nayak
2015-07-22 7:11 ` Rajendra Nayak
2015-07-23 1:09 ` Stephen Boyd
2015-07-23 1:09 ` Stephen Boyd
2015-07-22 7:11 ` [PATCH v6 11/13] clk: qcom: gdsc: Add GDSCs in apq8084 GCC Rajendra Nayak
2015-07-22 7:11 ` Rajendra Nayak
2015-07-22 7:11 ` [PATCH v6 12/13] clk: qcom: gdsc: Add GDSCs in apq8084 MMCC Rajendra Nayak
2015-07-22 7:11 ` Rajendra Nayak
2015-07-22 7:11 ` [PATCH v6 13/13] arm: dts: qcom: Add #power-domain-cells property Rajendra Nayak
2015-07-22 7:11 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730001357.GF3159@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rnayak@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=svarbanov@mm-sol.com \
--cc=sviau@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.