Re: [PATCH 10/10] ARM: dts: omap4: Use "syscon-otghs" instead of "ctrl-module" in USB node

From: Tony Lindgren <tony@atomide.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Roger Quadros <rogerq@ti.com>,
	t-kristo@ti.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	balbi@ti.com, bcousson@baylibre.com, linux@arm.linux.org.uk,
	nsekhar@ti.com
Subject: Re: [PATCH 10/10] ARM: dts: omap4: Use "syscon-otghs" instead of "ctrl-module" in USB node
Date: Thu, 6 Aug 2015 01:48:13 -0700	[thread overview]
Message-ID: <20150806084812.GC4215@atomide.com> (raw)
In-Reply-To: <55C21CCD.6050101@ti.com>

* Kishon Vijay Abraham I <kishon@ti.com> [150805 07:28]:
> Hi Roger,
> 
> On Wednesday 05 August 2015 01:38 PM, Roger Quadros wrote:
> > On 05/08/15 11:02, Roger Quadros wrote:
> >> Kishon,
> >>
> >> On 04/08/15 18:30, Kishon Vijay Abraham I wrote:
> >>> Add "syscon-otghs" property and remove the deprecated "ctrl-module"
> >>> property from MUSB devicetree node.
> >>>
> >>> Since "omap_control_usbotg" devicetree node is no longer used, remove
> >>> it.
> >>>
> >>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> >>> ---
> >>>  arch/arm/boot/dts/omap4.dtsi |    8 +-------
> >>>  1 file changed, 1 insertion(+), 7 deletions(-)
> >>>
> >>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> >>> index b27634d..2fb49a5 100644
> >>> --- a/arch/arm/boot/dts/omap4.dtsi
> >>> +++ b/arch/arm/boot/dts/omap4.dtsi
> >>> @@ -854,12 +854,6 @@
> >>>  			};
> >>>  		};
> >>>  
> >>> -		omap_control_usbotg: control-phy@4a00233c {
> >>> -			compatible = "ti,control-phy-otghs";
> >>> -			reg = <0x4a00233c 0x4>;
> >>> -			reg-names = "otghs_control";
> >>> -		};
> >>> -
> >>>  		usb_otg_hs: usb_otg_hs@4a0ab000 {
> >>>  			compatible = "ti,omap4-musb";
> >>>  			reg = <0x4a0ab000 0x7ff>;
> >>> @@ -872,7 +866,7 @@
> >>>  			multipoint = <1>;
> >>>  			num-eps = <16>;
> >>>  			ram-bits = <12>;
> >>> -			ctrl-module = <&omap_control_usbotg>;
> >>> +			syscon-otghs = <&scm_conf 0x33c>;
> >>
> >> All other properties were of the format "syscon-phy-foo".
> >> Why use a different format here?
> >>
> > 
> > Ah, looks like we don't have a dedicated phy driver for this?
> > We will need to add a PHY driver I guess then and handle this register
> > in that driver rather than in the musb driver.
> 
> I was explaining in the other thread to Tony on why this shouldn't be done in a
> PHY driver [1].

And I just suggested thhere that it should be in the drivers/phy/phy-omap-usb2.c
PHY driver instead of the MUSB driver.

Regards,

Tony 

> [1] -> https://lkml.org/lkml/2015/8/5/455