From: Josip Rodin <joy@entuzijast.net>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH 14/31] sparc32/io-unit: handle page-less SG entries
Date: Fri, 14 Aug 2015 12:03:03 +0000 [thread overview]
Message-ID: <20150814120303.GA21682@entuzijast.net> (raw)
In-Reply-To: <1439363150-8661-15-git-send-email-hch@lst.de>
On Wed, Aug 12, 2015 at 09:05:33AM +0200, Christoph Hellwig wrote:
> For the iommu offset we just need and offset into the page. Calculate
> that using the physical address instead of using the virtual address
> so that we don't require a virtual mapping.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/sparc/mm/io-unit.c | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/arch/sparc/mm/io-unit.c b/arch/sparc/mm/io-unit.c
> index f311bf2..82f97ae 100644
> --- a/arch/sparc/mm/io-unit.c
> +++ b/arch/sparc/mm/io-unit.c
> -static unsigned long iounit_get_area(struct iounit_struct *iounit, unsigned long vaddr, int size)
> +static dma_addr_t iounit_get_area(struct iounit_struct *iounit,
> + unsigned long paddr, int size)
> {
> - unsigned long rotor, scan, limit;
> + unsigned long rotor, scan, limit, dma_addr;
> + dma_addr = IOUNIT_DMA_BASE + (scan << PAGE_SHIFT) + (paddr & ~PAGE_MASK);
> + return dma_addr;
> }
> @@ -145,7 +146,7 @@ static __u32 iounit_get_scsi_one(struct device *dev, char *vaddr, unsigned long
> unsigned long ret, flags;
> - ret = iounit_get_area(iounit, (unsigned long)vaddr, len);
> + ret = iounit_get_area(iounit, virt_to_phys(vaddr), len);
> return ret;
> }
Would it make sense to normalize all these other instances of unsigned long
into dma_addr_t, and not just one?
--
2. That which causes joy or happiness.
next prev parent reply other threads:[~2015-08-14 12:03 UTC|newest]
Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 7:05 RFC: prepare for struct scatterlist entries without page backing Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 01/31] scatterlist: add sg_pfn and sg_has_page helpers Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 02/31] scatterlist: use sg_phys() Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 03/31] dma-debug: handle page-less SG entries Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 04/31] x86/pci-nommu: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 05/31] x86/pci-calgary: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 06/31] alpha/pci-noop: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 07/31] alpha/pci_iommu: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 08/31] c6x: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 09/31] ia64/pci_dma: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 10/31] powerpc/iommu: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 11/31] sparc/iommu: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 12/31] mn10300: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 13/31] sparc/ldc: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 14/31] sparc32/io-unit: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-14 12:03 ` Josip Rodin [this message]
[not found] ` <1439363150-8661-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-08-12 7:05 ` [PATCH 15/31] sparc32/iommu: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 20/31] avr32: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 9:36 ` Hans-Christian Egtvedt
2015-08-12 9:36 ` Hans-Christian Egtvedt
2015-08-12 12:42 ` RFC: prepare for struct scatterlist entries without page backing Boaz Harrosh
2015-08-12 12:42 ` Boaz Harrosh
2015-08-12 12:42 ` Boaz Harrosh
2015-08-12 23:37 ` Julian Calaby
2015-08-12 23:37 ` Julian Calaby
2015-08-13 14:35 ` Christoph Hellwig
2015-08-13 14:35 ` Christoph Hellwig
2015-08-13 14:35 ` Christoph Hellwig
2015-08-13 23:40 ` Julian Calaby
2015-08-13 23:40 ` Julian Calaby
2015-08-13 23:40 ` Julian Calaby
2015-08-13 14:40 ` Christoph Hellwig
2015-08-13 14:40 ` Christoph Hellwig
2015-08-13 15:42 ` Boaz Harrosh
2015-08-13 15:42 ` Boaz Harrosh
2015-08-12 7:05 ` [PATCH 16/31] s390: handle page-less SG entries Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 11:51 ` Sebastian Ott
2015-08-12 11:51 ` Sebastian Ott
2015-08-12 7:05 ` [PATCH 17/31] ia64/sba_iommu: remove sba_sg_address Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 18/31] nios2: handle page-less SG entries Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 19/31] arc: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 10:28 ` Vineet Gupta
2015-08-12 10:28 ` Vineet Gupta
2015-08-12 10:28 ` Vineet Gupta
2015-08-12 10:28 ` Vineet Gupta
2015-08-12 7:05 ` [PATCH 21/31] blackfin: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 22/31] metag: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 23/31] sh: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 24/31] xtensa: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 25/31] frv: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 26/31] openrisc: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 27/31] mips: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 28/31] powerpc: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 7:05 ` [PATCH 29/31] parisc: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 16:01 ` Linus Torvalds
2015-08-12 16:01 ` Linus Torvalds
2015-08-12 16:01 ` Linus Torvalds
2015-08-12 16:01 ` Linus Torvalds
2015-08-13 14:31 ` Christoph Hellwig
2015-08-13 14:31 ` Christoph Hellwig
2015-08-13 14:31 ` Christoph Hellwig
2015-08-13 14:31 ` Christoph Hellwig
2015-08-14 3:30 ` Dan Williams
2015-08-14 3:30 ` Dan Williams
2015-08-14 3:30 ` Dan Williams
2015-08-14 3:30 ` Dan Williams
2015-08-14 3:59 ` James Bottomley
2015-08-14 3:59 ` James Bottomley
2015-08-14 3:59 ` James Bottomley
2015-08-14 3:59 ` James Bottomley
2015-08-14 4:11 ` David Miller
2015-08-14 4:11 ` David Miller
[not found] ` <20150813.211155.1774898831276303437.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2015-08-14 16:17 ` Dan Williams
2015-08-14 16:17 ` Dan Williams
2015-08-14 16:17 ` Dan Williams
2015-08-12 7:05 ` [PATCH 30/31] intel-iommu: " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 9:51 ` David Woodhouse
2015-08-12 9:51 ` David Woodhouse
2015-08-12 9:51 ` David Woodhouse
2015-08-12 7:05 ` [PATCH 31/31] dma-mapping-common: skip kmemleak checks for " Christoph Hellwig
2015-08-12 7:05 ` Christoph Hellwig
2015-08-12 16:05 ` Linus Torvalds
2015-08-12 16:05 ` Linus Torvalds
2015-08-12 16:05 ` Linus Torvalds
2015-08-12 16:05 ` Linus Torvalds
2015-08-13 14:33 ` Christoph Hellwig
2015-08-13 14:33 ` Christoph Hellwig
2015-08-13 14:33 ` Christoph Hellwig
2015-08-13 14:33 ` Christoph Hellwig
2015-08-12 16:26 ` Catalin Marinas
2015-08-12 16:26 ` Catalin Marinas
2015-08-12 16:26 ` Catalin Marinas
2015-08-12 16:26 ` Catalin Marinas
2015-08-12 16:26 ` Catalin Marinas
2015-08-12 16:26 ` Catalin Marinas
2015-08-12 17:00 ` RFC: prepare for struct scatterlist entries without page backing James Bottomley
2015-08-12 17:00 ` James Bottomley
2015-08-12 17:00 ` James Bottomley
2015-08-12 17:56 ` Grant Grundler
2015-08-12 17:56 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150814120303.GA21682@entuzijast.net \
--to=joy@entuzijast.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.