All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org,
	"Andrzej Hajda" <a.hajda@samsung.com>,
	linux-fbdev@vger.kernel.org,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org,
	"Lee Jones" <lee.jones@linaro.org>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
	linux-mtd@lists.infradead.org,
	"Lauro Ramos Venancio" <lauro.venancio@openbossa.org>,
	"Søren Andersen" <san@rosetechnology.dk>,
	devel@driverdev.osuosl.org,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Masanari Iida" <standby24x7@gmail.com>,
	"Jiri Kosina" <jkosina@suse.cz>,
	"Devendra Naga" <devendra.aaru@gmail.com>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Aloisio Almeida Jr" <aloisio.almeida@openbossa.org>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Stephen Warren" <swarren@nvidia.com>,
	"Urs Fässler" <urs.fassler@bytesatwork.ch>,
	"Adrian Hunter" <adrian.hunter@intel.com>,
	"Mauro Carvalho Chehab" <mchehab@osg.samsung.com>,
	"Aya Mahfouz" <mahfouz.saif.elyazal@gmail.com>,
	"George McCollister" <george.mccollister@gmail.com>,
	"Samuel Ortiz" <sameo@linux.intel.com>,
	"Manfred Schlaegl" <manfred.schlaegl@gmx.at>,
	linux-omap@vger.kernel.org, "Hartmut Knaack" <knaack.h@gmx.de>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Antonio Borneo" <borneo.antonio@gmail.com>,
	"Andrea Galbusera" <gizero@gmail.com>,
	"Michael Welling" <mwelling@ieee.org>,
	"Fabian Frederick" <fabf@skynet.be>,
	"Mark Brown" <broonie@kernel.org>,
	linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"David Woodhouse" <dwmw2@infradead.org>,
	netdev@vger.kernel.org, linux-media@vger.kernel.org,
	"Peter Meerwald" <pmeerw@pmeerw.net>
Subject: Re: [PATCH 00/18] Export SPI and OF module aliases in missing drivers
Date: Thu, 20 Aug 2015 14:11:52 -0700	[thread overview]
Message-ID: <20150820211152.GI74600@google.com> (raw)
In-Reply-To: <1440054451-1223-1-git-send-email-javier@osg.samsung.com>

On Thu, Aug 20, 2015 at 09:07:13AM +0200, Javier Martinez Canillas wrote:
> Patches #1 and #2 solves a), patches #3 to #8 solves b) and patches

^^^ I'm dying to know how this sentence ends :)

> Patch #18 changes the logic of spi_uevent() to report an OF modalias if
> the device was registered using OF. But this patch is included in the
> series only as an RFC for illustration purposes since changing that
> without first applying all the other patches in this series, will break
> module autoloading for the drivers of devices registered using OF but
> that lacks an of_match_table. I'll repost patch #18 once all the patches
> in this series have landed.

On a more productive note, the patches I've looked at look good to me.
The missing aliases are a problem enough that should be fixed (i.e.,
part (b)). I'll leave the SPI framework changes to others to comment on.

Brian

WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace@gmail.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org,
	"Andrzej Hajda" <a.hajda@samsung.com>,
	linux-fbdev@vger.kernel.org,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org,
	"Lee Jones" <lee.jones@linaro.org>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
	linux-mtd@lists.infradead.org,
	"Lauro Ramos Venancio" <lauro.venancio@openbossa.org>,
	"Søren Andersen" <san@rosetechnology.dk>,
	devel@driverdev.osuosl.org,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Masanari Iida" <standby24x7@gmail.com>,
	"Jiri Kosina" <jkosina@suse.cz>,
	"Devendra Naga" <devendra.aaru@gmail.com>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Aloisio Almeida Jr" <aloisio.almeida@openbossa.org>,
	"Jonathan Cameron" <jic23@kernel>
Subject: Re: [PATCH 00/18] Export SPI and OF module aliases in missing drivers
Date: Thu, 20 Aug 2015 14:11:52 -0700	[thread overview]
Message-ID: <20150820211152.GI74600@google.com> (raw)
In-Reply-To: <1440054451-1223-1-git-send-email-javier@osg.samsung.com>

On Thu, Aug 20, 2015 at 09:07:13AM +0200, Javier Martinez Canillas wrote:
> Patches #1 and #2 solves a), patches #3 to #8 solves b) and patches

^^^ I'm dying to know how this sentence ends :)

> Patch #18 changes the logic of spi_uevent() to report an OF modalias if
> the device was registered using OF. But this patch is included in the
> series only as an RFC for illustration purposes since changing that
> without first applying all the other patches in this series, will break
> module autoloading for the drivers of devices registered using OF but
> that lacks an of_match_table. I'll repost patch #18 once all the patches
> in this series have landed.

On a more productive note, the patches I've looked at look good to me.
The missing aliases are a problem enough that should be fixed (i.e.,
part (b)). I'll leave the SPI framework changes to others to comment on.

Brian

WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace@gmail.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org,
	"Andrzej Hajda" <a.hajda@samsung.com>,
	linux-fbdev@vger.kernel.org,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org,
	"Lee Jones" <lee.jones@linaro.org>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
	linux-mtd@lists.infradead.org,
	"Lauro Ramos Venancio" <lauro.venancio@openbossa.org>,
	"Søren Andersen" <san@rosetechnology.dk>,
	devel@driverdev.osuosl.org,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Masanari Iida" <standby24x7@gmail.com>,
	"Jiri Kosina" <jkosina@suse.cz>,
	"Devendra Naga" <devendra.aaru@gmail.com>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Aloisio Almeida Jr" <aloisio.almeida@openbossa.org>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Stephen Warren" <swarren@nvidia.com>,
	"Urs Fässler" <urs.fassler@bytesatwork.ch>,
	"Adrian Hunter" <adrian.hunter@intel.com>,
	"Mauro Carvalho Chehab" <mchehab@osg.samsung.com>,
	"Aya Mahfouz" <mahfouz.saif.elyazal@gmail.com>,
	"George McCollister" <george.mccollister@gmail.com>,
	"Samuel Ortiz" <sameo@linux.intel.com>,
	"Manfred Schlaegl" <manfred.schlaegl@gmx.at>,
	linux-omap@vger.kernel.org, "Hartmut Knaack" <knaack.h@gmx.de>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Antonio Borneo" <borneo.antonio@gmail.com>,
	"Andrea Galbusera" <gizero@gmail.com>,
	"Michael Welling" <mwelling@ieee.org>,
	"Fabian Frederick" <fabf@skynet.be>,
	"Mark Brown" <broonie@kernel.org>,
	linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"David Woodhouse" <dwmw2@infradead.org>,
	netdev@vger.kernel.org, linux-media@vger.kernel.org,
	"Peter Meerwald" <pmeerw@pmeerw.net>
Subject: Re: [PATCH 00/18] Export SPI and OF module aliases in missing drivers
Date: Thu, 20 Aug 2015 21:11:52 +0000	[thread overview]
Message-ID: <20150820211152.GI74600@google.com> (raw)
In-Reply-To: <1440054451-1223-1-git-send-email-javier@osg.samsung.com>

On Thu, Aug 20, 2015 at 09:07:13AM +0200, Javier Martinez Canillas wrote:
> Patches #1 and #2 solves a), patches #3 to #8 solves b) and patches

^^^ I'm dying to know how this sentence ends :)

> Patch #18 changes the logic of spi_uevent() to report an OF modalias if
> the device was registered using OF. But this patch is included in the
> series only as an RFC for illustration purposes since changing that
> without first applying all the other patches in this series, will break
> module autoloading for the drivers of devices registered using OF but
> that lacks an of_match_table. I'll repost patch #18 once all the patches
> in this series have landed.

On a more productive note, the patches I've looked at look good to me.
The missing aliases are a problem enough that should be fixed (i.e.,
part (b)). I'll leave the SPI framework changes to others to comment on.

Brian

  parent reply	other threads:[~2015-08-20 21:11 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-20  7:07 [PATCH 00/18] Export SPI and OF module aliases in missing drivers Javier Martinez Canillas
2015-08-20  7:07 ` Javier Martinez Canillas
2015-08-20  7:07 ` Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 01/18] iio: Export SPI module alias information " Javier Martinez Canillas
2015-08-20 15:49   ` Lars-Peter Clausen
2015-08-22 18:08     ` Jonathan Cameron
2015-08-20  7:07 ` [PATCH 02/18] staging: iio: hmc5843: Export missing SPI module alias information Javier Martinez Canillas
2015-08-22 17:59   ` Jonathan Cameron
2015-08-31 23:09     ` Javier Martinez Canillas
2015-09-05 16:31       ` Jonathan Cameron
2015-09-05 23:34         ` Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 03/18] mtd: dataflash: Export OF " Javier Martinez Canillas
2015-08-20 21:54   ` Brian Norris
2015-08-20 22:13     ` Javier Martinez Canillas
2015-08-20 22:34       ` Brian Norris
2015-08-20 22:57         ` Javier Martinez Canillas
2015-08-21 22:47           ` Brian Norris
2015-08-22  0:26             ` Javier Martinez Canillas
2015-08-22  1:05               ` Brian Norris
2015-08-22  1:10                 ` Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 04/18] OMAPDSS: panel-sony-acx565akm: " Javier Martinez Canillas
2015-08-20  7:07   ` Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 05/18] mmc: mmc_spi: " Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 06/18] staging: mt29f_spinand: " Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 07/18] net: ks8851: " Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 08/18] [media] s5c73m3: " Javier Martinez Canillas
2015-09-11  1:19   ` Javier Martinez Canillas
2015-09-11  9:37     ` Andrzej Hajda
2015-09-11 10:10     ` Andrzej Hajda
2015-09-11 10:33       ` Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 09/18] mfd: cros_ec: spi: Add OF match table Javier Martinez Canillas
2015-08-24 14:00   ` Lee Jones
2015-08-20  7:07 ` [PATCH 10/18] iio: dac: ad7303: " Javier Martinez Canillas
2015-08-20 15:49   ` Lars-Peter Clausen
2015-08-22 18:06     ` Jonathan Cameron
2015-08-20  7:07 ` [PATCH 11/18] iio: adc: max1027: Set struct spi_driver .of_match_table Javier Martinez Canillas
2015-08-22 18:00   ` Jonathan Cameron
2015-08-20  7:07 ` [PATCH 12/18] mfd: stmpe: Add OF match table Javier Martinez Canillas
2015-08-24 13:59   ` Lee Jones
2015-08-20  7:07 ` [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table Javier Martinez Canillas
2015-08-20 20:09   ` Michael Welling
2015-08-20 22:02     ` Javier Martinez Canillas
2015-08-20 22:29       ` Michael Welling
2015-08-20 22:48         ` Javier Martinez Canillas
2015-08-20 23:53           ` Michael Welling
2015-08-22 18:09             ` Jonathan Cameron
2015-08-22 17:48           ` Jonathan Cameron
2015-08-22 17:48             ` Jonathan Cameron
2015-08-23 22:10             ` Rob Herring
2015-08-23 22:10               ` Rob Herring
2015-08-24  7:19               ` Javier Martinez Canillas
2015-08-24  7:19                 ` Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 14/18] iio: as3935: Add OF match table Javier Martinez Canillas
2015-08-22 18:02   ` Jonathan Cameron
2015-08-20  7:07 ` [PATCH 15/18] iio: adc128s052: " Javier Martinez Canillas
2015-08-22 18:03   ` Jonathan Cameron
2015-08-20  7:07 ` [PATCH 16/18] iio: frequency: adf4350: " Javier Martinez Canillas
2015-08-20 15:49   ` Lars-Peter Clausen
2015-08-22 18:04     ` Jonathan Cameron
2015-08-20  7:07 ` [PATCH 17/18] NFC: trf7970a: " Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 18/18] spi: (RFC, don't apply) report OF style modalias when probing using DT Javier Martinez Canillas
2015-08-20 18:36   ` Mark Brown
2015-08-20 18:36     ` Mark Brown
2015-08-20 21:08     ` Brian Norris
2015-08-20 21:08       ` Brian Norris
2015-08-20 21:45       ` Javier Martinez Canillas
2015-08-20 21:45         ` Javier Martinez Canillas
2015-08-20 23:25         ` Mark Brown
2015-08-20 23:25           ` Mark Brown
2015-08-20 23:47           ` Javier Martinez Canillas
2015-08-21 17:29             ` Mark Brown
2015-08-21 17:29               ` Mark Brown
2015-08-24  8:00               ` Javier Martinez Canillas
2015-08-24  8:00                 ` Javier Martinez Canillas
2015-08-20 21:11 ` Brian Norris [this message]
2015-08-20 21:11   ` [PATCH 00/18] Export SPI and OF module aliases in missing drivers Brian Norris
2015-08-20 21:11   ` Brian Norris
2015-08-20 21:50   ` Javier Martinez Canillas
2015-08-20 21:50     ` Javier Martinez Canillas
2015-08-20 21:50     ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150820211152.GI74600@google.com \
    --to=computersforpeace@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=a.hajda@samsung.com \
    --cc=adrian.hunter@intel.com \
    --cc=aloisio.almeida@openbossa.org \
    --cc=borneo.antonio@gmail.com \
    --cc=broonie@kernel.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=devendra.aaru@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=fabf@skynet.be \
    --cc=george.mccollister@gmail.com \
    --cc=gizero@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=javier@osg.samsung.com \
    --cc=jic23@kernel.org \
    --cc=jkosina@suse.cz \
    --cc=k.kozlowski@samsung.com \
    --cc=knaack.h@gmx.de \
    --cc=kyungmin.park@samsung.com \
    --cc=lars@metafoo.de \
    --cc=lauro.venancio@openbossa.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mahfouz.saif.elyazal@gmail.com \
    --cc=manfred.schlaegl@gmx.at \
    --cc=mchehab@osg.samsung.com \
    --cc=mwelling@ieee.org \
    --cc=netdev@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=pmeerw@pmeerw.net \
    --cc=rdunlap@infradead.org \
    --cc=sameo@linux.intel.com \
    --cc=san@rosetechnology.dk \
    --cc=standby24x7@gmail.com \
    --cc=swarren@nvidia.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=ulf.hansson@linaro.org \
    --cc=urs.fassler@bytesatwork.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.