From: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> To: Javier Martinez Canillas <javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org> Cc: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Alexandru M Stan <amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, Douglas Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org> Subject: Re: [PATCH v2 1/3] ARM: dts: rockchip: add veyron-jaq board Date: Mon, 24 Aug 2015 10:53:15 -0700 [thread overview] Message-ID: <20150824175315.GA81574@google.com> (raw) In-Reply-To: <CABxcv=nQAfCzj_bQ9N-XYEPCNuihyrkUOz7=ogetKzye4KKNng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> On Thu, Aug 20, 2015 at 01:29:40AM +0200, Javier Martinez Canillas wrote: > Hello Brian, > > [...] > > > + > > +&rk808 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pmic_int_l &dvs_1 &dvs_2>; > > + dvs-gpios = <&gpio7 12 GPIO_ACTIVE_HIGH>, > > + <&gpio7 15 GPIO_ACTIVE_HIGH>; > > I see the dvs-gpios DT property is documented in the downstream > ChromiumOS 3.18 tree [0] but I don't see it neither mentioned in > Documentation/devicetree/bindings/mfd/rk808.txt in mainline nor code > that parses it in the drivers/regulator/rk808-regulator.c driver. Good catch. > So I think this should be removed and also the dvs_{1,2} pinctrl > lines. OK, will do. I see that jerry, minnie, and speedy also have the pinctrl lines. Should they be killed as well? > The rest of the patch looks good to me though so with these > removed feel free to add: > > Reviewed-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> Thanks. > [0]: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.14/Documentation/devicetree/bindings/mfd/rk808.txt Brian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: briannorris@chromium.org (Brian Norris) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/3] ARM: dts: rockchip: add veyron-jaq board Date: Mon, 24 Aug 2015 10:53:15 -0700 [thread overview] Message-ID: <20150824175315.GA81574@google.com> (raw) In-Reply-To: <CABxcv=nQAfCzj_bQ9N-XYEPCNuihyrkUOz7=ogetKzye4KKNng@mail.gmail.com> On Thu, Aug 20, 2015 at 01:29:40AM +0200, Javier Martinez Canillas wrote: > Hello Brian, > > [...] > > > + > > +&rk808 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pmic_int_l &dvs_1 &dvs_2>; > > + dvs-gpios = <&gpio7 12 GPIO_ACTIVE_HIGH>, > > + <&gpio7 15 GPIO_ACTIVE_HIGH>; > > I see the dvs-gpios DT property is documented in the downstream > ChromiumOS 3.18 tree [0] but I don't see it neither mentioned in > Documentation/devicetree/bindings/mfd/rk808.txt in mainline nor code > that parses it in the drivers/regulator/rk808-regulator.c driver. Good catch. > So I think this should be removed and also the dvs_{1,2} pinctrl > lines. OK, will do. I see that jerry, minnie, and speedy also have the pinctrl lines. Should they be killed as well? > The rest of the patch looks good to me though so with these > removed feel free to add: > > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Thanks. > [0]: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.14/Documentation/devicetree/bindings/mfd/rk808.txt Brian
next prev parent reply other threads:[~2015-08-24 17:53 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-08-19 22:18 [PATCH v2 1/3] ARM: dts: rockchip: add veyron-jaq board Brian Norris 2015-08-19 22:18 ` Brian Norris [not found] ` <CAHNYxRzWHvy=mv+G6wwO29=9smOCwKh6gBPLbT-TNq0PmP2Xiw@mail.gmail.com> [not found] ` <CAHNYxRzWHvy=mv+G6wwO29=9smOCwKh6gBPLbT-TNq0PmP2Xiw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-08-19 22:59 ` Brian Norris 2015-08-19 22:59 ` Brian Norris [not found] ` <1440022721-73712-1-git-send-email-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2015-08-19 22:18 ` [PATCH v2 2/3] ARM: dts: rockchip: correct regulator PM properties Brian Norris 2015-08-19 22:18 ` Brian Norris [not found] ` <1440022721-73712-2-git-send-email-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2015-08-19 23:35 ` Javier Martinez Canillas 2015-08-19 23:35 ` Javier Martinez Canillas 2015-08-24 17:04 ` Heiko Stuebner 2015-08-24 17:04 ` Heiko Stuebner 2015-08-19 22:18 ` [PATCH v2 3/3] ARM: dts: rockchip: correct regulator power states for suspend Brian Norris 2015-08-19 22:18 ` Brian Norris [not found] ` <1440022721-73712-3-git-send-email-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2015-08-19 23:36 ` Javier Martinez Canillas 2015-08-19 23:36 ` Javier Martinez Canillas 2015-08-24 17:04 ` Heiko Stuebner 2015-08-24 17:04 ` Heiko Stuebner 2015-08-19 23:29 ` [PATCH v2 1/3] ARM: dts: rockchip: add veyron-jaq board Javier Martinez Canillas 2015-08-19 23:29 ` Javier Martinez Canillas [not found] ` <CABxcv=nQAfCzj_bQ9N-XYEPCNuihyrkUOz7=ogetKzye4KKNng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-08-24 17:53 ` Brian Norris [this message] 2015-08-24 17:53 ` Brian Norris [not found] ` <20150824175315.GA81574-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> 2015-08-24 17:58 ` Heiko Stuebner 2015-08-24 17:58 ` Heiko Stuebner 2015-08-24 18:01 ` Javier Martinez Canillas 2015-08-24 18:01 ` Javier Martinez Canillas [not found] ` <CABxcv=nXwL6LV0vnjffA0JV4NB-_mCufe3-0c7fsRKW3DE+-_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-08-24 18:06 ` Brian Norris 2015-08-24 18:06 ` Brian Norris
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150824175315.GA81574@google.com \ --to=briannorris-f7+t8e8rja9g9huczpvpmw@public.gmane.org \ --cc=amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \ --cc=javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.