Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

From: Wolfram Sang <wsa@the-dreams.de>
To: Mark Brown <broonie@kernel.org>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	linux-i2c@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-acpi@vger.kernel.org, lm-sensors@lm-sensors.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Jean Delvare <jdelvare@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Dustin Byford <dustin@cumulusnetworks.com>,
	linux@roeck-us.net
Subject: Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves
Date: Tue, 25 Aug 2015 16:57:56 +0200	[thread overview]
Message-ID: <20150825145756.GA4066@schokonusskuchen.bad> (raw)
In-Reply-To: <20150825052513.GI1654@sirena.org.uk>

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]

On Tue, Aug 25, 2015 at 06:25:13AM +0100, Mark Brown wrote:
> On Mon, Aug 24, 2015 at 01:52:02PM +0300, Jarkko Nikula wrote:
> > Commit 70762abb9f89 ("i2c: Use stable dev_name for ACPI enumerated I2C
> > slaves") broke the lm-sensors which relies on I2C hwmon slave devices under
> > /sys/bus/i2c/devices/ to be named as "x-00yz". However if those hwmon
> > devices are ACPI 5 enumerated their name became "i2c-INTABCD:ij" and sysfs
> > code in lm-sensors does not find them anymore:
> 
> Acked-by: Mark Brown <broonie@kernel.org>

Don't you think there will be regressions given that the new naming
scheme was around for 18 months?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]