From: Felipe Balbi <balbi@ti.com> To: Nikhil Badola <nikhil.badola@freescale.com> Cc: <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>, <linux-omap@vger.kernel.org>, <balbi@ti.com>, <gregkh@linuxfoundation.org> Subject: Re: [PATCH 2/3][v2] drivers: usb: dwc3: Add frame length adjustment quirk Date: Tue, 1 Sep 2015 02:20:33 -0500 [thread overview] Message-ID: <20150901072033.GA2873@saruman.tx.rr.com> (raw) In-Reply-To: <1439785496-27243-1-git-send-email-nikhil.badola@freescale.com> [-- Attachment #1: Type: text/plain, Size: 459 bytes --] Hi, On Mon, Aug 17, 2015 at 09:54:56AM +0530, Nikhil Badola wrote: > +static void dwc3_frame_length_adjustment(struct dwc3 *dwc, u32 fladj) > +{ > + if (dwc->revision < DWC3_REVISION_250A) > + return; > + > + if (fladj == 0) > + return; > + > + if (fladj) { right here you know fladj to be non-zero. > @@ -957,6 +990,7 @@ static int dwc3_probe(struct platform_device *pdev) > goto err1; > } > > + stray change -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com> To: Nikhil Badola <nikhil.badola@freescale.com> Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, balbi@ti.com, gregkh@linuxfoundation.org Subject: Re: [PATCH 2/3][v2] drivers: usb: dwc3: Add frame length adjustment quirk Date: Tue, 1 Sep 2015 02:20:33 -0500 [thread overview] Message-ID: <20150901072033.GA2873@saruman.tx.rr.com> (raw) In-Reply-To: <1439785496-27243-1-git-send-email-nikhil.badola@freescale.com> [-- Attachment #1: Type: text/plain, Size: 459 bytes --] Hi, On Mon, Aug 17, 2015 at 09:54:56AM +0530, Nikhil Badola wrote: > +static void dwc3_frame_length_adjustment(struct dwc3 *dwc, u32 fladj) > +{ > + if (dwc->revision < DWC3_REVISION_250A) > + return; > + > + if (fladj == 0) > + return; > + > + if (fladj) { right here you know fladj to be non-zero. > @@ -957,6 +990,7 @@ static int dwc3_probe(struct platform_device *pdev) > goto err1; > } > > + stray change -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-09-01 7:20 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-08-17 4:24 [PATCH 2/3][v2] drivers: usb: dwc3: Add frame length adjustment quirk Nikhil Badola 2015-08-17 4:24 ` Nikhil Badola 2015-09-01 7:20 ` Felipe Balbi [this message] 2015-09-01 7:20 ` Felipe Balbi 2015-09-01 7:40 ` Badola Nikhil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150901072033.GA2873@saruman.tx.rr.com \ --to=balbi@ti.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=nikhil.badola@freescale.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.