Re: [PATCH 1/4] drm/i915: Add audio pin sense / ELD callback

From: Daniel Vetter <daniel@ffwll.ch>
To: David Henningsson <david.henningsson@canonical.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
	intel-gfx@lists.freedesktop.org, daniel.vetter@intel.com
Subject: Re: [PATCH 1/4] drm/i915: Add audio pin sense / ELD callback
Date: Wed, 2 Sep 2015 13:44:16 +0200	[thread overview]
Message-ID: <20150902114416.GU1367@phenom.ffwll.local> (raw)
In-Reply-To: <1440781350-12053-2-git-send-email-david.henningsson@canonical.com>

On Fri, Aug 28, 2015 at 07:02:27PM +0200, David Henningsson wrote:
> This callback will be called by the i915 driver to notify the hda
> driver that its HDMI information needs to be refreshed, i e,
> that audio output is now available (or unavailable) - usually as a
> result of a monitor being plugged in (or unplugged).
> 
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
> ---
>  include/drm/i915_component.h | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/include/drm/i915_component.h b/include/drm/i915_component.h
> index c9a8b64..c0f4d45 100644
> --- a/include/drm/i915_component.h
> +++ b/include/drm/i915_component.h
> @@ -34,6 +34,22 @@ struct i915_audio_component {
>  		void (*codec_wake_override)(struct device *, bool enable);
>  		int (*get_cdclk_freq)(struct device *);
>  	} *ops;
> +
> +	const struct i915_audio_component_audio_ops {
> +		/**
> +		 * @audio_ptr:
> +		 *
> +		 * Pointer to pass when calling pin_eld_notify.
> +		 */
> +		void *audio_ptr;
> +		/**
> +		 * @pin_eld_notify:
> +		 *
> +		 * Called from i915 driver, notifying the HDA driver that
> +		 * pin sense and/or ELD information has changed.
> +		 */
> +		void (*pin_eld_notify)(void *audio_ptr, int port);

Kerneldoc looks good now, but it won't be of much use with an include
directive into the drm.tmpl docbook. Can you please coordinate with Libin
on that?

Thanks, Daniel

> +	} *audio_ops;
>  };
>  
>  #endif /* _I915_COMPONENT_H_ */
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx