From: Peter Chen <peter.chen@freescale.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Roger Quadros <rogerq@ti.com>, <tony@atomide.com>,
<Joao.Pinto@synopsys.com>, <sergei.shtylyov@cogentembedded.com>,
<jun.li@freescale.com>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v4 5/9] usb: dwc3: core: make dual-role work with OTG irq
Date: Sun, 6 Sep 2015 10:20:40 +0800 [thread overview]
Message-ID: <20150906022040.GC4914@shlinux2> (raw)
In-Reply-To: <20150902144338.GG8299@saruman.tx.rr.com>
On Wed, Sep 02, 2015 at 09:43:38AM -0500, Felipe Balbi wrote:
> Hi,
>
> > +
> > +static irqreturn_t dwc3_otg_irq(int irq, void *_dwc)
> > +{
> > + struct dwc3 *dwc = _dwc;
> > + irqreturn_t ret = IRQ_NONE;
> > + u32 reg;
> > +
> > + spin_lock(&dwc->lock);
>
> this seems unnecessary, we're already in hardirq with IRQs disabled.
> What sort of race could we have ? (in fact, this also needs change in
> dwc3/gadget.c).
>
Is it possible the kernel process is accessing the content you will
access?
--
Best Regards,
Peter Chen
WARNING: multiple messages have this Message-ID (diff)
From: Peter Chen <peter.chen@freescale.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Roger Quadros <rogerq@ti.com>,
tony@atomide.com, Joao.Pinto@synopsys.com,
sergei.shtylyov@cogentembedded.com, jun.li@freescale.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v4 5/9] usb: dwc3: core: make dual-role work with OTG irq
Date: Sun, 6 Sep 2015 10:20:40 +0800 [thread overview]
Message-ID: <20150906022040.GC4914@shlinux2> (raw)
In-Reply-To: <20150902144338.GG8299@saruman.tx.rr.com>
On Wed, Sep 02, 2015 at 09:43:38AM -0500, Felipe Balbi wrote:
> Hi,
>
> > +
> > +static irqreturn_t dwc3_otg_irq(int irq, void *_dwc)
> > +{
> > + struct dwc3 *dwc = _dwc;
> > + irqreturn_t ret = IRQ_NONE;
> > + u32 reg;
> > +
> > + spin_lock(&dwc->lock);
>
> this seems unnecessary, we're already in hardirq with IRQs disabled.
> What sort of race could we have ? (in fact, this also needs change in
> dwc3/gadget.c).
>
Is it possible the kernel process is accessing the content you will
access?
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2015-09-06 3:32 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 14:24 [PATCH v4 0/9] usb: dwc3: add dual-role support Roger Quadros
2015-09-02 14:24 ` Roger Quadros
2015-09-02 14:24 ` [PATCH v4 1/9] " Roger Quadros
2015-09-02 14:24 ` Roger Quadros
2015-09-02 14:31 ` Felipe Balbi
2015-09-02 14:31 ` Felipe Balbi
2015-09-03 12:21 ` Roger Quadros
2015-09-03 12:21 ` Roger Quadros
2015-09-03 15:44 ` Felipe Balbi
2015-09-03 15:44 ` Felipe Balbi
2015-09-04 9:06 ` Roger Quadros
2015-09-04 9:06 ` Roger Quadros
2015-09-07 9:42 ` Roger Quadros
2015-09-07 9:42 ` Roger Quadros
2015-09-06 2:02 ` Peter Chen
2015-09-06 2:02 ` Peter Chen
2015-09-07 9:39 ` Roger Quadros
2015-09-07 9:39 ` Roger Quadros
2015-09-02 14:24 ` [PATCH v4 2/9] usb: dwc3: core.h: add some register definitions Roger Quadros
2015-09-02 14:24 ` Roger Quadros
2015-09-02 14:24 ` [PATCH v4 3/9] usb: dwc3: dwc3-omap: Make the wrapper interrupt shared Roger Quadros
2015-09-02 14:24 ` Roger Quadros
2015-09-02 14:32 ` Felipe Balbi
2015-09-02 14:32 ` Felipe Balbi
2015-09-02 14:24 ` [PATCH v4 4/9] usb: dwc3: core: Adapt to named interrupts Roger Quadros
2015-09-02 14:24 ` Roger Quadros
2015-09-02 14:34 ` Felipe Balbi
2015-09-02 14:34 ` Felipe Balbi
2015-09-03 12:46 ` Roger Quadros
2015-09-03 12:46 ` Roger Quadros
2015-09-03 15:48 ` Felipe Balbi
2015-09-03 15:48 ` Felipe Balbi
2015-09-04 9:11 ` Roger Quadros
2015-09-04 9:11 ` Roger Quadros
2015-09-02 14:24 ` [PATCH v4 5/9] usb: dwc3: core: make dual-role work with OTG irq Roger Quadros
2015-09-02 14:24 ` Roger Quadros
2015-09-02 14:43 ` Felipe Balbi
2015-09-02 14:43 ` Felipe Balbi
2015-09-03 13:52 ` Roger Quadros
2015-09-03 13:52 ` Roger Quadros
2015-09-03 15:51 ` Felipe Balbi
2015-09-03 15:51 ` Felipe Balbi
2015-09-04 9:13 ` Roger Quadros
2015-09-04 9:13 ` Roger Quadros
2015-09-06 2:20 ` Peter Chen [this message]
2015-09-06 2:20 ` Peter Chen
2015-09-15 14:46 ` Roger Quadros
2015-09-15 14:46 ` Roger Quadros
2015-09-02 14:24 ` [PATCH v4 6/9] usb: dwc3: save/restore OTG registers during suspend/resume Roger Quadros
2015-09-02 14:24 ` Roger Quadros
2015-09-02 14:44 ` Felipe Balbi
2015-09-02 14:44 ` Felipe Balbi
2015-09-03 13:54 ` Roger Quadros
2015-09-03 13:54 ` Roger Quadros
2015-09-02 14:24 ` [PATCH v4 7/9] usb: dwc3: gadget: Fix suspend/resume during dual-role mode Roger Quadros
2015-09-02 14:24 ` Roger Quadros
2015-09-02 14:24 ` [PATCH v4 8/9] usb: dwc3: core: Prevent otg events from disabling themselves Roger Quadros
2015-09-02 14:24 ` Roger Quadros
2015-09-02 14:47 ` Felipe Balbi
2015-09-02 14:47 ` Felipe Balbi
2015-09-03 13:54 ` Roger Quadros
2015-09-03 13:54 ` Roger Quadros
2015-09-02 14:24 ` [PATCH v4 9/9] usb: dwc3: core: don't break during suspend/resume while we're dual-role Roger Quadros
2015-09-02 14:24 ` Roger Quadros
2015-09-02 14:48 ` Felipe Balbi
2015-09-02 14:48 ` Felipe Balbi
2015-09-03 14:02 ` Roger Quadros
2015-09-03 14:02 ` Roger Quadros
2015-09-02 17:22 ` Sergei Shtylyov
2015-09-03 14:01 ` Roger Quadros
2015-09-03 14:01 ` Roger Quadros
2015-09-03 14:05 ` Sergei Shtylyov
2015-09-03 14:05 ` Sergei Shtylyov
2015-09-03 14:10 ` Roger Quadros
2015-09-03 14:10 ` Roger Quadros
2015-09-03 14:13 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150906022040.GC4914@shlinux2 \
--to=peter.chen@freescale.com \
--cc=Joao.Pinto@synopsys.com \
--cc=balbi@ti.com \
--cc=jun.li@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.