From: Dave Chinner <david@fromorbit.com> To: Andreas Gruenbacher <andreas.gruenbacher@gmail.com> Cc: linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>, Andreas Gruenbacher <agruenba@redhat.com>, linux-api@vger.kernel.org, Trond Myklebust <trond.myklebust@primarydata.com>, linux-kernel@vger.kernel.org, xfs@oss.sgi.com, "J. Bruce Fields" <bfields@fieldses.org>, Andreas Dilger <adilger.kernel@dilger.ca>, Alexander Viro <viro@zeniv.linux.org.uk>, linux-fsdevel@vger.kernel.org, Jeff Layton <jlayton@poochiereds.net>, linux-ext4@vger.kernel.org, Anna Schumaker <anna.schumaker@netapp.com> Subject: Re: [PATCH v10 38/46] richacl: Add support for unmapped identifiers Date: Mon, 12 Oct 2015 11:22:00 +1100 [thread overview] Message-ID: <20151012002200.GB27164@dastard> (raw) In-Reply-To: <1444604337-17651-39-git-send-email-andreas.gruenbacher@gmail.com> On Mon, Oct 12, 2015 at 12:58:49AM +0200, Andreas Gruenbacher wrote: > From: Andreas Gruenbacher <agruenba@redhat.com> > > Some remote file systems like nfs may return user or group identifiers > that cannot be mapped to local uids / gids. Allow to represent such > unmapped identifiers in richacls. (We still cannot represent unmapped > owners and owning groups, however.) > > In the in-memory representation, the richacl is followed by a list of > NUL-terminated strings, with no padding. Entries with an unmapped > identifier have the RICHACE_UNMAPPED_WHO flag set, and ace->e_id.offs > specifies the offset into this list. Multiple entries can refer to the > same offset. > > The xattr representation is similar, but ace->e_id is ignored, and the > list of unmapped identifier strings contains a string for each acl entry > whose RICHACE_UNMAPPED_WHO flag is set. > > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> .... > +/** > + * richacl_has_unmapped_identifiers > + * > + * Check if an acl has unmapped identifiers. > + */ > +bool richacl_has_unmapped_identifiers(struct richacl *acl) > +{ > + struct richace *ace; > + > + richacl_for_each_entry(ace, acl) { > + if (ace->e_flags & RICHACE_UNMAPPED_WHO) > + return true; > + } > + return false; > +} > +EXPORT_SYMBOL_GPL(richacl_has_unmapped_identifiers); This was used by the XFS support patch earlier in the series. Bisect problem here... Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com> To: Andreas Gruenbacher <andreas.gruenbacher@gmail.com> Cc: Alexander Viro <viro@zeniv.linux.org.uk>, "Theodore Ts'o" <tytso@mit.edu>, Andreas Dilger <adilger.kernel@dilger.ca>, "J. Bruce Fields" <bfields@fieldses.org>, Jeff Layton <jlayton@poochiereds.net>, Trond Myklebust <trond.myklebust@primarydata.com>, Anna Schumaker <anna.schumaker@netapp.com>, linux-ext4@vger.kernel.org, xfs@oss.sgi.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-api@vger.kernel.org, Andreas Gruenbacher <agruenba@redhat.com> Subject: Re: [PATCH v10 38/46] richacl: Add support for unmapped identifiers Date: Mon, 12 Oct 2015 11:22:00 +1100 [thread overview] Message-ID: <20151012002200.GB27164@dastard> (raw) In-Reply-To: <1444604337-17651-39-git-send-email-andreas.gruenbacher@gmail.com> On Mon, Oct 12, 2015 at 12:58:49AM +0200, Andreas Gruenbacher wrote: > From: Andreas Gruenbacher <agruenba@redhat.com> > > Some remote file systems like nfs may return user or group identifiers > that cannot be mapped to local uids / gids. Allow to represent such > unmapped identifiers in richacls. (We still cannot represent unmapped > owners and owning groups, however.) > > In the in-memory representation, the richacl is followed by a list of > NUL-terminated strings, with no padding. Entries with an unmapped > identifier have the RICHACE_UNMAPPED_WHO flag set, and ace->e_id.offs > specifies the offset into this list. Multiple entries can refer to the > same offset. > > The xattr representation is similar, but ace->e_id is ignored, and the > list of unmapped identifier strings contains a string for each acl entry > whose RICHACE_UNMAPPED_WHO flag is set. > > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> .... > +/** > + * richacl_has_unmapped_identifiers > + * > + * Check if an acl has unmapped identifiers. > + */ > +bool richacl_has_unmapped_identifiers(struct richacl *acl) > +{ > + struct richace *ace; > + > + richacl_for_each_entry(ace, acl) { > + if (ace->e_flags & RICHACE_UNMAPPED_WHO) > + return true; > + } > + return false; > +} > +EXPORT_SYMBOL_GPL(richacl_has_unmapped_identifiers); This was used by the XFS support patch earlier in the series. Bisect problem here... Cheers, Dave. -- Dave Chinner david@fromorbit.com
next prev parent reply other threads:[~2015-10-12 0:22 UTC|newest] Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-10-11 22:58 [PATCH v10 00/46] Richacls Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 01/46] vfs: Add IS_ACL() and IS_RICHACL() tests Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 02/46] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 03/46] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD " Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 04/46] vfs: Make the inode passed to inode_change_ok non-const Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 05/46] vfs: Add permission flags for setting file attributes Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 06/46] richacl: In-memory representation and helper functions Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 07/46] richacl: Permission mapping functions Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 08/46] richacl: Compute maximum file masks from an acl Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 09/46] richacl: Permission check algorithm Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher [not found] ` <1444604337-17651-1-git-send-email-andreas.gruenbacher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2015-10-11 22:58 ` [PATCH v10 10/46] vfs: Cache base_acl objects in inodes Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 11/46] vfs: Add get_richacl and set_richacl inode operations Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 12/46] vfs: Cache richacl in struct inode Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 13/46] richacl: Update the file masks in chmod() Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 14/46] richacl: Check if an acl is equivalent to a file mode Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 15/46] richacl: Create-time inheritance Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 16/46] richacl: Automatic Inheritance Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 17/46] richacl: xattr mapping functions Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 18/46] richacl: Add richacl xattr handler Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 19/46] vfs: Add richacl permission checking Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 20/46] ext4: Add richacl support Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 21/46] ext4: Add richacl feature flag Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 22/46] xfs: Fix error path in xfs_get_acl Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 23/46] xfs: Make xfs_set_mode non-static Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 23:37 ` Dave Chinner 2015-10-11 23:37 ` Dave Chinner 2015-10-11 22:58 ` [PATCH v10 24/46] xfs: Add richacl support Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher [not found] ` <1444604337-17651-25-git-send-email-andreas.gruenbacher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2015-10-12 0:10 ` Dave Chinner 2015-10-12 0:10 ` Dave Chinner 2015-10-12 0:10 ` Dave Chinner 2015-10-12 1:51 ` Andreas Grünbacher 2015-10-12 1:51 ` Andreas Grünbacher 2015-10-12 1:51 ` Andreas Grünbacher [not found] ` <CAHpGcMKeJHDegs2cYKaJdX4Tw43Jp30Nv_2WoSNZfBzGJKu=BQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-10-12 4:05 ` Dave Chinner 2015-10-12 4:05 ` Dave Chinner 2015-10-12 4:05 ` Dave Chinner 2015-10-12 5:57 ` Andreas Gruenbacher 2015-10-12 5:57 ` Andreas Gruenbacher 2015-10-12 5:57 ` Andreas Gruenbacher [not found] ` <CAHc6FU55eOK4gWH1bhKvoujQ1zkT+we0xcfPUOeWrF_X0XHXZg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-10-13 19:21 ` Austin S Hemmelgarn 2015-10-13 19:21 ` Austin S Hemmelgarn 2015-10-13 19:21 ` Austin S Hemmelgarn 2015-10-13 13:39 ` Andreas Gruenbacher 2015-10-13 13:39 ` Andreas Gruenbacher 2015-10-13 13:39 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 25/46] richacl: acl editing helper functions Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 26/46] richacl: Move everyone@ aces down the acl Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 27/46] richacl: Propagate everyone@ permissions to other aces Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 28/46] richacl: Set the owner permissions to the owner mask Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 29/46] richacl: Set the other permissions to the other mask Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 30/46] richacl: Isolate the owner and group classes Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 31/46] richacl: Apply the file masks to a richacl Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 32/46] richacl: Create richacl from mode values Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 33/46] nfsd: Keep list of acls to dispose of in compoundargs Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 34/46] nfsd: Use richacls as internal acl representation Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 35/46] nfsd: Add richacl support Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 36/46] nfsd: Add support for the v4.1 dacl attribute Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 37/46] nfsd: Add support for the MAY_CREATE_{FILE, DIR} permissions Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 37/46] nfsd: Add support for the MAY_CREATE_{FILE,DIR} permissions Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 38/46] richacl: Add support for unmapped identifiers Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-12 0:22 ` Dave Chinner [this message] 2015-10-12 0:22 ` Dave Chinner 2015-10-12 1:53 ` Andreas Grünbacher 2015-10-12 1:53 ` Andreas Grünbacher 2015-10-12 1:53 ` Andreas Grünbacher 2015-10-11 22:58 ` [PATCH v10 39/46] ext4: Don't allow unmapped identifiers in richacls Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 40/46] sunrpc: Allow to demand-allocate pages to encode into Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 41/46] sunrpc: Add xdr_init_encode_pages Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 42/46] nfs: Fix GETATTR bitmap verification Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 43/46] nfs: Remove unused xdr page offsets in getacl/setacl arguments Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 44/46] nfs: Add richacl support Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher [not found] ` <1444604337-17651-45-git-send-email-andreas.gruenbacher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2015-10-12 14:39 ` Anna Schumaker 2015-10-12 14:39 ` Anna Schumaker 2015-10-12 14:39 ` Anna Schumaker 2015-10-12 14:39 ` Anna Schumaker 2015-10-12 19:49 ` Andreas Gruenbacher 2015-10-12 19:49 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 45/46] nfs: Add support for the v4.1 dacl attribute Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher 2015-10-11 22:58 ` [PATCH v10 46/46] richacl: uapi header split Andreas Gruenbacher 2015-10-11 22:58 ` Andreas Gruenbacher
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20151012002200.GB27164@dastard \ --to=david@fromorbit.com \ --cc=adilger.kernel@dilger.ca \ --cc=agruenba@redhat.com \ --cc=andreas.gruenbacher@gmail.com \ --cc=anna.schumaker@netapp.com \ --cc=bfields@fieldses.org \ --cc=jlayton@poochiereds.net \ --cc=linux-api@vger.kernel.org \ --cc=linux-cifs@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nfs@vger.kernel.org \ --cc=trond.myklebust@primarydata.com \ --cc=tytso@mit.edu \ --cc=viro@zeniv.linux.org.uk \ --cc=xfs@oss.sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.