Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

From: Catalin Marinas <catalin.marinas@arm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Yang Shi <yang.shi@linaro.org>,
	linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option
Date: Fri, 6 Nov 2015 16:12:14 +0000	[thread overview]
Message-ID: <20151106161214.GY7637@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <20151106123008.GK6087@arm.com>

On Fri, Nov 06, 2015 at 12:30:09PM +0000, Will Deacon wrote:
> On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote:
> > FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine
> > it in arch/arm64/Kconfig.debug.
> 
> It might be worth noting that this adds a dependency on DEBUG_KERNEL
> for building with frame pointers. I'm ok with that (it appears to be
> enabled in defconfig and follows the vast majority of other archs) but
> it is a change in behaviour.

We shouldn't have the dependency on DEBUG_KERNEL since we select
ARCH_WANT_FRAME_POINTERS on arm64. However, the patch would allow one to
disable FRAME_POINTERS (not sure it has any effect on the aarch64 gcc
though).

-- 
Catalin