From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org,
mtosatti@redhat.com, stefanha@redhat.com, rth@twiddle.net,
ehabkost@redhat.com, dan.j.williams@intel.com,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v6 05/33] acpi: add aml_object_type
Date: Mon, 9 Nov 2015 13:35:51 +0200 [thread overview]
Message-ID: <20151109113551.GC3324@redhat.com> (raw)
In-Reply-To: <1446184587-142784-6-git-send-email-guangrong.xiao@linux.intel.com>
On Fri, Oct 30, 2015 at 01:55:59PM +0800, Xiao Guangrong wrote:
> Implement ObjectType which is used by NVDIMM _DSM method in
> later patch
>
> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
I had to go dig in the _DSM patch to see how it's used.
And sure enough, callers have to know AML to make
sense of it. So pls don't split out tiny patches like this.
include the callee with the caller.
> ---
> hw/acpi/aml-build.c | 8 ++++++++
> include/hw/acpi/aml-build.h | 1 +
> 2 files changed, 9 insertions(+)
>
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index efc06ab..9f792ab 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -1178,6 +1178,14 @@ Aml *aml_concatenate(Aml *source1, Aml *source2, Aml *target)
> return var;
> }
>
> +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefObjectType */
> +Aml *aml_object_type(Aml *object)
> +{
> + Aml *var = aml_opcode(0x8E /* ObjectTypeOp */);
> + aml_append(var, object);
> + return var;
> +}
> +
It would be better to have a higher level API
that can be used without knowning AML.
For example:
aml_object_type_is_package()
> void
> build_header(GArray *linker, GArray *table_data,
> AcpiTableHeader *h, const char *sig, int len, uint8_t rev)
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index 325782d..5b8a118 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -278,6 +278,7 @@ Aml *aml_derefof(Aml *arg);
> Aml *aml_sizeof(Aml *arg);
> Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name);
> Aml *aml_concatenate(Aml *source1, Aml *source2, Aml *target);
> +Aml *aml_object_type(Aml *object);
>
> void
> build_header(GArray *linker, GArray *table_data,
> --
> 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org,
mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
imammedo@redhat.com, pbonzini@redhat.com,
dan.j.williams@intel.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v6 05/33] acpi: add aml_object_type
Date: Mon, 9 Nov 2015 13:35:51 +0200 [thread overview]
Message-ID: <20151109113551.GC3324@redhat.com> (raw)
In-Reply-To: <1446184587-142784-6-git-send-email-guangrong.xiao@linux.intel.com>
On Fri, Oct 30, 2015 at 01:55:59PM +0800, Xiao Guangrong wrote:
> Implement ObjectType which is used by NVDIMM _DSM method in
> later patch
>
> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
I had to go dig in the _DSM patch to see how it's used.
And sure enough, callers have to know AML to make
sense of it. So pls don't split out tiny patches like this.
include the callee with the caller.
> ---
> hw/acpi/aml-build.c | 8 ++++++++
> include/hw/acpi/aml-build.h | 1 +
> 2 files changed, 9 insertions(+)
>
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index efc06ab..9f792ab 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -1178,6 +1178,14 @@ Aml *aml_concatenate(Aml *source1, Aml *source2, Aml *target)
> return var;
> }
>
> +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefObjectType */
> +Aml *aml_object_type(Aml *object)
> +{
> + Aml *var = aml_opcode(0x8E /* ObjectTypeOp */);
> + aml_append(var, object);
> + return var;
> +}
> +
It would be better to have a higher level API
that can be used without knowning AML.
For example:
aml_object_type_is_package()
> void
> build_header(GArray *linker, GArray *table_data,
> AcpiTableHeader *h, const char *sig, int len, uint8_t rev)
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index 325782d..5b8a118 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -278,6 +278,7 @@ Aml *aml_derefof(Aml *arg);
> Aml *aml_sizeof(Aml *arg);
> Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name);
> Aml *aml_concatenate(Aml *source1, Aml *source2, Aml *target);
> +Aml *aml_object_type(Aml *object);
>
> void
> build_header(GArray *linker, GArray *table_data,
> --
> 1.8.3.1
next prev parent reply other threads:[~2015-11-09 11:35 UTC|newest]
Thread overview: 182+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 5:55 [PATCH v6 00/33] implement vNVDIMM Xiao Guangrong
2015-10-30 5:55 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:55 ` [PATCH v6 01/33] acpi: add aml_derefof Xiao Guangrong
2015-10-30 5:55 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:55 ` [PATCH v6 02/33] acpi: add aml_sizeof Xiao Guangrong
2015-10-30 5:55 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:55 ` [PATCH v6 03/33] acpi: add aml_create_field Xiao Guangrong
2015-10-30 5:55 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:55 ` [PATCH v6 04/33] acpi: add aml_concatenate Xiao Guangrong
2015-10-30 5:55 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:55 ` [PATCH v6 05/33] acpi: add aml_object_type Xiao Guangrong
2015-10-30 5:55 ` [Qemu-devel] " Xiao Guangrong
2015-11-09 11:35 ` Michael S. Tsirkin [this message]
2015-11-09 11:35 ` Michael S. Tsirkin
2015-11-09 12:40 ` Igor Mammedov
2015-11-09 12:40 ` [Qemu-devel] " Igor Mammedov
2015-10-30 5:56 ` [PATCH v6 06/33] acpi: add aml_method_serialized Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-11-09 11:14 ` Michael S. Tsirkin
2015-11-09 11:14 ` [Qemu-devel] " Michael S. Tsirkin
2015-11-09 11:18 ` Xiao Guangrong
2015-11-09 11:18 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 07/33] util: introduce qemu_file_get_page_size() Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 13:26 ` Vladimir Sementsov-Ogievskiy
2015-10-30 13:26 ` Vladimir Sementsov-Ogievskiy
2015-10-31 7:26 ` Xiao Guangrong
2015-10-31 7:26 ` [Qemu-devel] " Xiao Guangrong
2015-10-31 9:37 ` Vladimir Sementsov-Ogievskiy
2015-10-31 9:37 ` Vladimir Sementsov-Ogievskiy
2015-10-31 14:06 ` Xiao Guangrong
2015-10-31 14:06 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 15:54 ` Eduardo Habkost
2015-10-30 15:54 ` [Qemu-devel] " Eduardo Habkost
2015-10-31 8:09 ` Xiao Guangrong
2015-10-31 8:09 ` [Qemu-devel] " Xiao Guangrong
2015-10-31 14:11 ` Eduardo Habkost
2015-10-31 14:11 ` [Qemu-devel] " Eduardo Habkost
2015-10-31 17:03 ` Xiao Guangrong
2015-10-31 17:03 ` [Qemu-devel] " Xiao Guangrong
2015-11-09 20:00 ` Michael S. Tsirkin
2015-11-09 20:00 ` [Qemu-devel] " Michael S. Tsirkin
2015-10-31 8:25 ` Xiao Guangrong
2015-10-31 8:25 ` [Qemu-devel] " Xiao Guangrong
2015-11-09 10:33 ` Michael S. Tsirkin
2015-11-09 10:33 ` [Qemu-devel] " Michael S. Tsirkin
2015-11-09 10:55 ` Xiao Guangrong
2015-11-09 10:55 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 08/33] exec: allow memory to be allocated from any kind of path Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 14:04 ` Vladimir Sementsov-Ogievskiy
2015-10-30 14:04 ` Vladimir Sementsov-Ogievskiy
2015-10-31 7:44 ` Xiao Guangrong
2015-10-31 13:55 ` Eduardo Habkost
2015-10-31 13:55 ` Eduardo Habkost
2015-10-31 15:56 ` Xiao Guangrong
2015-10-31 15:56 ` Xiao Guangrong
2015-11-09 10:39 ` Michael S. Tsirkin
2015-11-09 10:39 ` [Qemu-devel] " Michael S. Tsirkin
2015-11-09 11:01 ` Xiao Guangrong
2015-11-09 11:01 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 09/33] exec: allow file_ram_alloc to work on file Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 14:25 ` Vladimir Sementsov-Ogievskiy
2015-10-30 14:25 ` Vladimir Sementsov-Ogievskiy
2015-10-31 7:53 ` Xiao Guangrong
2015-10-31 7:53 ` [Qemu-devel] " Xiao Guangrong
2015-11-09 10:13 ` Michael S. Tsirkin
2015-11-09 10:13 ` [Qemu-devel] " Michael S. Tsirkin
2015-11-09 10:48 ` Xiao Guangrong
2015-11-09 10:48 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 10/33] hostmem-file: clean up memory allocation Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 14:54 ` Vladimir Sementsov-Ogievskiy
2015-10-30 14:54 ` Vladimir Sementsov-Ogievskiy
2015-10-30 5:56 ` [PATCH v6 11/33] hostmem-file: use whole file size if possible Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 15:27 ` Vladimir Sementsov-Ogievskiy
2015-10-30 15:27 ` Vladimir Sementsov-Ogievskiy
2015-10-31 7:59 ` Xiao Guangrong
2015-10-31 7:59 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 17:30 ` Eduardo Habkost
2015-10-30 17:30 ` Eduardo Habkost
2015-10-31 8:46 ` Xiao Guangrong
2015-10-31 8:46 ` Xiao Guangrong
2015-10-31 13:45 ` Eduardo Habkost
2015-10-31 13:45 ` Eduardo Habkost
2015-10-31 16:59 ` Xiao Guangrong
2015-10-31 16:59 ` [Qemu-devel] " Xiao Guangrong
2015-11-09 10:17 ` Michael S. Tsirkin
2015-11-09 10:17 ` [Qemu-devel] " Michael S. Tsirkin
2015-11-09 10:49 ` Xiao Guangrong
2015-11-09 10:49 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 12/33] pc-dimm: remove DEFAULT_PC_DIMMSIZE Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-11-09 10:40 ` Michael S. Tsirkin
2015-11-09 10:40 ` [Qemu-devel] " Michael S. Tsirkin
2015-11-09 11:03 ` Xiao Guangrong
2015-11-09 11:03 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 13/33] pc-dimm: make pc_existing_dimms_capacity static and rename it Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 15:38 ` Vladimir Sementsov-Ogievskiy
2015-10-30 15:38 ` Vladimir Sementsov-Ogievskiy
2015-10-30 5:56 ` [PATCH v6 14/33] pc-dimm: drop the prefix of pc-dimm Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 16:10 ` Vladimir Sementsov-Ogievskiy
2015-10-30 16:10 ` Vladimir Sementsov-Ogievskiy
2015-10-31 8:18 ` Xiao Guangrong
2015-10-30 17:06 ` Eric Blake
2015-10-31 8:23 ` Xiao Guangrong
2015-11-09 20:05 ` Michael S. Tsirkin
2015-11-09 20:05 ` [Qemu-devel] " Michael S. Tsirkin
2015-10-30 5:56 ` [PATCH v6 15/33] stubs: rename qmp_pc_dimm_device_list.c Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 16/33] pc-dimm: rename pc-dimm.c and pc-dimm.h Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-31 10:28 ` Vladimir Sementsov-Ogievskiy
2015-10-31 10:28 ` Vladimir Sementsov-Ogievskiy
2015-10-30 5:56 ` [PATCH v6 17/33] dimm: abstract dimm device from pc-dimm Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-31 10:41 ` Vladimir Sementsov-Ogievskiy
2015-10-31 10:41 ` [Qemu-devel] " Vladimir Sementsov-Ogievskiy
2015-10-30 5:56 ` [PATCH v6 18/33] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-31 10:52 ` Vladimir Sementsov-Ogievskiy
2015-10-31 10:52 ` Vladimir Sementsov-Ogievskiy
2015-10-31 14:15 ` Xiao Guangrong
2015-10-31 14:15 ` [Qemu-devel] " Xiao Guangrong
2015-11-02 9:18 ` Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 19/33] dimm: keep the state of the whole backend memory Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-31 11:05 ` Vladimir Sementsov-Ogievskiy
2015-10-31 11:05 ` Vladimir Sementsov-Ogievskiy
2015-10-31 14:19 ` Xiao Guangrong
2015-11-09 11:04 ` Michael S. Tsirkin
2015-11-09 11:04 ` [Qemu-devel] " Michael S. Tsirkin
2015-11-09 11:13 ` Xiao Guangrong
2015-11-09 11:13 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 20/33] dimm: introduce realize callback Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-31 11:22 ` Vladimir Sementsov-Ogievskiy
2015-10-31 11:22 ` [Qemu-devel] " Vladimir Sementsov-Ogievskiy
2015-10-30 5:56 ` [PATCH v6 21/33] nvdimm: implement NVDIMM device abstract Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 22/33] docs: add NVDIMM ACPI documentation Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 23/33] nvdimm acpi: init the resource used by NVDIMM ACPI Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 24/33] nvdimm acpi: build ACPI NFIT table Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 25/33] nvdimm acpi: build ACPI nvdimm devices Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-11-08 17:38 ` Michael S. Tsirkin
2015-11-08 17:38 ` [Qemu-devel] " Michael S. Tsirkin
2015-11-09 6:07 ` Xiao Guangrong
2015-11-09 6:07 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 26/33] nvdimm acpi: save arg3 for NVDIMM device _DSM method Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 27/33] nvdimm acpi: support function 0 Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 10:14 ` Stefan Hajnoczi
2015-10-30 10:14 ` [Qemu-devel] " Stefan Hajnoczi
2015-10-30 13:01 ` Xiao Guangrong
2015-10-30 13:01 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 28/33] nvdimm acpi: support Get Namespace Label Size function Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 29/33] nvdimm acpi: support Get Namespace Label Data function Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 30/33] nvdimm acpi: support Set " Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 31/33] nvdimm: allow using whole backend memory as pmem Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 32/33] nvdimm acpi: support _FIT method Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-11-08 17:50 ` Michael S. Tsirkin
2015-11-08 17:50 ` [Qemu-devel] " Michael S. Tsirkin
2015-11-09 6:37 ` Xiao Guangrong
2015-11-09 6:37 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 5:56 ` [PATCH v6 33/33] nvdimm: add maintain info Xiao Guangrong
2015-10-30 5:56 ` [Qemu-devel] " Xiao Guangrong
2015-10-30 10:15 ` [PATCH v6 00/33] implement vNVDIMM Stefan Hajnoczi
2015-10-30 10:15 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151109113551.GC3324@redhat.com \
--to=mst@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=gleb@kernel.org \
--cc=guangrong.xiao@linux.intel.com \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.