From: "Darrick J. Wong" <darrick.wong@oracle.com> To: Christoph Hellwig <hch@infradead.org> Cc: david@fromorbit.com, fstests@vger.kernel.org, xfs@oss.sgi.com, tao.peng@primarydata.com, linux-ext4@vger.kernel.org, Anna.Schumaker@netapp.com, linux-btrfs@vger.kernel.org Subject: Re: [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls Date: Thu, 12 Nov 2015 09:34:27 -0800 [thread overview] Message-ID: <20151112173427.GC2217@birch.djwong.org> (raw) In-Reply-To: <20151112125115.GA28822@infradead.org> On Thu, Nov 12, 2015 at 04:51:15AM -0800, Christoph Hellwig wrote: > On Thu, Nov 12, 2015 at 01:07:56AM -0800, Christoph Hellwig wrote: > > Looks fine: > > > > Acked-by: Christoph Hellwig <hch@lst.de> > > Actually I take this back. I had though this was the existing series > with my fixes, but this one still incorrectly assumes that if reflink > works dedup works as well, leading to lots of false failures on nfs. Bleargh, _require_*_dedupe forgot to check for ENOTTY output, so all the dedupe tests should have _notrun. Also, generic/806 was calling the wrong _require. I'll start renumbering tests; Christoph, did you see anything else? --D > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com> To: Christoph Hellwig <hch@infradead.org> Cc: fstests@vger.kernel.org, xfs@oss.sgi.com, tao.peng@primarydata.com, linux-ext4@vger.kernel.org, Anna.Schumaker@netapp.com, linux-btrfs@vger.kernel.org Subject: Re: [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls Date: Thu, 12 Nov 2015 09:34:27 -0800 [thread overview] Message-ID: <20151112173427.GC2217@birch.djwong.org> (raw) In-Reply-To: <20151112125115.GA28822@infradead.org> On Thu, Nov 12, 2015 at 04:51:15AM -0800, Christoph Hellwig wrote: > On Thu, Nov 12, 2015 at 01:07:56AM -0800, Christoph Hellwig wrote: > > Looks fine: > > > > Acked-by: Christoph Hellwig <hch@lst.de> > > Actually I take this back. I had though this was the existing series > with my fixes, but this one still incorrectly assumes that if reflink > works dedup works as well, leading to lots of false failures on nfs. Bleargh, _require_*_dedupe forgot to check for ENOTTY output, so all the dedupe tests should have _notrun. Also, generic/806 was calling the wrong _require. I'll start renumbering tests; Christoph, did you see anything else? --D > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-11-12 17:35 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-11 19:26 [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls Darrick J. Wong 2015-11-11 19:26 ` Darrick J. Wong 2015-11-11 19:26 ` [PATCH 01/11] btrfs: move btrfs reflink tests to generic Darrick J. Wong 2015-11-11 19:26 ` Darrick J. Wong 2015-11-11 19:26 ` [PATCH 02/11] generic/80[0-2]: support xfs in addition to btrfs Darrick J. Wong 2015-11-11 19:26 ` Darrick J. Wong 2015-11-11 19:26 ` [PATCH 03/11] reflink: basic tests of the reflink and dedupe ioctls Darrick J. Wong 2015-11-11 19:26 ` Darrick J. Wong 2015-11-11 19:26 ` [PATCH 04/11] reflink: test CoW behaviors of reflinked files Darrick J. Wong 2015-11-11 19:26 ` Darrick J. Wong 2015-11-11 19:27 ` [PATCH 05/11] reflink: test the various fallocate modes Darrick J. Wong 2015-11-11 19:27 ` Darrick J. Wong 2015-11-11 19:27 ` [PATCH 06/11] reflink: concurrent operations tests Darrick J. Wong 2015-11-11 19:27 ` Darrick J. Wong 2015-11-11 19:27 ` [PATCH 07/11] reflink: test accuracy of free block counts Darrick J. Wong 2015-11-11 19:27 ` Darrick J. Wong 2015-11-11 19:27 ` [PATCH 08/11] reflink: test error conditions due to bad inputs Darrick J. Wong 2015-11-11 19:27 ` Darrick J. Wong 2015-11-11 19:27 ` [PATCH 09/11] xfs: test xfs-specific reflink pieces Darrick J. Wong 2015-11-11 19:27 ` Darrick J. Wong 2015-11-11 19:27 ` [PATCH 10/11] reflink: test what happens when we hit resource limits Darrick J. Wong 2015-11-11 19:27 ` Darrick J. Wong 2015-11-11 19:27 ` [PATCH 11/11] reflink: test that CoW writes fail when we're out of space Darrick J. Wong 2015-11-11 19:27 ` Darrick J. Wong 2015-11-12 9:07 ` [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls Christoph Hellwig 2015-11-12 9:07 ` Christoph Hellwig 2015-11-12 12:51 ` Christoph Hellwig 2015-11-12 12:51 ` Christoph Hellwig 2015-11-12 17:34 ` Darrick J. Wong [this message] 2015-11-12 17:34 ` Darrick J. Wong 2015-11-12 17:36 ` Christoph Hellwig 2015-11-12 17:36 ` Christoph Hellwig 2015-11-13 9:08 ` Darrick J. Wong 2015-11-13 9:08 ` Darrick J. Wong 2015-11-13 14:12 ` Christoph Hellwig 2015-11-13 14:12 ` Christoph Hellwig 2015-11-13 18:32 ` Darrick J. Wong 2015-11-13 18:32 ` Darrick J. Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20151112173427.GC2217@birch.djwong.org \ --to=darrick.wong@oracle.com \ --cc=Anna.Schumaker@netapp.com \ --cc=david@fromorbit.com \ --cc=fstests@vger.kernel.org \ --cc=hch@infradead.org \ --cc=linux-btrfs@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=tao.peng@primarydata.com \ --cc=xfs@oss.sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.