From: Thierry Reding <treding@nvidia.com>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: Rob Herring <robh@kernel.org>, <heiko@sntech.de>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<galak@codeaurora.org>, <linux@arm.linux.org.uk>,
<linux-rockchip@lists.infradead.org>,
<ijc+devicetree@hellion.org.uk>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <linux-arm-kernel@lists.infradead.org>,
<khilman@linaro.org>, <wxt@rock-chips.com>, <sjg@chromium.org>,
<benchan@google.com>
Subject: Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot notifier driver
Date: Thu, 19 Nov 2015 13:56:45 +0100 [thread overview]
Message-ID: <20151119125643.GE21862@ulmo.nvidia.com> (raw)
In-Reply-To: <564D2331.8070503@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]
On Thu, Nov 19, 2015 at 09:17:37AM +0800, Andy Yan wrote:
> Hi Rob:
>
> On 2015年11月19日 06:59, Rob Herring wrote:
> >On Wed, Nov 18, 2015 at 05:53:30PM +0800, Andy Yan wrote:
> >>Add devicetree binding document for rockchip reboot nofifier driver
> >Just reading the subject this is way too specific to the Linux driver
> >needs rather than a h/w description. Please don't create fake DT nodes
> >just to bind to drivers. Whatever &pmu is is probably what should have
> >the DT node. Let the driver for it create child devices if you need
> >that.
>
> This is note a fake DT nodes, we really need it to tell the driver
> which register to use to store the reboot mode. Because rockchip
> use different register file to store the reboot mode on different
> platform, on rk3066,rk3188, rk3288,it use one of the PMU register, on
> the incoming RK3036, it use one of the GRF register, and it use one of
> the PMUGRF register for arm64 platform rk3368. On the other hand, the
> PMU/GRF/PMUGRF register file are mapped as "syscon", then referenced
> by other DT nodes by phandle. So maybe let it as a separate DT node
> here
> is better.
In that case you should probably implement a reboot notifier in each of
the drivers you list and depending on the generation of the SoC. You can
easily parameterize this by matching on the compatible string.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Andy Yan <andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
benchan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot notifier driver
Date: Thu, 19 Nov 2015 13:56:45 +0100 [thread overview]
Message-ID: <20151119125643.GE21862@ulmo.nvidia.com> (raw)
In-Reply-To: <564D2331.8070503-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]
On Thu, Nov 19, 2015 at 09:17:37AM +0800, Andy Yan wrote:
> Hi Rob:
>
> On 2015年11月19日 06:59, Rob Herring wrote:
> >On Wed, Nov 18, 2015 at 05:53:30PM +0800, Andy Yan wrote:
> >>Add devicetree binding document for rockchip reboot nofifier driver
> >Just reading the subject this is way too specific to the Linux driver
> >needs rather than a h/w description. Please don't create fake DT nodes
> >just to bind to drivers. Whatever &pmu is is probably what should have
> >the DT node. Let the driver for it create child devices if you need
> >that.
>
> This is note a fake DT nodes, we really need it to tell the driver
> which register to use to store the reboot mode. Because rockchip
> use different register file to store the reboot mode on different
> platform, on rk3066,rk3188, rk3288,it use one of the PMU register, on
> the incoming RK3036, it use one of the GRF register, and it use one of
> the PMUGRF register for arm64 platform rk3368. On the other hand, the
> PMU/GRF/PMUGRF register file are mapped as "syscon", then referenced
> by other DT nodes by phandle. So maybe let it as a separate DT node
> here
> is better.
In that case you should probably implement a reboot notifier in each of
the drivers you list and depending on the generation of the SoC. You can
easily parameterize this by matching on the compatible string.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: treding@nvidia.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot notifier driver
Date: Thu, 19 Nov 2015 13:56:45 +0100 [thread overview]
Message-ID: <20151119125643.GE21862@ulmo.nvidia.com> (raw)
In-Reply-To: <564D2331.8070503@rock-chips.com>
On Thu, Nov 19, 2015 at 09:17:37AM +0800, Andy Yan wrote:
> Hi Rob:
>
> On 2015?11?19? 06:59, Rob Herring wrote:
> >On Wed, Nov 18, 2015 at 05:53:30PM +0800, Andy Yan wrote:
> >>Add devicetree binding document for rockchip reboot nofifier driver
> >Just reading the subject this is way too specific to the Linux driver
> >needs rather than a h/w description. Please don't create fake DT nodes
> >just to bind to drivers. Whatever &pmu is is probably what should have
> >the DT node. Let the driver for it create child devices if you need
> >that.
>
> This is note a fake DT nodes, we really need it to tell the driver
> which register to use to store the reboot mode. Because rockchip
> use different register file to store the reboot mode on different
> platform, on rk3066,rk3188, rk3288,it use one of the PMU register, on
> the incoming RK3036, it use one of the GRF register, and it use one of
> the PMUGRF register for arm64 platform rk3368. On the other hand, the
> PMU/GRF/PMUGRF register file are mapped as "syscon", then referenced
> by other DT nodes by phandle. So maybe let it as a separate DT node
> here
> is better.
In that case you should probably implement a reboot notifier in each of
the drivers you list and depending on the generation of the SoC. You can
easily parameterize this by matching on the compatible string.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151119/16e5f3bc/attachment.sig>
next prev parent reply other threads:[~2015-11-19 12:56 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 9:47 [PATCH v3 0/5] Add reboot notifier driver for rockchip platform Andy Yan
2015-11-18 9:47 ` Andy Yan
2015-11-18 9:47 ` Andy Yan
2015-11-18 9:50 ` [PATCH v3 1/5] ARM: dts: rockchip: rk3288-veyron: rename pinctrl node reboot to reset Andy Yan
2015-11-18 9:50 ` Andy Yan
2015-11-18 14:18 ` Sergei Shtylyov
2015-11-18 14:18 ` Sergei Shtylyov
2015-11-19 0:51 ` Andy Yan
2015-11-18 9:53 ` [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot notifier driver Andy Yan
2015-11-18 9:53 ` Andy Yan
2015-11-18 22:59 ` Rob Herring
2015-11-18 22:59 ` Rob Herring
2015-11-18 22:59 ` Rob Herring
2015-11-19 1:17 ` Andy Yan
2015-11-19 1:17 ` Andy Yan
2015-11-19 1:17 ` Andy Yan
2015-11-19 4:35 ` Heiko Stuebner
2015-11-19 4:35 ` Heiko Stuebner
2015-11-19 4:35 ` Heiko Stuebner
2015-11-20 1:16 ` Andy Yan
2015-11-20 1:16 ` Andy Yan
2015-11-20 1:16 ` Andy Yan
2015-11-20 1:58 ` Rob Herring
2015-11-20 1:58 ` Rob Herring
2015-11-20 1:58 ` Rob Herring
2015-11-23 13:15 ` Andy Yan
2015-12-01 15:10 ` Andy Yan
2015-12-01 15:47 ` Heiko Stübner
2015-12-01 15:47 ` Heiko Stübner
2015-12-01 15:47 ` Heiko Stübner
2015-11-19 12:56 ` Thierry Reding [this message]
2015-11-19 12:56 ` Thierry Reding
2015-11-19 12:56 ` Thierry Reding
2015-11-19 13:39 ` Andy Yan
2015-11-19 15:30 ` Thierry Reding
2015-11-19 15:30 ` Thierry Reding
2015-11-19 15:30 ` Thierry Reding
2015-11-18 9:56 ` [PATCH v3 3/5] soc: rockchip: add " Andy Yan
2015-11-18 9:56 ` Andy Yan
2015-11-19 0:39 ` kbuild test robot
2015-11-19 0:39 ` kbuild test robot
2015-11-19 0:39 ` kbuild test robot
2015-12-14 11:39 ` Arnd Bergmann
2015-12-14 11:39 ` Arnd Bergmann
2015-12-14 11:39 ` Arnd Bergmann
2015-12-15 16:31 ` Thierry Reding
2015-12-15 16:31 ` Thierry Reding
2015-12-15 16:31 ` Thierry Reding
2015-12-15 16:34 ` Arnd Bergmann
2015-12-15 16:34 ` Arnd Bergmann
2015-12-15 16:34 ` Arnd Bergmann
2015-12-15 17:27 ` Heiko Stübner
2015-12-15 17:27 ` Heiko Stübner
2015-12-15 17:27 ` Heiko Stübner
2015-12-15 17:42 ` Thierry Reding
2015-12-15 17:42 ` Thierry Reding
2015-12-15 17:42 ` Thierry Reding
2015-12-15 20:38 ` Arnd Bergmann
2015-12-15 20:38 ` Arnd Bergmann
2015-12-15 20:38 ` Arnd Bergmann
2015-12-28 9:20 ` Thierry Reding
2015-12-28 9:20 ` Thierry Reding
2015-12-28 9:20 ` Thierry Reding
2015-12-28 15:35 ` Arnd Bergmann
2015-12-28 15:35 ` Arnd Bergmann
2015-12-28 15:35 ` Arnd Bergmann
2016-01-21 16:20 ` Thierry Reding
2016-01-21 16:20 ` Thierry Reding
2016-01-21 16:20 ` Thierry Reding
2015-11-18 10:00 ` [PATCH v3 4/5] ARM: dts: rockchip: add reboot node Andy Yan
2015-11-18 10:00 ` Andy Yan
2015-11-18 10:00 ` Andy Yan
2015-11-18 10:05 ` [PATCH v3 5/5] ARM64: " Andy Yan
2015-11-18 10:05 ` Andy Yan
2015-12-11 21:29 ` [PATCH v3 0/5] Add reboot notifier driver for rockchip platform Heiko Stübner
2015-12-11 21:29 ` Heiko Stübner
2015-12-11 21:29 ` Heiko Stübner
2015-12-14 10:30 ` Andy Yan
2015-12-14 10:30 ` Andy Yan
2015-12-14 10:30 ` Andy Yan
2015-12-17 1:16 ` John Stultz
2015-12-17 1:16 ` John Stultz
2015-12-17 1:16 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151119125643.GE21862@ulmo.nvidia.com \
--to=treding@nvidia.com \
--cc=andy.yan@rock-chips.com \
--cc=benchan@google.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=sjg@chromium.org \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.