Re: [PATCH v5 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()

From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Dinh Nguyen <dinh.linux@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	linux-mtd@lists.infradead.org, Andrew Lunn <andrew@lunn.ch>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	Tony Lindgren <tony@atomide.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Stefan Agner <stefan@agner.ch>,
	linux-sunxi@googlegroups.com,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Alexander Clouter <alex@digriz.org.uk>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	Jesper Nilsson <jesper.nilsson@axis.com>,
	linux-samsung-soc@vger.kernel.org,
	Maxim Levitsky <maximlevitsky@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Marek Vasut <marek.vasut@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
	Kukjin Kim <kgene@kernel.org>,
	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Dinh Nguyen <dinguyen@altera.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Jason Cooper <jason@lakedaemon.net>,
	Wan ZongShun <mcuos.com@gmail.com>,
	Steven Miao <realmz6@gmail.com>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Mikael Starvik <starvik@axis.com>,
	Krzysztof Halasa <khalasa@piap.pl>,
	Gregory CLEMENT <gregory.clement@free-electrons.com>,
	linux-omap@vger.kernel.org,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Ryan Mallon <rmallon@gmail.com>,
	linux-cris-kernel@axis.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linux List <linux-kernel@vger.kernel.org>,
	Hartley Sweeten <hsweeten@visionengravers.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Imre Kaloz <kaloz@openwrt.org>, Shawn Guo <shawnguo@kernel.org>,
	Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH v5 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()
Date: Fri, 11 Dec 2015 18:08:55 +0100	[thread overview]
Message-ID: <20151211180855.47c95df2@bbrezillon> (raw)
In-Reply-To: <CADhT+wcNFxD6Zv9w8W0sontVWa6zOkHjyK42Tw=Y_1X2XCTZfQ@mail.gmail.com>

Hi Dinh,

On Fri, 11 Dec 2015 10:50:21 -0600
Dinh Nguyen <dinh.linux@gmail.com> wrote:

> Hi Boris,
> 
> On Fri, Dec 11, 2015 at 9:10 AM, Boris Brezillon
> <boris.brezillon@free-electrons.com> wrote:
> > + Dinh (who made commit 2a0a288ec258)
> >
> > Also added back the Fixes tag.
> >
> > On Fri, 11 Dec 2015 15:02:34 +0100
> > Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> >
> >> Unregister the NAND device from the NAND subsystem when removing a denali
> >> NAND controller, otherwise the MTD attached to the NAND device is still
> >> exposed by the MTD layer, and accesses to this device will likely crash
> >> the system.
> >>
> >> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> >
> > Fixes: 2a0a288ec258 ("mtd: denali: split the generic driver and PCI layer")
> >
> >> ---
> >> Changes since v4:
> >> - remove Cc stable and fixes tags
> >> - calculate the dma buffer size before calling nand_release()
> >>
> >>  drivers/mtd/nand/denali.c | 6 ++++--
> >>  1 file changed, 4 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> >> index 67eb2be..fdfea05 100644
> >> --- a/drivers/mtd/nand/denali.c
> >> +++ b/drivers/mtd/nand/denali.c
> >> @@ -1622,9 +1622,11 @@ EXPORT_SYMBOL(denali_init);
> >>  /* driver exit point */
> >>  void denali_remove(struct denali_nand_info *denali)
> >>  {
> >> +     int bufsize = denali->mtd.writesize + denali->mtd.oobsize;
> >> +
> >> +     nand_release(&denali->mtd);
> >>       denali_irq_cleanup(denali->irq, denali);
> >> -     dma_unmap_single(denali->dev, denali->buf.dma_buf,
> >> -                      denali->mtd.writesize + denali->mtd.oobsize,
> >> +     dma_unmap_single(denali->dev, denali->buf.dma_buf, bufsize,
> >>                        DMA_BIDIRECTIONAL);
> 
> Not sure what is the need to add bufsize here, but the commit message
> doesn't reflect the change.

You were not in Cc of the first version (my fault), but Brian pointed
that the mtd fields could be in an unknown state after the
nand_release() call (this is currently not the case, but it change in
the future). The idea is to pre-compute the DMA buffer size before
releasing the mtd/nand device to prevent any future issues.

I don't think it is worth mentioning this in the commit message,
because these are just implementation details, but I can add the
following comment before the bufsize declaration:

	/*
	 * Pre-compute DMA buffer size to avoid any problems in case
	 * nand_release() ever changes in a way that mtd->writesize and
	 * mtd->oobsize are not reliable after this call.
	 */

What do you think?

Best Regards,

Boris

> 
> Dinh

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com