Re: [PATCH 5/5] ASoC: The soc card can have auxiliary components

From: Mark Brown <broonie@kernel.org>
To: Mengdong Lin <mengdong.lin@linux.intel.com>
Cc: alsa-devel@alsa-project.org, vinod.koul@intel.com,
	mengdong.lin@intel.com, liam.r.girdwood@linux.intel.com,
	jeeja.kp@intel.com, subhransu.s.prusty@intel.com
Subject: Re: [PATCH 5/5] ASoC: The soc card can have auxiliary components
Date: Fri, 11 Dec 2015 20:22:08 +0000	[thread overview]
Message-ID: <20151211202208.GS5727@sirena.org.uk> (raw)
In-Reply-To: <56694E6A.4090402@linux.intel.com>

[-- Attachment #1.1: Type: text/plain, Size: 1399 bytes --]

On Thu, Dec 10, 2015 at 06:05:30PM +0800, Mengdong Lin wrote:
> On 12/10/2015 04:38 AM, Mark Brown wrote:

> >OK, but I do think that's something we *should* be doing as part of the
> >overall move of CODECs to components and it's something that having this
> >change implies we should be doing as an immediate thing since it's the
> >more obvious direct use of the code (as Lars said in reply to the early
> >draft you posted IIRC).

> My early draft didn't use the aux components, so I'm not sure where to find
> Lars's comments on this idea.

He replied to some thing you posted by mistake and immediately
retracted.  Can't remember the subject, sorry.

> Please check if my understanding is right?

> I guess you want me to replace the "aux_dev" array from the struct
> snd_soc_card, by an "aux_components" array. And we may
> replace soc_bind_aux_dev() by soc_find_components(),
> replace soc_probe/remove_aux_dev() by soc_probe/remove_components.
> Probably soc_find/prove/remove_components need some adjustment for the the
> aux devices (DAIless codecs).

> And device driver of the these aux_dev need to use
> snd_soc_register_component() to make it as a component.

Yeah, pretty much.  I think we'll have a period where we support both
though as any CODEC *could* be used in this way and we're not ready for
that yet.

Let me have a look at converting some of the drivers over the weekend.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]