Re: [PATCH 5/5] ASoC: The soc card can have auxiliary components

From: Mark Brown <broonie@kernel.org>
To: Mengdong Lin <mengdong.lin@linux.intel.com>
Cc: alsa-devel@alsa-project.org, vinod.koul@intel.com,
	mengdong.lin@intel.com, liam.r.girdwood@linux.intel.com,
	jeeja.kp@intel.com, subhransu.s.prusty@intel.com
Subject: Re: [PATCH 5/5] ASoC: The soc card can have auxiliary components
Date: Fri, 18 Dec 2015 09:35:34 +0000	[thread overview]
Message-ID: <20151218093534.GX5727@sirena.org.uk> (raw)
In-Reply-To: <567121DC.5080601@linux.intel.com>

[-- Attachment #1.1: Type: text/plain, Size: 1285 bytes --]

On Wed, Dec 16, 2015 at 04:33:32PM +0800, Mengdong Lin wrote:
> On 12/15/2015 07:23 PM, Mark Brown wrote:

> >>2. Why we need the rtd array 'rtd_aux' for the aux_devs?
> >>    If the codec has DAIs and used by a DAI link, the ASoC will create a rtd
> >>for the link.

> >There are (or were at the time) assumptions in drivers that there will
> >be a rtd there so it was easier to provide a stub.

> Can we remove this rtd array if current driver does not need the stub?

If it's unneeded we should probably remove it.  As might be obvious by
now I've not yet had time to dig into the code, sorry.  I've got two
weeks of vacation after today though.

> For the replacement of aux_dev by aux_component, can we define like below?

> struct snd_soc_aux_component {
> 	const char *comp_name; ... no longer assume they're only codecs
> 	const char *comp_of_node;
> 
> 	/* machine specific init */
> 	int (*init)(struct snd_soc_component *componnent);
> };

> The ASoC can use the comp_name or comp_of_node to find the components and
> probe them.

Well, that's just the existing struct with a rename now I look at it -
init() already takes a component.  Given that can you not just have
whatever code was going to use this work with aux_devs as they are now?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]