From: Mark Brown <broonie@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: devicetree <devicetree@vger.kernel.org>,
alsa-devel@alsa-project.org, linux-sunxi@googlegroups.com,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] ASoC: sun4i-codec: Add support for PA gpio pin
Date: Sat, 12 Dec 2015 23:01:50 +0000 [thread overview]
Message-ID: <20151212230150.GH579@sirena.org.uk> (raw)
In-Reply-To: <1449859439-30875-2-git-send-email-hdegoede@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 304 bytes --]
On Fri, Dec 11, 2015 at 07:43:57PM +0100, Hans de Goede wrote:
> + gpiod_set_value_cansleep(scodec->gpio_pa,
> + !!SND_SOC_DAPM_EVENT_ON(event));
Why the double negation here? The macro is already supposed to give you
a boolean and gpiod_set_value_cansleep() ought to cope with a C logic
value.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] ASoC: sun4i-codec: Add support for PA gpio pin
Date: Sat, 12 Dec 2015 23:01:50 +0000 [thread overview]
Message-ID: <20151212230150.GH579@sirena.org.uk> (raw)
In-Reply-To: <1449859439-30875-2-git-send-email-hdegoede@redhat.com>
On Fri, Dec 11, 2015 at 07:43:57PM +0100, Hans de Goede wrote:
> + gpiod_set_value_cansleep(scodec->gpio_pa,
> + !!SND_SOC_DAPM_EVENT_ON(event));
Why the double negation here? The macro is already supposed to give you
a boolean and gpiod_set_value_cansleep() ought to cope with a C logic
value.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151212/59f039d3/attachment.sig>
next prev parent reply other threads:[~2015-12-12 23:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 18:43 [PATCH v2 1/4] ASoC: sun4i-codec: Rename codec dapm widgets and routes Hans de Goede
2015-12-11 18:43 ` Hans de Goede
2015-12-12 23:07 ` Applied "ASoC: sun4i-codec: Rename codec dapm widgets and routes" to the asoc tree Mark Brown
[not found] ` <1449859439-30875-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-11 18:43 ` [PATCH v2 2/4] ASoC: sun4i-codec: Add support for PA gpio pin Hans de Goede
2015-12-11 18:43 ` Hans de Goede
2015-12-12 23:01 ` Mark Brown [this message]
2015-12-12 23:01 ` Mark Brown
2015-12-12 23:07 ` Applied "ASoC: sun4i-codec: Add support for PA gpio pin" to the asoc tree Mark Brown
[not found] ` <1449859439-30875-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-14 1:11 ` [PATCH v2 2/4] ASoC: sun4i-codec: Add support for PA gpio pin Rob Herring
2015-12-14 1:11 ` Rob Herring
2015-12-14 15:56 ` Maxime Ripard
2015-12-14 15:56 ` Maxime Ripard
2015-12-14 16:07 ` [linux-sunxi] " Hans de Goede
2015-12-14 16:07 ` Hans de Goede
[not found] ` <566EE953.3050702-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-18 20:53 ` Maxime Ripard
2015-12-18 20:53 ` [linux-sunxi] " Maxime Ripard
2015-12-11 18:43 ` [PATCH v2 3/4] ARM: dts: sun5i: Enable onboard codec used on the UTOO P66 tablet Hans de Goede
2015-12-11 18:43 ` Hans de Goede
2015-12-11 18:43 ` [PATCH v2 4/4] ARM: dts: sun4i: Enable onboard codec used on the pov protab2-ips9 tablet Hans de Goede
2015-12-11 18:43 ` Hans de Goede
[not found] ` <1449859439-30875-4-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-18 21:19 ` Maxime Ripard
2015-12-18 21:19 ` Maxime Ripard
2015-12-14 9:44 ` [PATCH v2 1/4] ASoC: sun4i-codec: Rename codec dapm widgets and routes Maxime Ripard
2015-12-14 9:44 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151212230150.GH579@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.