From: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v4 05/10] xprtrdma: Introduce ro_unmap_sync method
Date: Wed, 16 Dec 2015 17:22:39 -0500 [thread overview]
Message-ID: <20151216222239.13110.47065.stgit@manet.1015granger.net> (raw)
In-Reply-To: <20151216221444.13110.43538.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
In the current xprtrdma implementation, some memreg strategies
implement ro_unmap synchronously (the MR is knocked down before the
method returns) and some asynchonously (the MR will be knocked down
and returned to the pool in the background).
To guarantee the MR is truly invalid before the RPC consumer is
allowed to resume execution, we need an unmap method that is
always synchronous, invoked from the RPC/RDMA reply handler.
The new method unmaps all MRs for an RPC. The existing ro_unmap
method unmaps only one MR at a time.
Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Tested-by: Devesh Sharma <devesh.sharma-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org>
---
net/sunrpc/xprtrdma/xprt_rdma.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h
index b1065ca..512184d 100644
--- a/net/sunrpc/xprtrdma/xprt_rdma.h
+++ b/net/sunrpc/xprtrdma/xprt_rdma.h
@@ -367,6 +367,8 @@ struct rpcrdma_xprt;
struct rpcrdma_memreg_ops {
int (*ro_map)(struct rpcrdma_xprt *,
struct rpcrdma_mr_seg *, int, bool);
+ void (*ro_unmap_sync)(struct rpcrdma_xprt *,
+ struct rpcrdma_req *);
int (*ro_unmap)(struct rpcrdma_xprt *,
struct rpcrdma_mr_seg *);
int (*ro_open)(struct rpcrdma_ia *,
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Chuck Lever <chuck.lever@oracle.com>
To: anna.schumaker@netapp.com
Cc: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [PATCH v4 05/10] xprtrdma: Introduce ro_unmap_sync method
Date: Wed, 16 Dec 2015 17:22:39 -0500 [thread overview]
Message-ID: <20151216222239.13110.47065.stgit@manet.1015granger.net> (raw)
In-Reply-To: <20151216221444.13110.43538.stgit@manet.1015granger.net>
In the current xprtrdma implementation, some memreg strategies
implement ro_unmap synchronously (the MR is knocked down before the
method returns) and some asynchonously (the MR will be knocked down
and returned to the pool in the background).
To guarantee the MR is truly invalid before the RPC consumer is
allowed to resume execution, we need an unmap method that is
always synchronous, invoked from the RPC/RDMA reply handler.
The new method unmaps all MRs for an RPC. The existing ro_unmap
method unmaps only one MR at a time.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Tested-by: Devesh Sharma <devesh.sharma@avagotech.com>
---
net/sunrpc/xprtrdma/xprt_rdma.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h
index b1065ca..512184d 100644
--- a/net/sunrpc/xprtrdma/xprt_rdma.h
+++ b/net/sunrpc/xprtrdma/xprt_rdma.h
@@ -367,6 +367,8 @@ struct rpcrdma_xprt;
struct rpcrdma_memreg_ops {
int (*ro_map)(struct rpcrdma_xprt *,
struct rpcrdma_mr_seg *, int, bool);
+ void (*ro_unmap_sync)(struct rpcrdma_xprt *,
+ struct rpcrdma_req *);
int (*ro_unmap)(struct rpcrdma_xprt *,
struct rpcrdma_mr_seg *);
int (*ro_open)(struct rpcrdma_ia *,
next prev parent reply other threads:[~2015-12-16 22:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 22:21 [PATCH v4 00/10] NFS/RDMA client patches for 4.5 Chuck Lever
2015-12-16 22:21 ` Chuck Lever
[not found] ` <20151216221444.13110.43538.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2015-12-16 22:22 ` [PATCH v4 01/10] xprtrdma: Fix additional uses of spin_lock_irqsave(rb_lock) Chuck Lever
2015-12-16 22:22 ` Chuck Lever
2015-12-16 22:22 ` [PATCH v4 02/10] xprtrdma: xprt_rdma_free() must not release backchannel reqs Chuck Lever
2015-12-16 22:22 ` Chuck Lever
2015-12-16 22:22 ` [PATCH v4 03/10] xprtrdma: Disable RPC/RDMA backchannel debugging messages Chuck Lever
2015-12-16 22:22 ` Chuck Lever
2015-12-16 22:22 ` [PATCH v4 04/10] xprtrdma: Move struct ib_send_wr off the stack Chuck Lever
2015-12-16 22:22 ` Chuck Lever
2015-12-16 22:22 ` Chuck Lever [this message]
2015-12-16 22:22 ` [PATCH v4 05/10] xprtrdma: Introduce ro_unmap_sync method Chuck Lever
2015-12-16 22:22 ` [PATCH v4 06/10] xprtrdma: Add ro_unmap_sync method for FRWR Chuck Lever
2015-12-16 22:22 ` Chuck Lever
2015-12-16 22:22 ` [PATCH v4 07/10] xprtrdma: Add ro_unmap_sync method for FMR Chuck Lever
2015-12-16 22:22 ` Chuck Lever
2015-12-16 22:23 ` [PATCH v4 08/10] xprtrdma: Add ro_unmap_sync method for all-physical registration Chuck Lever
2015-12-16 22:23 ` Chuck Lever
2015-12-16 22:23 ` [PATCH v4 09/10] xprtrdma: Invalidate in the RPC reply handler Chuck Lever
2015-12-16 22:23 ` Chuck Lever
2015-12-16 22:23 ` [PATCH v4 10/10] xprtrdma: Revert commit e7104a2a9606 ('xprtrdma: Cap req_cqinit') Chuck Lever
2015-12-16 22:23 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151216222239.13110.47065.stgit@manet.1015granger.net \
--to=chuck.lever-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.