From: Mark Brown <broonie@kernel.org>
To: Caesar Wang <wxt@rock-chips.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org, leozwang@google.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, keescook@google.com,
Sonny Rao <sonnyrao@chromium.org>,
Jianqun Xu <jay.xu@rock-chips.com>
Subject: Re: [PATCH v3 3/9] ASoC: rockchip: i2s: add support for grabbing output clock to codec
Date: Fri, 15 Jan 2016 17:46:23 +0000 [thread overview]
Message-ID: <20160115174623.GZ6588@sirena.org.uk> (raw)
In-Reply-To: <1452865796-23527-4-git-send-email-wxt@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
On Fri, Jan 15, 2016 at 09:49:50PM +0800, Caesar Wang wrote:
> We need to claim the clock which is driving the codec so that when we
> enable clock gating, we continue to clock the codec when needed.
> I make this an optional clock since there might be some applications
> where we don't need it but can still use the I2S block.
> - As the perious discuss on https://patchwork.kernel.org/patch/5427131/,
> I think Mark likes do it in codec driver, I have to say I agree this
> patch in here since that's the i2s block output. I don't know if the
> Mark has changed his mind.
If the I2S block is providing a clock to the CODEC then that's what the
software should do so that the CODEC can gate and ungate the clock as
required. This patch has the I2S block using a clock, not providing
one.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/9] ASoC: rockchip: i2s: add support for grabbing output clock to codec
Date: Fri, 15 Jan 2016 17:46:23 +0000 [thread overview]
Message-ID: <20160115174623.GZ6588@sirena.org.uk> (raw)
In-Reply-To: <1452865796-23527-4-git-send-email-wxt@rock-chips.com>
On Fri, Jan 15, 2016 at 09:49:50PM +0800, Caesar Wang wrote:
> We need to claim the clock which is driving the codec so that when we
> enable clock gating, we continue to clock the codec when needed.
> I make this an optional clock since there might be some applications
> where we don't need it but can still use the I2S block.
> - As the perious discuss on https://patchwork.kernel.org/patch/5427131/,
> I think Mark likes do it in codec driver, I have to say I agree this
> patch in here since that's the i2s block output. I don't know if the
> Mark has changed his mind.
If the I2S block is providing a clock to the CODEC then that's what the
software should do so that the CODEC can gate and ungate the clock as
required. This patch has the I2S block using a clock, not providing
one.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160115/6c8b1525/attachment.sig>
next prev parent reply other threads:[~2016-01-15 17:46 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 13:49 [PATCH v3 0/9] Add the family patches to support for kylin board Caesar Wang
2016-01-15 13:49 ` Caesar Wang
2016-01-15 13:49 ` [PATCH v3 1/9] ARM: dts: rockchip: add hdmi/vop device node for rk3036 Caesar Wang
2016-01-15 13:49 ` Caesar Wang
2016-01-15 13:49 ` [PATCH v3 2/9] ARM: dts: rockchip: add i2s_clk_out to list of clocks used on rk3036 i2s Caesar Wang
2016-01-15 13:49 ` Caesar Wang
2016-01-15 13:49 ` Caesar Wang
2016-01-15 13:49 ` [PATCH v3 3/9] ASoC: rockchip: i2s: add support for grabbing output clock to codec Caesar Wang
2016-01-15 13:49 ` Caesar Wang
2016-01-15 17:46 ` Mark Brown [this message]
2016-01-15 17:46 ` Mark Brown
2016-01-15 21:48 ` Sonny Rao
2016-01-15 21:48 ` Sonny Rao
2016-01-15 21:48 ` Sonny Rao
2016-01-22 17:18 ` Mark Brown
2016-01-22 17:18 ` Mark Brown
2016-01-22 17:18 ` Mark Brown
2016-01-25 1:15 ` Jianqun Xu
2016-01-25 1:15 ` Jianqun Xu
2016-01-25 1:15 ` Jianqun Xu
2016-01-26 9:52 ` Heiko Stübner
2016-01-26 9:52 ` Heiko Stübner
2016-01-26 9:52 ` Heiko Stübner
2016-01-27 12:47 ` Mark Brown
2016-01-27 12:47 ` Mark Brown
2016-01-27 12:47 ` Mark Brown
2016-01-15 13:49 ` [PATCH v3 4/9] ARM: dts: rockchip: enable the uart0 for kylin board Caesar Wang
2016-01-15 13:49 ` Caesar Wang
2016-01-17 19:23 ` Heiko Stuebner
2016-01-17 19:23 ` Heiko Stuebner
2016-01-15 13:49 ` [PATCH v3 5/9] ARM: dts: rockchip: enable the high speed on sdio " Caesar Wang
2016-01-15 13:49 ` Caesar Wang
2016-01-17 19:26 ` Heiko Stuebner
2016-01-17 19:26 ` Heiko Stuebner
2016-01-15 13:49 ` [PATCH v3 6/9] ARM: dts: rockchip: add the sdio power sequence " Caesar Wang
2016-01-15 13:49 ` Caesar Wang
2016-01-17 19:31 ` Heiko Stuebner
2016-01-17 19:31 ` Heiko Stuebner
2016-01-15 13:49 ` [PATCH v3 7/9] ARM: dts: rockchip: add the sdmmc " Caesar Wang
2016-01-15 13:49 ` Caesar Wang
2016-01-15 13:49 ` Caesar Wang
2016-01-17 19:37 ` Heiko Stuebner
2016-01-17 19:37 ` Heiko Stuebner
2016-01-15 13:49 ` [PATCH v3 8/9] ARM: dts: rockchip: add reboot-mode node for rk3036 SoCs Caesar Wang
2016-01-15 13:49 ` Caesar Wang
2016-01-17 19:18 ` Heiko Stuebner
2016-01-17 19:18 ` Heiko Stuebner
2016-01-17 19:18 ` Heiko Stuebner
2016-01-18 1:11 ` Andy Yan
2016-01-18 1:11 ` Andy Yan
2016-01-18 1:11 ` Andy Yan
2016-01-15 13:49 ` [PATCH v3 9/9] ARM: dts: rockchip: add pl330-broken-no-flushp quirk " Caesar Wang
2016-01-15 13:49 ` Caesar Wang
2016-01-17 19:20 ` Heiko Stuebner
2016-01-17 19:20 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115174623.GZ6588@sirena.org.uk \
--to=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=jay.xu@rock-chips.com \
--cc=keescook@google.com \
--cc=leozwang@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=sonnyrao@chromium.org \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.