Re: [Qemu-devel] [PATCHv4 0/8] Cleanups to error reporting on ppc and spapr

From: David Gibson <david@gibson.dropbear.id.au>
To: Markus Armbruster <armbru@redhat.com>
Cc: lvivier@redhat.com, thuth@redhat.com, aik@ozlabs.ru,
	mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org,
	qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv4 0/8] Cleanups to error reporting on ppc and spapr
Date: Wed, 20 Jan 2016 12:59:34 +1100	[thread overview]
Message-ID: <20160120015934.GG27454@voom.redhat.com> (raw)
In-Reply-To: <87oachep1q.fsf@blackfin.pond.sub.org>

[-- Attachment #1: Type: text/plain, Size: 1881 bytes --]

On Tue, Jan 19, 2016 at 01:23:13PM +0100, Markus Armbruster wrote:
> David Gibson <david@gibson.dropbear.id.au> writes:
> 
> > Another spin of my patches to clean up a bunch of error reporting in
> > the pseries machine type and target-ppc code, to better use the error
> > API.
> >
> > Once reviewed, I hope to merge this into ppc-for-2.6 shortly.
> 
> Thanks for helping with error cleanup.
> 
> > Changes in v4:
> >  * Corrected a place I'd accidentally messed up the indenting
> >  * Dropped the patch changing the htab allocation path and some hunks
> >    of the migration path cleanups, since they will be obsoleted by
> >    other things I'm working on
> > Changes in v3:
> >  * Adjusted a commit message for accuracy (suggest by Markus)
> >  * Dropped a patch which relied on a wrong guess about the behaviour
> >    of foreach_dynamic_sysbus_device().
> > Changes in v2:
> >  * Assorted minor tweaks based on review
> >       
> > David Gibson (8):
> >   ppc: Cleanup error handling in ppc_set_compat()
> >   pseries: Cleanup error handling of spapr_cpu_init()
> >   pseries: Clean up error handling in spapr_validate_node_memory()
> >   pseries: Cleanup error handling in spapr_vga_init()
> >   pseries: Clean up error handling in spapr_rtas_register()
> >   pseries: Clean up error handling in xics_system_init()
> >   pseries: Clean up error reporting in ppc_spapr_init()
> >   pseries: Clean up error reporting in htab migration functions
> 
> I think the two "Cleanup" should be spelled "Clean up".
> 
> Series
> Reviewed-by: Markus Armbruster <armbru@redhat.com>

Thanks I'll make that trivial change and fold into ppc-for-2.6.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]