Re: [Qemu-devel] [PATCHv4 8/8] pseries: Clean up error reporting in htab migration functions

From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: David Gibson <david@gibson.dropbear.id.au>,
	armbru@redhat.com, mdroth@linux.vnet.ibm.com
Cc: lvivier@redhat.com, thuth@redhat.com, qemu-ppc@nongnu.org,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv4 8/8] pseries: Clean up error reporting in htab migration functions
Date: Tue, 19 Jan 2016 15:31:14 +1100	[thread overview]
Message-ID: <569DBC12.1050406@ozlabs.ru> (raw)
In-Reply-To: <1453174759-22837-9-git-send-email-david@gibson.dropbear.id.au>

On 01/19/2016 02:39 PM, David Gibson wrote:
> The functions for migrating the hash page table on pseries machine type
> (htab_save_setup() and htab_load()) can report some errors with an
> explicit fprintf() before returning an appropriate error code.  Change these
> to use error_report() instead.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> Reviewed-by: Thomas Huth <thuth@redhat.com>


Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>	

> ---
>   hw/ppc/spapr.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 3cfacb9..1eb7d03 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -1526,7 +1526,7 @@ static int htab_load(QEMUFile *f, void *opaque, int version_id)
>       int fd = -1;
>
>       if (version_id < 1 || version_id > 1) {
> -        fprintf(stderr, "htab_load() bad version\n");
> +        error_report("htab_load() bad version");
>           return -EINVAL;
>       }
>
> @@ -1547,8 +1547,8 @@ static int htab_load(QEMUFile *f, void *opaque, int version_id)
>
>           fd = kvmppc_get_htab_fd(true);
>           if (fd < 0) {
> -            fprintf(stderr, "Unable to open fd to restore KVM hash table: %s\n",
> -                    strerror(errno));
> +            error_report("Unable to open fd to restore KVM hash table: %s",
> +                         strerror(errno));
>           }
>       }
>
> @@ -1568,9 +1568,9 @@ static int htab_load(QEMUFile *f, void *opaque, int version_id)
>           if ((index + n_valid + n_invalid) >
>               (HTAB_SIZE(spapr) / HASH_PTE_SIZE_64)) {
>               /* Bad index in stream */
> -            fprintf(stderr, "htab_load() bad index %d (%hd+%hd entries) "
> -                    "in htab stream (htab_shift=%d)\n", index, n_valid, n_invalid,
> -                    spapr->htab_shift);
> +            error_report(
> +                "htab_load() bad index %d (%hd+%hd entries) in htab stream (htab_shift=%d)",
> +                index, n_valid, n_invalid, spapr->htab_shift);
>               return -EINVAL;
>           }
>
>


-- 
Alexey