From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: Dmitry Monakhov <dmonakhov@openvz.org>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
Theodore Ts'o <tytso@mit.edu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Dave Chinner <david@fromorbit.com>,
Ingo Molnar <mingo@redhat.com>, Jan Kara <jack@suse.com>,
Jeff Layton <jlayton@poochiereds.net>,
Matthew Wilcox <willy@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-ext4 <linux-ext4@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
X86 ML <x86@kernel.org>, XFS Developers <xfs@oss.sgi.com>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH] dax: dirty inode only if required
Date: Thu, 4 Feb 2016 08:50:39 -0700 [thread overview]
Message-ID: <20160204155039.GA17818@linux.intel.com> (raw)
In-Reply-To: <20160204143344.GA6895@quack.suse.cz>
On Thu, Feb 04, 2016 at 03:33:44PM +0100, Jan Kara wrote:
> On Thu 04-02-16 17:02:02, Dmitry Monakhov wrote:
> >
> > Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
>
> Makes sense. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Looks good to me as well.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Honza
> > ---
> > fs/dax.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/dax.c b/fs/dax.c
> > index e0e9358..fc2e314 100644
> > --- a/fs/dax.c
> > +++ b/fs/dax.c
> > @@ -358,7 +358,8 @@ static int dax_radix_entry(struct address_space *mapping, pgoff_t index,
> > void *entry;
> >
> > WARN_ON_ONCE(pmd_entry && !dirty);
> > - __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
> > + if (dirty)
> > + __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
> >
> > spin_lock_irq(&mapping->tree_lock);
> >
> > --
> > 1.8.3.1
> >
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: Dmitry Monakhov <dmonakhov@openvz.org>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
"Theodore Ts'o" <tytso@mit.edu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Dave Chinner <david@fromorbit.com>,
Ingo Molnar <mingo@redhat.com>, Jan Kara <jack@suse.com>,
Jeff Layton <jlayton@poochiereds.net>,
Matthew Wilcox <willy@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-ext4 <linux-ext4@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
X86 ML <x86@kernel.org>, XFS Developers <xfs@oss.sgi.com>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH] dax: dirty inode only if required
Date: Thu, 4 Feb 2016 08:50:39 -0700 [thread overview]
Message-ID: <20160204155039.GA17818@linux.intel.com> (raw)
In-Reply-To: <20160204143344.GA6895@quack.suse.cz>
On Thu, Feb 04, 2016 at 03:33:44PM +0100, Jan Kara wrote:
> On Thu 04-02-16 17:02:02, Dmitry Monakhov wrote:
> >
> > Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
>
> Makes sense. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Looks good to me as well.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Honza
> > ---
> > fs/dax.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/dax.c b/fs/dax.c
> > index e0e9358..fc2e314 100644
> > --- a/fs/dax.c
> > +++ b/fs/dax.c
> > @@ -358,7 +358,8 @@ static int dax_radix_entry(struct address_space *mapping, pgoff_t index,
> > void *entry;
> >
> > WARN_ON_ONCE(pmd_entry && !dirty);
> > - __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
> > + if (dirty)
> > + __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
> >
> > spin_lock_irq(&mapping->tree_lock);
> >
> > --
> > 1.8.3.1
> >
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: Dmitry Monakhov <dmonakhov@openvz.org>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
Theodore Ts'o <tytso@mit.edu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Dave Chinner <david@fromorbit.com>,
Ingo Molnar <mingo@redhat.com>, Jan Kara <jack@suse.com>,
Jeff Layton <jlayton@poochiereds.net>,
Matthew Wilcox <willy@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-ext4 <linux-ext4@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
X86 ML <x86@kernel.org>, XFS Developers <xfs@oss.sgi.com>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
Da
Subject: Re: [PATCH] dax: dirty inode only if required
Date: Thu, 4 Feb 2016 08:50:39 -0700 [thread overview]
Message-ID: <20160204155039.GA17818@linux.intel.com> (raw)
In-Reply-To: <20160204143344.GA6895@quack.suse.cz>
On Thu, Feb 04, 2016 at 03:33:44PM +0100, Jan Kara wrote:
> On Thu 04-02-16 17:02:02, Dmitry Monakhov wrote:
> >
> > Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
>
> Makes sense. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Looks good to me as well.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Honza
> > ---
> > fs/dax.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/dax.c b/fs/dax.c
> > index e0e9358..fc2e314 100644
> > --- a/fs/dax.c
> > +++ b/fs/dax.c
> > @@ -358,7 +358,8 @@ static int dax_radix_entry(struct address_space *mapping, pgoff_t index,
> > void *entry;
> >
> > WARN_ON_ONCE(pmd_entry && !dirty);
> > - __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
> > + if (dirty)
> > + __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
> >
> > spin_lock_irq(&mapping->tree_lock);
> >
> > --
> > 1.8.3.1
> >
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
Linux MM <linux-mm@kvack.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
"H. Peter Anvin" <hpa@zytor.com>,
Jeff Layton <jlayton@poochiereds.net>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
X86 ML <x86@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Matthew Wilcox <willy@linux.intel.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-ext4 <linux-ext4@vger.kernel.org>,
XFS Developers <xfs@oss.sgi.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Theodore Ts'o <tytso@mit.edu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dmitry Monakhov <dmonakhov@openvz.org>, Jan Kara <jack@suse.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <matthew.r.wilcox@intel.com>
Subject: Re: [PATCH] dax: dirty inode only if required
Date: Thu, 4 Feb 2016 08:50:39 -0700 [thread overview]
Message-ID: <20160204155039.GA17818@linux.intel.com> (raw)
In-Reply-To: <20160204143344.GA6895@quack.suse.cz>
On Thu, Feb 04, 2016 at 03:33:44PM +0100, Jan Kara wrote:
> On Thu 04-02-16 17:02:02, Dmitry Monakhov wrote:
> >
> > Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
>
> Makes sense. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Looks good to me as well.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Honza
> > ---
> > fs/dax.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/dax.c b/fs/dax.c
> > index e0e9358..fc2e314 100644
> > --- a/fs/dax.c
> > +++ b/fs/dax.c
> > @@ -358,7 +358,8 @@ static int dax_radix_entry(struct address_space *mapping, pgoff_t index,
> > void *entry;
> >
> > WARN_ON_ONCE(pmd_entry && !dirty);
> > - __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
> > + if (dirty)
> > + __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
> >
> > spin_lock_irq(&mapping->tree_lock);
> >
> > --
> > 1.8.3.1
> >
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-04 15:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 14:02 [PATCH] dax: dirty inode only if required Dmitry Monakhov
2016-02-04 14:02 ` Dmitry Monakhov
2016-02-04 14:02 ` Dmitry Monakhov
2016-02-04 14:02 ` Dmitry Monakhov
2016-02-04 14:33 ` Jan Kara
2016-02-04 14:33 ` Jan Kara
2016-02-04 14:33 ` Jan Kara
2016-02-04 14:33 ` Jan Kara
2016-02-04 15:50 ` Ross Zwisler [this message]
2016-02-04 15:50 ` Ross Zwisler
2016-02-04 15:50 ` Ross Zwisler
2016-02-04 15:50 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204155039.GA17818@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=dave.hansen@linux.intel.com \
--cc=david@fromorbit.com \
--cc=dmonakhov@openvz.org \
--cc=hpa@zytor.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=jlayton@poochiereds.net \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=matthew.r.wilcox@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@linux.intel.com \
--cc=x86@kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.