From: Borislav Petkov <bp@alien8.de>
To: Thor Thayer <tthayer@opensource.altera.com>
Cc: dougthompson@xmission.com, m.chehab@samsung.com,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk, dinguyen@opensource.altera.com,
grant.likely@linaro.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, tthayer.linux@gmail.com
Subject: Re: [PATCHv9 1/4] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC Support
Date: Mon, 8 Feb 2016 17:16:27 +0100 [thread overview]
Message-ID: <20160208161627.GH28980@pd.tnic> (raw)
In-Reply-To: <56B8BE0D.8070000@opensource.altera.com>
On Mon, Feb 08, 2016 at 10:10:53AM -0600, Thor Thayer wrote:
> Understood. I did get a conditional ACK from Rob Herring on the DT portion
> of the patch from the last revision (as long as I made the changes he
> suggested which I did in this patch). There may be other comments though.
Ah, and I wasn't precise: there are also arch/arm/mach-socfpga/ changes
which I'm going to take through the EDAC tree *only* if ARM people ack
them.
And by "ARM people" and from looking at get_maintainer output I mean
Dinh and he's on CC ...
> Those are the only cases of irq but it would be good to be alerted if that
> is not the case. I will add. Thanks!
Yeah, it is a "just in case" thing - it might just as well be too
cautious and completely unnecessary so your decision.
> Yes, thanks. I was using the xgene code as an example but I missed the
> unregister (although it looks like the xgene's unregister affects sysfs
> instead of debugfs). I'm also moving the debugfs creation to the end of the
> probe since it is not critical and avoids an error path if creation fails.
>
> I'll make the debugfs_remove_recursive() change as a separate patch in my
> next version.
Good, thanks!
Also, if something's not right in drivers/edac/debugfs.c wrt usability
and so on, feel free to propose changes. I've extracted it there because
I didn't want every driver to reinvent the wheel.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
WARNING: multiple messages have this Message-ID (diff)
From: bp@alien8.de (Borislav Petkov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv9 1/4] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC Support
Date: Mon, 8 Feb 2016 17:16:27 +0100 [thread overview]
Message-ID: <20160208161627.GH28980@pd.tnic> (raw)
In-Reply-To: <56B8BE0D.8070000@opensource.altera.com>
On Mon, Feb 08, 2016 at 10:10:53AM -0600, Thor Thayer wrote:
> Understood. I did get a conditional ACK from Rob Herring on the DT portion
> of the patch from the last revision (as long as I made the changes he
> suggested which I did in this patch). There may be other comments though.
Ah, and I wasn't precise: there are also arch/arm/mach-socfpga/ changes
which I'm going to take through the EDAC tree *only* if ARM people ack
them.
And by "ARM people" and from looking at get_maintainer output I mean
Dinh and he's on CC ...
> Those are the only cases of irq but it would be good to be alerted if that
> is not the case. I will add. Thanks!
Yeah, it is a "just in case" thing - it might just as well be too
cautious and completely unnecessary so your decision.
> Yes, thanks. I was using the xgene code as an example but I missed the
> unregister (although it looks like the xgene's unregister affects sysfs
> instead of debugfs). I'm also moving the debugfs creation to the end of the
> probe since it is not critical and avoids an error path if creation fails.
>
> I'll make the debugfs_remove_recursive() change as a separate patch in my
> next version.
Good, thanks!
Also, if something's not right in drivers/edac/debugfs.c wrt usability
and so on, feel free to propose changes. I've extracted it there because
I didn't want every driver to reinvent the wheel.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-02-08 16:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 16:13 [PATCHv9 1/4] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC Support tthayer
2016-01-27 16:13 ` tthayer at opensource.altera.com
2016-01-27 16:13 ` tthayer
2016-01-27 16:13 ` [PATCHv9 2/4] ARM: dts: Add Altera L2 Cache and OCRAM EDAC entries tthayer
2016-01-27 16:13 ` tthayer at opensource.altera.com
2016-01-27 16:13 ` tthayer
2016-01-27 16:13 ` [PATCHv9 3/4] ARM: socfpga: enable L2 cache ECC on startup tthayer
2016-01-27 16:13 ` tthayer at opensource.altera.com
2016-01-27 16:13 ` tthayer
2016-02-08 19:00 ` Dinh Nguyen
2016-02-08 19:00 ` Dinh Nguyen
2016-02-08 19:00 ` Dinh Nguyen
2016-01-27 16:13 ` [PATCHv9 4/4] ARM: socfpga: Enable OCRAM " tthayer
2016-01-27 16:13 ` tthayer at opensource.altera.com
2016-01-27 16:13 ` tthayer
2016-02-08 19:02 ` Dinh Nguyen
2016-02-08 19:02 ` Dinh Nguyen
2016-02-08 19:02 ` Dinh Nguyen
2016-02-08 11:39 ` [PATCHv9 1/4] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC Support Borislav Petkov
2016-02-08 11:39 ` Borislav Petkov
2016-02-08 16:10 ` Thor Thayer
2016-02-08 16:10 ` Thor Thayer
2016-02-08 16:10 ` Thor Thayer
2016-02-08 16:16 ` Borislav Petkov [this message]
2016-02-08 16:16 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208161627.GH28980@pd.tnic \
--to=bp@alien8.de \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=dougthompson@xmission.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.chehab@samsung.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tthayer.linux@gmail.com \
--cc=tthayer@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.