From: Rob Herring <robh@kernel.org>
To: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@arm.linux.org.uk>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Jonathan Richardson <jonathar@broadcom.com>,
Jon Mason <jonmason@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 1/3] input: cygnus-update touchscreen dt node document
Date: Fri, 12 Feb 2016 09:04:30 -0600 [thread overview]
Message-ID: <20160212150430.GA15049@rob-hp-laptop> (raw)
In-Reply-To: <979fb4dc5fba643a6780759d2a13530a@mail.gmail.com>
Your mailer is not handling wrapping correctly. Generally, Outlook does
not work for maillists.
On Wed, Feb 10, 2016 at 10:24:43AM +0530, Raveendra Padasalagi wrote:
> > -----Original Message-----
> > From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
> > Sent: 09 February 2016 23:14
> > To: Raveendra Padasalagi
> > Cc: Arnd Bergmann; Russell King; devicetree@vger.kernel.org; linux-arm-
> > kernel@lists.infradead.org; linux-input@vger.kernel.org; Rob Herring;
> Pawel
> > Moll; Mark Rutland; Ian Campbell; Kumar Gala; Jonathan Richardson; Jon
> > Mason; Florian Fainelli; Ray Jui; Scott Branden;
> linux-kernel@vger.kernel.org;
> > bcm-kernel-feedback-list@broadcom.com
> > Subject: Re: [PATCH 1/3] input: cygnus-update touchscreen dt node
> document
And Outlook's reply header is non-standard.
[...]
> > > In Cygnus SOC, Touch screen controller registers are shared with ADC
> > > and flex timer IP's.
> > > Using readl/writel could lead to race condition. So this patch is
> > > introduced to take care mutually exclusive access of register's in
> > > such a case.
> > >
> > > In the platform's where touchscreen register's are not shared normal
> > > readl/writel could be used.
> >
> > Are there currently platforms where the registers are not shared? If we
> have to
> > use regmap to correctly update registers (and thus we need
> > syscon) then I wonder if we should even attempt to support direct
> register
> > access by the driver.
>
> Currently there are no platforms without register sharing, but we would
> like to keep
> the driver generic enough to take care of future SOC's if comes with
> dedicated registers
> and same touchscreen IP being re-used.
These future SoCs will have a different compatible string and you should
use that to determine whether reg or syscon is used.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] input: cygnus-update touchscreen dt node document
Date: Fri, 12 Feb 2016 09:04:30 -0600 [thread overview]
Message-ID: <20160212150430.GA15049@rob-hp-laptop> (raw)
In-Reply-To: <979fb4dc5fba643a6780759d2a13530a@mail.gmail.com>
Your mailer is not handling wrapping correctly. Generally, Outlook does
not work for maillists.
On Wed, Feb 10, 2016 at 10:24:43AM +0530, Raveendra Padasalagi wrote:
> > -----Original Message-----
> > From: Dmitry Torokhov [mailto:dmitry.torokhov at gmail.com]
> > Sent: 09 February 2016 23:14
> > To: Raveendra Padasalagi
> > Cc: Arnd Bergmann; Russell King; devicetree at vger.kernel.org; linux-arm-
> > kernel at lists.infradead.org; linux-input at vger.kernel.org; Rob Herring;
> Pawel
> > Moll; Mark Rutland; Ian Campbell; Kumar Gala; Jonathan Richardson; Jon
> > Mason; Florian Fainelli; Ray Jui; Scott Branden;
> linux-kernel at vger.kernel.org;
> > bcm-kernel-feedback-list at broadcom.com
> > Subject: Re: [PATCH 1/3] input: cygnus-update touchscreen dt node
> document
And Outlook's reply header is non-standard.
[...]
> > > In Cygnus SOC, Touch screen controller registers are shared with ADC
> > > and flex timer IP's.
> > > Using readl/writel could lead to race condition. So this patch is
> > > introduced to take care mutually exclusive access of register's in
> > > such a case.
> > >
> > > In the platform's where touchscreen register's are not shared normal
> > > readl/writel could be used.
> >
> > Are there currently platforms where the registers are not shared? If we
> have to
> > use regmap to correctly update registers (and thus we need
> > syscon) then I wonder if we should even attempt to support direct
> register
> > access by the driver.
>
> Currently there are no platforms without register sharing, but we would
> like to keep
> the driver generic enough to take care of future SOC's if comes with
> dedicated registers
> and same touchscreen IP being re-used.
These future SoCs will have a different compatible string and you should
use that to determine whether reg or syscon is used.
Rob
next prev parent reply other threads:[~2016-02-12 15:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 8:57 [PATCH 0/3] Syscon support for iProc touchscreen driver Raveendra Padasalagi
2016-02-09 8:57 ` Raveendra Padasalagi
2016-02-09 8:57 ` Raveendra Padasalagi
2016-02-09 8:57 ` [PATCH 1/3] input: cygnus-update touchscreen dt node document Raveendra Padasalagi
2016-02-09 8:57 ` Raveendra Padasalagi
2016-02-09 8:57 ` Raveendra Padasalagi
2016-02-09 11:04 ` Arnd Bergmann
2016-02-09 11:04 ` Arnd Bergmann
2016-02-09 16:55 ` Raveendra Padasalagi
2016-02-09 16:55 ` Raveendra Padasalagi
2016-02-09 17:43 ` Dmitry Torokhov
2016-02-09 17:43 ` Dmitry Torokhov
2016-02-09 17:43 ` Dmitry Torokhov
2016-02-10 4:54 ` Raveendra Padasalagi
2016-02-10 4:54 ` Raveendra Padasalagi
2016-02-12 15:04 ` Rob Herring [this message]
2016-02-12 15:04 ` Rob Herring
2016-02-16 4:24 ` Raveendra Padasalagi
2016-02-16 4:24 ` Raveendra Padasalagi
2016-02-09 8:57 ` [PATCH 2/3] input: syscon support in bcm_iproc_tsc driver Raveendra Padasalagi
2016-02-09 8:57 ` Raveendra Padasalagi
2016-02-09 8:57 ` Raveendra Padasalagi
2016-02-09 8:57 ` [PATCH 3/3] ARM: dts: use syscon in cygnus touchscreen dt node Raveendra Padasalagi
2016-02-09 8:57 ` Raveendra Padasalagi
2016-02-09 8:57 ` Raveendra Padasalagi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212150430.GA15049@rob-hp-laptop \
--to=robh@kernel.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jonathar@broadcom.com \
--cc=jonmason@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=raveendra.padasalagi@broadcom.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.