From: Lina Iyer <lina.iyer@linaro.org> To: Stephen Boyd <sboyd@codeaurora.org> Cc: ulf.hansson@linaro.org, khilman@kernel.org, rjw@rjwysocki.net, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, geert@linux-m68k.org, k.kozlowski@samsung.com, msivasub@codeaurora.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, lorenzo.pieralisi@arm.com, ahaslam@baylibre.com, mtitinger@baylibre.com, Kevin Hilman <khilman@linaro.org> Subject: Re: [RFC v2 01/12] PM / Domains: Abstract genpd locking Date: Tue, 1 Mar 2016 09:55:12 -0700 [thread overview] Message-ID: <20160301165512.GI1440@linaro.org> (raw) In-Reply-To: <20160226180844.GT28849@codeaurora.org> On Fri, Feb 26 2016 at 11:08 -0700, Stephen Boyd wrote: >On 02/12, Lina Iyer wrote: >> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c >> index 3ddd05d..8204615 100644 >> --- a/drivers/base/power/domain.c >> +++ b/drivers/base/power/domain.c >> @@ -40,6 +40,46 @@ >> static LIST_HEAD(gpd_list); >> static DEFINE_MUTEX(gpd_list_lock); >> >> +struct genpd_lock_fns { >> + void (*lock)(struct generic_pm_domain *genpd); >> + void (*lock_nested)(struct generic_pm_domain *genpd, int depth); >> + int (*lock_interruptible)(struct generic_pm_domain *genpd); >> + void (*unlock)(struct generic_pm_domain *genpd); >> +}; >> + >> +static void genpd_lock_irq(struct generic_pm_domain *genpd) >> +{ >> + mutex_lock(&genpd->mlock); >> +} >> + >> +static void genpd_lock_irq_nested(struct generic_pm_domain *genpd, >> + int depth) >> +{ >> + mutex_lock_nested(&genpd->mlock, depth); >> +} >> + >> +static int genpd_lock_interruptible_irq(struct generic_pm_domain *genpd) >> +{ >> + return mutex_lock_interruptible(&genpd->mlock); >> +} >> + >> +static void genpd_unlock_irq(struct generic_pm_domain *genpd) >> +{ >> + return mutex_unlock(&genpd->mlock); >> +} >> + >> +static struct genpd_lock_fns irq_lock = { > >Can this be const? Also, why is this called irq_lock when the >lock functions are mutex based? > hmm.. well IRQs are allowed, but I guess, I should come up with a better name. >> + .lock = genpd_lock_irq, >> + .lock_nested = genpd_lock_irq_nested, >> + .lock_interruptible = genpd_lock_interruptible_irq, >> + .unlock = genpd_unlock_irq, >> +}; >> + >> @@ -74,6 +75,8 @@ struct generic_pm_domain { >> struct genpd_power_state *states; >> unsigned int state_count; /* number of states */ >> unsigned int state_idx; /* state that genpd will go to when off */ >> + struct genpd_lock_fns *lock_fns; > >const? > Sure will fix both. Thanks, Lina
WARNING: multiple messages have this Message-ID (diff)
From: lina.iyer@linaro.org (Lina Iyer) To: linux-arm-kernel@lists.infradead.org Subject: [RFC v2 01/12] PM / Domains: Abstract genpd locking Date: Tue, 1 Mar 2016 09:55:12 -0700 [thread overview] Message-ID: <20160301165512.GI1440@linaro.org> (raw) In-Reply-To: <20160226180844.GT28849@codeaurora.org> On Fri, Feb 26 2016 at 11:08 -0700, Stephen Boyd wrote: >On 02/12, Lina Iyer wrote: >> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c >> index 3ddd05d..8204615 100644 >> --- a/drivers/base/power/domain.c >> +++ b/drivers/base/power/domain.c >> @@ -40,6 +40,46 @@ >> static LIST_HEAD(gpd_list); >> static DEFINE_MUTEX(gpd_list_lock); >> >> +struct genpd_lock_fns { >> + void (*lock)(struct generic_pm_domain *genpd); >> + void (*lock_nested)(struct generic_pm_domain *genpd, int depth); >> + int (*lock_interruptible)(struct generic_pm_domain *genpd); >> + void (*unlock)(struct generic_pm_domain *genpd); >> +}; >> + >> +static void genpd_lock_irq(struct generic_pm_domain *genpd) >> +{ >> + mutex_lock(&genpd->mlock); >> +} >> + >> +static void genpd_lock_irq_nested(struct generic_pm_domain *genpd, >> + int depth) >> +{ >> + mutex_lock_nested(&genpd->mlock, depth); >> +} >> + >> +static int genpd_lock_interruptible_irq(struct generic_pm_domain *genpd) >> +{ >> + return mutex_lock_interruptible(&genpd->mlock); >> +} >> + >> +static void genpd_unlock_irq(struct generic_pm_domain *genpd) >> +{ >> + return mutex_unlock(&genpd->mlock); >> +} >> + >> +static struct genpd_lock_fns irq_lock = { > >Can this be const? Also, why is this called irq_lock when the >lock functions are mutex based? > hmm.. well IRQs are allowed, but I guess, I should come up with a better name. >> + .lock = genpd_lock_irq, >> + .lock_nested = genpd_lock_irq_nested, >> + .lock_interruptible = genpd_lock_interruptible_irq, >> + .unlock = genpd_unlock_irq, >> +}; >> + >> @@ -74,6 +75,8 @@ struct generic_pm_domain { >> struct genpd_power_state *states; >> unsigned int state_count; /* number of states */ >> unsigned int state_idx; /* state that genpd will go to when off */ >> + struct genpd_lock_fns *lock_fns; > >const? > Sure will fix both. Thanks, Lina
next prev parent reply other threads:[~2016-03-01 16:55 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-12 20:50 [RFC v2 00/12] PM: SoC idle support using PM domains Lina Iyer 2016-02-12 20:50 ` Lina Iyer 2016-02-12 20:50 ` [RFC v2 01/12] PM / Domains: Abstract genpd locking Lina Iyer 2016-02-12 20:50 ` Lina Iyer 2016-02-26 18:08 ` Stephen Boyd 2016-02-26 18:08 ` Stephen Boyd 2016-03-01 16:55 ` Lina Iyer [this message] 2016-03-01 16:55 ` Lina Iyer 2016-02-12 20:50 ` [RFC v2 02/12] PM / Domains: Support IRQ safe PM domains Lina Iyer 2016-02-12 20:50 ` Lina Iyer 2016-02-26 18:17 ` Stephen Boyd 2016-02-26 18:17 ` Stephen Boyd 2016-03-01 17:44 ` Lina Iyer 2016-03-01 17:44 ` Lina Iyer 2016-02-12 20:50 ` [RFC v2 03/12] PM / cpu_domains: Setup PM domains for CPUs/clusters Lina Iyer 2016-02-12 20:50 ` Lina Iyer 2016-02-17 23:38 ` Lina Iyer 2016-02-17 23:38 ` Lina Iyer 2016-02-18 17:29 ` [BUG FIX] PM / cpu_domains: Check for NULL callbacks Lina Iyer 2016-02-18 17:29 ` Lina Iyer 2016-02-18 17:46 ` Rafael J. Wysocki 2016-02-18 17:46 ` Rafael J. Wysocki 2016-02-18 22:51 ` Lina Iyer 2016-02-18 22:51 ` Lina Iyer 2016-02-26 19:10 ` [RFC v2 03/12] PM / cpu_domains: Setup PM domains for CPUs/clusters Stephen Boyd 2016-02-26 19:10 ` Stephen Boyd 2016-03-01 18:00 ` Lina Iyer 2016-03-01 18:00 ` Lina Iyer 2016-02-12 20:50 ` [RFC v2 04/12] ARM: cpuidle: Add runtime PM support for CPUs Lina Iyer 2016-02-12 20:50 ` Lina Iyer 2016-02-26 18:24 ` Stephen Boyd 2016-02-26 18:24 ` Stephen Boyd 2016-03-01 18:36 ` Lina Iyer 2016-03-01 18:36 ` Lina Iyer 2016-02-12 20:50 ` [RFC v2 05/12] timer: Export next wake up of a CPU Lina Iyer 2016-02-12 20:50 ` Lina Iyer 2016-02-12 20:50 ` [RFC v2 06/12] PM / cpu_domains: Record CPUs that are part of the domain Lina Iyer 2016-02-12 20:50 ` Lina Iyer 2016-02-26 19:20 ` Stephen Boyd 2016-02-26 19:20 ` Stephen Boyd 2016-03-01 19:24 ` Lina Iyer 2016-03-01 19:24 ` Lina Iyer 2016-02-12 20:50 ` [RFC v2 07/12] PM / cpu_domains: Add PM Domain governor for CPUs Lina Iyer 2016-02-12 20:50 ` Lina Iyer 2016-02-26 19:33 ` Stephen Boyd 2016-02-26 19:33 ` Stephen Boyd 2016-03-01 19:32 ` Lina Iyer 2016-03-01 19:32 ` Lina Iyer 2016-03-01 19:35 ` Stephen Boyd 2016-03-01 19:35 ` Stephen Boyd 2016-02-12 20:50 ` [RFC v2 08/12] Documentation / cpu_domains: Describe CPU PM domains setup and governor Lina Iyer 2016-02-12 20:50 ` Lina Iyer 2016-02-26 19:43 ` Stephen Boyd 2016-02-26 19:43 ` Stephen Boyd 2016-03-01 19:36 ` Lina Iyer 2016-03-01 19:36 ` Lina Iyer 2016-02-12 20:50 ` [RFC v2 09/12] drivers: firmware: psci: Allow OS Initiated suspend mode Lina Iyer 2016-02-12 20:50 ` Lina Iyer 2016-02-12 20:50 ` [RFC v2 10/12] ARM64: psci: Support cluster idle states for OS-Initiated Lina Iyer 2016-02-12 20:50 ` Lina Iyer 2016-02-12 20:50 ` [RFC v2 11/12] ARM64: dts: Add PSCI cpuidle support for MSM8916 Lina Iyer 2016-02-12 20:50 ` Lina Iyer 2016-02-12 20:50 ` [RFC v2 12/12] ARM64: dts: Define CPU power domain " Lina Iyer 2016-02-12 20:50 ` Lina Iyer 2016-02-26 19:50 ` Stephen Boyd 2016-02-26 19:50 ` Stephen Boyd 2016-03-01 19:41 ` Lina Iyer 2016-03-01 19:41 ` Lina Iyer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160301165512.GI1440@linaro.org \ --to=lina.iyer@linaro.org \ --cc=agross@codeaurora.org \ --cc=ahaslam@baylibre.com \ --cc=geert@linux-m68k.org \ --cc=k.kozlowski@samsung.com \ --cc=khilman@kernel.org \ --cc=khilman@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=msivasub@codeaurora.org \ --cc=mtitinger@baylibre.com \ --cc=rjw@rjwysocki.net \ --cc=sboyd@codeaurora.org \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.