From: Will Deacon <will.deacon@arm.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
James Hogan <james.hogan@imgtec.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
"David S. Miller" <davem@davemloft.net>,
Chris Metcalf <cmetcalf@ezchip.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Arnd Bergmann <arnd@arndb.de>,
linux-ia64@vger.kernel.org, linux-metag@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.ker
Subject: Re: [PATCH 1/2] topology, cleanup: Avoid redefinition of cpumask_of_pcibus in asm header files.
Date: Wed, 02 Mar 2016 02:17:10 +0000 [thread overview]
Message-ID: <20160302021710.GJ14022@arm.com> (raw)
In-Reply-To: <1456358528-24213-2-git-send-email-ddaney.cavm@gmail.com>
On Wed, Feb 24, 2016 at 04:02:07PM -0800, David Daney wrote:
> From: Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>
>
> At present cpumask_of_pcibus is defined for !CONFIG_NUMA and moving out
> to common will allow to use for numa too. This also avoids
> redefinition of this macro in respective architecture header files.
>
> Reviewed-by: Robert Richter <rrichter@cavium.com>
> Signed-off-by: Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>
> Signed-off-by: David Daney <david.daney@cavium.com>
> ---
> arch/arm64/include/asm/topology.h | 3 ---
> arch/ia64/include/asm/topology.h | 4 ----
> arch/metag/include/asm/topology.h | 3 ---
> arch/powerpc/include/asm/topology.h | 4 ----
> arch/s390/include/asm/pci.h | 2 +-
> arch/s390/include/asm/topology.h | 1 +
> arch/sh/include/asm/topology.h | 3 ---
> arch/tile/include/asm/pci.h | 2 --
> arch/tile/include/asm/topology.h | 3 +++
> arch/x86/include/asm/pci.h | 2 +-
> arch/x86/include/asm/topology.h | 1 +
> include/asm-generic/topology.h | 4 ++--
> 12 files changed, 9 insertions(+), 23 deletions(-)
>
> diff --git a/arch/arm64/include/asm/topology.h b/arch/arm64/include/asm/topology.h
> index 8b57339..6e1f62c 100644
> --- a/arch/arm64/include/asm/topology.h
> +++ b/arch/arm64/include/asm/topology.h
> @@ -26,9 +26,6 @@ const struct cpumask *cpu_coregroup_mask(int cpu);
>
> struct pci_bus;
> int pcibus_to_node(struct pci_bus *bus);
> -#define cpumask_of_pcibus(bus) (pcibus_to_node(bus) = -1 ? \
> - cpu_all_mask : \
> - cpumask_of_node(pcibus_to_node(bus)))
>
> #endif /* CONFIG_NUMA */
Looks like a sensible clean up to me (on top of the arm64 NUMA patches):
Acked-by: Will Deacon <will.deacon@arm.com>
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
James Hogan <james.hogan@imgtec.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
"David S. Miller" <davem@davemloft.net>,
Chris Metcalf <cmetcalf@ezchip.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Arnd Bergmann <arnd@arndb.de>,
linux-ia64@vger.kernel.org, linux-metag@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 1/2] topology, cleanup: Avoid redefinition of cpumask_of_pcibus in asm header files.
Date: Wed, 2 Mar 2016 02:17:10 +0000 [thread overview]
Message-ID: <20160302021710.GJ14022@arm.com> (raw)
In-Reply-To: <1456358528-24213-2-git-send-email-ddaney.cavm@gmail.com>
On Wed, Feb 24, 2016 at 04:02:07PM -0800, David Daney wrote:
> From: Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>
>
> At present cpumask_of_pcibus is defined for !CONFIG_NUMA and moving out
> to common will allow to use for numa too. This also avoids
> redefinition of this macro in respective architecture header files.
>
> Reviewed-by: Robert Richter <rrichter@cavium.com>
> Signed-off-by: Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>
> Signed-off-by: David Daney <david.daney@cavium.com>
> ---
> arch/arm64/include/asm/topology.h | 3 ---
> arch/ia64/include/asm/topology.h | 4 ----
> arch/metag/include/asm/topology.h | 3 ---
> arch/powerpc/include/asm/topology.h | 4 ----
> arch/s390/include/asm/pci.h | 2 +-
> arch/s390/include/asm/topology.h | 1 +
> arch/sh/include/asm/topology.h | 3 ---
> arch/tile/include/asm/pci.h | 2 --
> arch/tile/include/asm/topology.h | 3 +++
> arch/x86/include/asm/pci.h | 2 +-
> arch/x86/include/asm/topology.h | 1 +
> include/asm-generic/topology.h | 4 ++--
> 12 files changed, 9 insertions(+), 23 deletions(-)
>
> diff --git a/arch/arm64/include/asm/topology.h b/arch/arm64/include/asm/topology.h
> index 8b57339..6e1f62c 100644
> --- a/arch/arm64/include/asm/topology.h
> +++ b/arch/arm64/include/asm/topology.h
> @@ -26,9 +26,6 @@ const struct cpumask *cpu_coregroup_mask(int cpu);
>
> struct pci_bus;
> int pcibus_to_node(struct pci_bus *bus);
> -#define cpumask_of_pcibus(bus) (pcibus_to_node(bus) == -1 ? \
> - cpu_all_mask : \
> - cpumask_of_node(pcibus_to_node(bus)))
>
> #endif /* CONFIG_NUMA */
Looks like a sensible clean up to me (on top of the arm64 NUMA patches):
Acked-by: Will Deacon <will.deacon@arm.com>
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
James Hogan <james.hogan@imgtec.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
"David S. Miller" <davem@davemloft.net>,
Chris Metcalf <cmetcalf@ezchip.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Arnd Bergmann <arnd@arndb.de>,
linux-ia64@vger.kernel.org, linux-metag@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.ker
Subject: Re: [PATCH 1/2] topology, cleanup: Avoid redefinition of cpumask_of_pcibus in asm header files.
Date: Wed, 2 Mar 2016 02:17:10 +0000 [thread overview]
Message-ID: <20160302021710.GJ14022@arm.com> (raw)
In-Reply-To: <1456358528-24213-2-git-send-email-ddaney.cavm@gmail.com>
On Wed, Feb 24, 2016 at 04:02:07PM -0800, David Daney wrote:
> From: Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>
>
> At present cpumask_of_pcibus is defined for !CONFIG_NUMA and moving out
> to common will allow to use for numa too. This also avoids
> redefinition of this macro in respective architecture header files.
>
> Reviewed-by: Robert Richter <rrichter@cavium.com>
> Signed-off-by: Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>
> Signed-off-by: David Daney <david.daney@cavium.com>
> ---
> arch/arm64/include/asm/topology.h | 3 ---
> arch/ia64/include/asm/topology.h | 4 ----
> arch/metag/include/asm/topology.h | 3 ---
> arch/powerpc/include/asm/topology.h | 4 ----
> arch/s390/include/asm/pci.h | 2 +-
> arch/s390/include/asm/topology.h | 1 +
> arch/sh/include/asm/topology.h | 3 ---
> arch/tile/include/asm/pci.h | 2 --
> arch/tile/include/asm/topology.h | 3 +++
> arch/x86/include/asm/pci.h | 2 +-
> arch/x86/include/asm/topology.h | 1 +
> include/asm-generic/topology.h | 4 ++--
> 12 files changed, 9 insertions(+), 23 deletions(-)
>
> diff --git a/arch/arm64/include/asm/topology.h b/arch/arm64/include/asm/topology.h
> index 8b57339..6e1f62c 100644
> --- a/arch/arm64/include/asm/topology.h
> +++ b/arch/arm64/include/asm/topology.h
> @@ -26,9 +26,6 @@ const struct cpumask *cpu_coregroup_mask(int cpu);
>
> struct pci_bus;
> int pcibus_to_node(struct pci_bus *bus);
> -#define cpumask_of_pcibus(bus) (pcibus_to_node(bus) == -1 ? \
> - cpu_all_mask : \
> - cpumask_of_node(pcibus_to_node(bus)))
>
> #endif /* CONFIG_NUMA */
Looks like a sensible clean up to me (on top of the arm64 NUMA patches):
Acked-by: Will Deacon <will.deacon@arm.com>
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] topology, cleanup: Avoid redefinition of cpumask_of_pcibus in asm header files.
Date: Wed, 2 Mar 2016 02:17:10 +0000 [thread overview]
Message-ID: <20160302021710.GJ14022@arm.com> (raw)
In-Reply-To: <1456358528-24213-2-git-send-email-ddaney.cavm@gmail.com>
On Wed, Feb 24, 2016 at 04:02:07PM -0800, David Daney wrote:
> From: Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>
>
> At present cpumask_of_pcibus is defined for !CONFIG_NUMA and moving out
> to common will allow to use for numa too. This also avoids
> redefinition of this macro in respective architecture header files.
>
> Reviewed-by: Robert Richter <rrichter@cavium.com>
> Signed-off-by: Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>
> Signed-off-by: David Daney <david.daney@cavium.com>
> ---
> arch/arm64/include/asm/topology.h | 3 ---
> arch/ia64/include/asm/topology.h | 4 ----
> arch/metag/include/asm/topology.h | 3 ---
> arch/powerpc/include/asm/topology.h | 4 ----
> arch/s390/include/asm/pci.h | 2 +-
> arch/s390/include/asm/topology.h | 1 +
> arch/sh/include/asm/topology.h | 3 ---
> arch/tile/include/asm/pci.h | 2 --
> arch/tile/include/asm/topology.h | 3 +++
> arch/x86/include/asm/pci.h | 2 +-
> arch/x86/include/asm/topology.h | 1 +
> include/asm-generic/topology.h | 4 ++--
> 12 files changed, 9 insertions(+), 23 deletions(-)
>
> diff --git a/arch/arm64/include/asm/topology.h b/arch/arm64/include/asm/topology.h
> index 8b57339..6e1f62c 100644
> --- a/arch/arm64/include/asm/topology.h
> +++ b/arch/arm64/include/asm/topology.h
> @@ -26,9 +26,6 @@ const struct cpumask *cpu_coregroup_mask(int cpu);
>
> struct pci_bus;
> int pcibus_to_node(struct pci_bus *bus);
> -#define cpumask_of_pcibus(bus) (pcibus_to_node(bus) == -1 ? \
> - cpu_all_mask : \
> - cpumask_of_node(pcibus_to_node(bus)))
>
> #endif /* CONFIG_NUMA */
Looks like a sensible clean up to me (on top of the arm64 NUMA patches):
Acked-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2016-03-02 2:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 0:02 [PATCH 0/2] NUMA related header file cleanups David Daney
2016-02-25 0:02 ` David Daney
2016-02-25 0:02 ` David Daney
2016-02-25 0:02 ` David Daney
2016-02-25 0:02 ` [PATCH 1/2] topology, cleanup: Avoid redefinition of cpumask_of_pcibus in asm header files David Daney
2016-02-25 0:02 ` David Daney
2016-02-25 0:02 ` David Daney
2016-02-25 0:02 ` David Daney
2016-03-02 2:17 ` Will Deacon [this message]
2016-03-02 2:17 ` Will Deacon
2016-03-02 2:17 ` Will Deacon
2016-03-02 2:17 ` Will Deacon
2016-02-25 0:02 ` [PATCH 2/2] numa, mm, cleanup: remove redundant NODE_DATA macro from " David Daney
2016-02-25 0:02 ` David Daney
2016-02-25 0:02 ` David Daney
2016-02-25 0:02 ` David Daney
2016-03-02 2:15 ` Will Deacon
2016-03-02 2:15 ` Will Deacon
2016-03-02 2:15 ` Will Deacon
2016-03-02 2:15 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302021710.GJ14022@arm.com \
--to=will.deacon@arm.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=cmetcalf@ezchip.com \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=ddaney.cavm@gmail.com \
--cc=fenghua.yu@intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=james.hogan@imgtec.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-metag@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.ker \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.