All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Hogan <james.hogan@imgtec.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
	Michal Marek <mmarek@suse.com>, "Andi Kleen" <ak@linux.intel.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	<linux-mips@linux-mips.org>, <linux-kbuild@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] ld-version: Fix awk regex compile failure
Date: Thu, 10 Mar 2016 20:50:04 +0000	[thread overview]
Message-ID: <20160310205004.GB31414@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <56E1B3C5.7040204@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]

On Thu, Mar 10, 2016 at 11:19:57PM +0530, Sudip Mukherjee wrote:
> On Tuesday 08 March 2016 10:17 PM, James Hogan wrote:
> > The ld-version.sh script fails on some versions of awk with the
> > following error, resulting in build failures for MIPS:
> >
> > awk: scripts/ld-version.sh: line 4: regular expression compile failed (missing '(')
> >
> > This is due to the regular expression ".*)", meant to strip off the
> > beginning of the ld version string up to the close bracket, however
> > brackets have a meaning in regular expressions, so lets escape it so
> > that awk doesn't expect a corresponding open bracket.
> >
> > Fixes: ccbef1674a15 ("Kbuild, lto: add ld-version and ld-ifversion ...")
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Signed-off-by: James Hogan <james.hogan@imgtec.com>
> 
> This error was only coming in my gitlab builds but was not showing in 
> the build of travis-ci. Maybe it depends on the version of awk also.
> Build log at: https://gitlab.com/sudipm/linux-next/builds/839573
> 
> Tested-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>

Great, that looks pretty conclusive. Thanks for testing Sudip and
Michael.

Ralf: is it too late to get this into v4.5 via MIPS tree?

Cheers
James

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
	Michal Marek <mmarek@suse.com>, Andi Kleen <ak@linux.intel.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	linux-mips@linux-mips.org, linux-kbuild@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ld-version: Fix awk regex compile failure
Date: Thu, 10 Mar 2016 20:50:04 +0000	[thread overview]
Message-ID: <20160310205004.GB31414@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <56E1B3C5.7040204@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]

On Thu, Mar 10, 2016 at 11:19:57PM +0530, Sudip Mukherjee wrote:
> On Tuesday 08 March 2016 10:17 PM, James Hogan wrote:
> > The ld-version.sh script fails on some versions of awk with the
> > following error, resulting in build failures for MIPS:
> >
> > awk: scripts/ld-version.sh: line 4: regular expression compile failed (missing '(')
> >
> > This is due to the regular expression ".*)", meant to strip off the
> > beginning of the ld version string up to the close bracket, however
> > brackets have a meaning in regular expressions, so lets escape it so
> > that awk doesn't expect a corresponding open bracket.
> >
> > Fixes: ccbef1674a15 ("Kbuild, lto: add ld-version and ld-ifversion ...")
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Signed-off-by: James Hogan <james.hogan@imgtec.com>
> 
> This error was only coming in my gitlab builds but was not showing in 
> the build of travis-ci. Maybe it depends on the version of awk also.
> Build log at: https://gitlab.com/sudipm/linux-next/builds/839573
> 
> Tested-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>

Great, that looks pretty conclusive. Thanks for testing Sudip and
Michael.

Ralf: is it too late to get this into v4.5 via MIPS tree?

Cheers
James

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-03-10 20:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08 16:47 [PATCH] ld-version: Fix awk regex compile failure James Hogan
2016-03-08 16:47 ` James Hogan
2016-03-08 16:55 ` Michael S. Tsirkin
2016-03-10 17:49 ` Sudip Mukherjee
2016-03-10 20:50   ` James Hogan [this message]
2016-03-10 20:50     ` James Hogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160310205004.GB31414@jhogan-linux.le.imgtec.org \
    --to=james.hogan@imgtec.com \
    --cc=ak@linux.intel.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=mmarek@suse.com \
    --cc=mst@redhat.com \
    --cc=ralf@linux-mips.org \
    --cc=stable@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.