All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
	kyungmin.park@samsung.com, a.hajda@samsung.com,
	s.nawrocki@samsung.com, kgene@kernel.org,
	k.kozlowski@samsung.com, laurent.pinchart@ideasonboard.com,
	hyun.kwon@xilinx.com, soren.brinkmann@xilinx.com,
	gregkh@linuxfoundation.org, perex@perex.cz, tiwai@suse.com,
	hans.verkuil@cisco.com, lixiubo@cmss.chinamobile.com,
	javier@osg.samsung.com, g.liakhovetski@gmx.de,
	chehabrafael@gmail.com, crope@iki.fi, tommi.franttila@intel.com,
	dan.carpenter@oracle.com, prabhakar.csengg@gmail.com,
	hamohammed.sa@gmail.com, der.herr@hofr.at,
	navyasri.tech@gmail.com, Julia.Lawall@lip6.fr,
	amitoj1606@gmail.com, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, devel@driverdev.osuosl.org,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context
Date: Mon, 14 Mar 2016 07:13:58 -0300	[thread overview]
Message-ID: <20160314071358.27c87dab@recife.lan> (raw)
In-Reply-To: <20160314072236.GO11084@valkosipuli.retiisi.org.uk>

Em Mon, 14 Mar 2016 09:22:37 +0200
Sakari Ailus <sakari.ailus@iki.fi> escreveu:

> Hi Shuah,
> 
> On Sat, Mar 12, 2016 at 06:48:09PM -0700, Shuah Khan wrote:
> > Add GFP flags to media_create_pad_link(), media_create_intf_link(),
> > media_devnode_create(), and media_add_link() that could get called
> > in atomic context to allow callers to pass in the right flags for
> > memory allocation.
> > 
> > tree-wide driver changes for media_*() GFP flags change:
> > Change drivers to add gfpflags to interffaces, media_create_pad_link(),
> > media_create_intf_link() and media_devnode_create().
> > 
> > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> > Suggested-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>  
> 
> What's the use case for calling the above functions in an atomic context?
> 

ALSA code seems to do a lot of stuff at atomic context. That's what
happens on my test machine when au0828 gets probed before
snd-usb-audio:
	http://pastebin.com/LEX5LD5K

It seems that ALSA USB probe routine (usb_audio_probe) happens in
atomic context.

Regards,
Mauro

WARNING: multiple messages have this Message-ID (diff)
From: mchehab@osg.samsung.com (Mauro Carvalho Chehab)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] media: add GFP flag to media_*() that could get called in atomic context
Date: Mon, 14 Mar 2016 07:13:58 -0300	[thread overview]
Message-ID: <20160314071358.27c87dab@recife.lan> (raw)
In-Reply-To: <20160314072236.GO11084@valkosipuli.retiisi.org.uk>

Em Mon, 14 Mar 2016 09:22:37 +0200
Sakari Ailus <sakari.ailus@iki.fi> escreveu:

> Hi Shuah,
> 
> On Sat, Mar 12, 2016 at 06:48:09PM -0700, Shuah Khan wrote:
> > Add GFP flags to media_create_pad_link(), media_create_intf_link(),
> > media_devnode_create(), and media_add_link() that could get called
> > in atomic context to allow callers to pass in the right flags for
> > memory allocation.
> > 
> > tree-wide driver changes for media_*() GFP flags change:
> > Change drivers to add gfpflags to interffaces, media_create_pad_link(),
> > media_create_intf_link() and media_devnode_create().
> > 
> > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> > Suggested-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>  
> 
> What's the use case for calling the above functions in an atomic context?
> 

ALSA code seems to do a lot of stuff at atomic context. That's what
happens on my test machine when au0828 gets probed before
snd-usb-audio:
	http://pastebin.com/LEX5LD5K

It seems that ALSA USB probe routine (usb_audio_probe) happens in
atomic context.

Regards,
Mauro

  reply	other threads:[~2016-03-14 10:14 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-13  1:48 [PATCH] media: add GFP flag to media_*() that could get called in atomic context Shuah Khan
2016-03-13  1:48 ` Shuah Khan
2016-03-13  8:30 ` Nicholas Mc Guire
2016-03-13  8:30   ` Nicholas Mc Guire
2016-03-13  8:30   ` Nicholas Mc Guire
2016-03-13 11:50 ` Mauro Carvalho Chehab
2016-03-13 11:50   ` Mauro Carvalho Chehab
2016-03-14  7:22 ` Sakari Ailus
2016-03-14  7:22   ` Sakari Ailus
2016-03-14 10:13   ` Mauro Carvalho Chehab [this message]
2016-03-14 10:13     ` Mauro Carvalho Chehab
2016-03-14 10:33     ` Takashi Iwai
2016-03-14 10:33       ` Takashi Iwai
2016-03-14 10:33       ` Takashi Iwai
2016-03-14 10:52     ` Sakari Ailus
2016-03-14 10:52       ` Sakari Ailus
2016-03-14 11:46       ` Mauro Carvalho Chehab
2016-03-14 11:46         ` Mauro Carvalho Chehab
2016-03-14 12:09         ` Sakari Ailus
2016-03-14 12:09           ` Sakari Ailus
2016-03-15 15:55           ` Mauro Carvalho Chehab
2016-03-15 15:55             ` Mauro Carvalho Chehab
2016-03-16  8:28             ` Sakari Ailus
2016-03-16  8:28               ` Sakari Ailus
2016-03-16 12:02               ` Mauro Carvalho Chehab
2016-03-16 12:02                 ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160314071358.27c87dab@recife.lan \
    --to=mchehab@osg.samsung.com \
    --cc=Julia.Lawall@lip6.fr \
    --cc=a.hajda@samsung.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=amitoj1606@gmail.com \
    --cc=chehabrafael@gmail.com \
    --cc=crope@iki.fi \
    --cc=dan.carpenter@oracle.com \
    --cc=der.herr@hofr.at \
    --cc=devel@driverdev.osuosl.org \
    --cc=g.liakhovetski@gmx.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hamohammed.sa@gmail.com \
    --cc=hans.verkuil@cisco.com \
    --cc=hyun.kwon@xilinx.com \
    --cc=javier@osg.samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=lixiubo@cmss.chinamobile.com \
    --cc=navyasri.tech@gmail.com \
    --cc=perex@perex.cz \
    --cc=prabhakar.csengg@gmail.com \
    --cc=s.nawrocki@samsung.com \
    --cc=sakari.ailus@iki.fi \
    --cc=shuahkh@osg.samsung.com \
    --cc=soren.brinkmann@xilinx.com \
    --cc=tiwai@suse.com \
    --cc=tommi.franttila@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.