From: Jan Kara <jack@suse.cz>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Jan Kara <jack@suse.cz>,
linux-nvdimm@lists.01.org, NeilBrown <neilb@suse.com>,
"Wilcox, Matthew R" <matthew.r.wilcox@intel.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 03/10] dax: Remove complete_unwritten argument
Date: Thu, 24 Mar 2016 13:32:51 +0100 [thread overview]
Message-ID: <20160324123251.GG4025@quack.suse.cz> (raw)
In-Reply-To: <20160323171226.GB5544@linux.intel.com>
On Wed 23-03-16 11:12:26, Ross Zwisler wrote:
> On Mon, Mar 21, 2016 at 02:22:48PM +0100, Jan Kara wrote:
> > Fault handlers currently take complete_unwritten argument to convert
> > unwritten extents after PTEs are updated. However no filesystem uses
> > this anymore as the code is racy. Remove the unused argument.
>
> This looks good. Looking at this reminded me that at some point it may be
> good to clean up our buffer head flags checks and make sure we don't have
> checks that don't make sense - we still check for buffer_unwritten() in
> buffer_written(), for instance.
>
> The handling of BH_New isn't consistent among filesystems, either - XFS & ext4
> go out of their way to make sure BH_New is not set, while ext2 sets BH_New.
>
> But I think those are separate from this patch, I think.
Yes, that's a separate thing and I think I've handled most of that in the
following patches. Thanks for review!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, "Wilcox,
Matthew R" <matthew.r.wilcox@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
linux-nvdimm@lists.01.org, NeilBrown <neilb@suse.com>
Subject: Re: [PATCH 03/10] dax: Remove complete_unwritten argument
Date: Thu, 24 Mar 2016 13:32:51 +0100 [thread overview]
Message-ID: <20160324123251.GG4025@quack.suse.cz> (raw)
In-Reply-To: <20160323171226.GB5544@linux.intel.com>
On Wed 23-03-16 11:12:26, Ross Zwisler wrote:
> On Mon, Mar 21, 2016 at 02:22:48PM +0100, Jan Kara wrote:
> > Fault handlers currently take complete_unwritten argument to convert
> > unwritten extents after PTEs are updated. However no filesystem uses
> > this anymore as the code is racy. Remove the unused argument.
>
> This looks good. Looking at this reminded me that at some point it may be
> good to clean up our buffer head flags checks and make sure we don't have
> checks that don't make sense - we still check for buffer_unwritten() in
> buffer_written(), for instance.
>
> The handling of BH_New isn't consistent among filesystems, either - XFS & ext4
> go out of their way to make sure BH_New is not set, while ext2 sets BH_New.
>
> But I think those are separate from this patch, I think.
Yes, that's a separate thing and I think I've handled most of that in the
following patches. Thanks for review!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2016-03-24 12:32 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 13:22 [RFC v2] [PATCH 0/10] DAX page fault locking Jan Kara
2016-03-21 13:22 ` Jan Kara
2016-03-21 13:22 ` [PATCH 01/10] DAX: move RADIX_DAX_ definitions to dax.c Jan Kara
2016-03-21 13:22 ` Jan Kara
2016-03-21 17:25 ` Matthew Wilcox
2016-03-21 17:25 ` Matthew Wilcox
2016-03-21 13:22 ` [PATCH 02/10] radix-tree: make 'indirect' bit available to exception entries Jan Kara
2016-03-21 13:22 ` Jan Kara
2016-03-21 17:34 ` Matthew Wilcox
2016-03-21 17:34 ` Matthew Wilcox
2016-03-22 9:12 ` Jan Kara
2016-03-22 9:12 ` Jan Kara
2016-03-22 9:27 ` Matthew Wilcox
2016-03-22 9:27 ` Matthew Wilcox
2016-03-22 10:37 ` Jan Kara
2016-03-22 10:37 ` Jan Kara
2016-03-23 16:41 ` Ross Zwisler
2016-03-23 16:41 ` Ross Zwisler
2016-03-24 12:31 ` Jan Kara
2016-03-24 12:31 ` Jan Kara
2016-03-21 13:22 ` [PATCH 03/10] dax: Remove complete_unwritten argument Jan Kara
2016-03-21 13:22 ` Jan Kara
2016-03-23 17:12 ` Ross Zwisler
2016-03-23 17:12 ` Ross Zwisler
2016-03-24 12:32 ` Jan Kara [this message]
2016-03-24 12:32 ` Jan Kara
2016-03-21 13:22 ` [PATCH 04/10] dax: Fix data corruption for written and mmapped files Jan Kara
2016-03-21 13:22 ` Jan Kara
2016-03-23 17:39 ` Ross Zwisler
2016-03-23 17:39 ` Ross Zwisler
2016-03-24 12:51 ` Jan Kara
2016-03-24 12:51 ` Jan Kara
2016-03-29 15:17 ` Ross Zwisler
2016-03-29 15:17 ` Ross Zwisler
2016-03-21 13:22 ` [PATCH 05/10] dax: Allow DAX code to replace exceptional entries Jan Kara
2016-03-21 13:22 ` Jan Kara
2016-03-23 17:52 ` Ross Zwisler
2016-03-23 17:52 ` Ross Zwisler
2016-03-24 10:42 ` Jan Kara
2016-03-24 10:42 ` Jan Kara
2016-03-21 13:22 ` [PATCH 06/10] dax: Remove redundant inode size checks Jan Kara
2016-03-21 13:22 ` Jan Kara
2016-03-23 21:08 ` Ross Zwisler
2016-03-23 21:08 ` Ross Zwisler
2016-03-21 13:22 ` [PATCH 07/10] dax: Disable huge page handling Jan Kara
2016-03-21 13:22 ` Jan Kara
2016-03-23 20:50 ` Ross Zwisler
2016-03-23 20:50 ` Ross Zwisler
2016-03-24 12:56 ` Jan Kara
2016-03-24 12:56 ` Jan Kara
2016-03-21 13:22 ` [PATCH 08/10] dax: New fault locking Jan Kara
2016-03-21 13:22 ` Jan Kara
2016-03-29 21:57 ` Ross Zwisler
2016-03-29 21:57 ` Ross Zwisler
2016-03-31 16:27 ` Jan Kara
2016-03-31 16:27 ` Jan Kara
2016-03-21 13:22 ` [PATCH 09/10] dax: Use radix tree entry lock to protect cow faults Jan Kara
2016-03-21 13:22 ` Jan Kara
2016-03-21 19:11 ` Matthew Wilcox
2016-03-21 19:11 ` Matthew Wilcox
2016-03-22 7:03 ` Jan Kara
2016-03-22 7:03 ` Jan Kara
2016-03-29 22:18 ` Ross Zwisler
2016-03-29 22:18 ` Ross Zwisler
2016-03-21 13:22 ` [PATCH 10/10] dax: Remove i_mmap_lock protection Jan Kara
2016-03-21 13:22 ` Jan Kara
2016-03-29 22:17 ` Ross Zwisler
2016-03-29 22:17 ` Ross Zwisler
2016-03-21 17:41 ` [RFC v2] [PATCH 0/10] DAX page fault locking Matthew Wilcox
2016-03-21 17:41 ` Matthew Wilcox
2016-03-23 15:09 ` Jan Kara
2016-03-23 15:09 ` Jan Kara
2016-03-23 20:50 ` Matthew Wilcox
2016-03-23 20:50 ` Matthew Wilcox
2016-03-24 10:00 ` Matthew Wilcox
2016-03-24 10:00 ` Matthew Wilcox
2016-03-22 19:32 ` Ross Zwisler
2016-03-22 19:32 ` Ross Zwisler
2016-03-22 21:07 ` Toshi Kani
2016-03-22 21:07 ` Toshi Kani
2016-03-22 21:15 ` Dave Chinner
2016-03-22 21:15 ` Dave Chinner
2016-03-23 9:45 ` Jan Kara
2016-03-23 9:45 ` Jan Kara
2016-03-23 15:11 ` Toshi Kani
2016-03-23 15:11 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160324123251.GG4025@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=matthew.r.wilcox@intel.com \
--cc=neilb@suse.com \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.