Re: [RFC PATCH 1/2] build: add debug menu to Kconfig

From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	xen-devel@lists.xen.org
Subject: Re: [RFC PATCH 1/2] build: add debug menu to Kconfig
Date: Fri, 25 Mar 2016 15:42:00 -0400	[thread overview]
Message-ID: <20160325194200.GC14689@char.us.oracle.com> (raw)
In-Reply-To: <1458838099-12053-1-git-send-email-cardoe@cardoe.com>

On Thu, Mar 24, 2016 at 11:48:18AM -0500, Doug Goldstein wrote:
> There are a number of debugging options for Xen so the idea is to have a
> menu to group them all together.
> 
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> ---
> This is more of an RFC than a merge request. If this seems reasonable I'll
> add all the other debugging options under this menu as well. Obviously if
> this seems reasonable and the patch is fine we can merge it and I'll submit
> the others as a follow up.

There would be more I presume - the lock profile, gcov, crash, etc..

And with the 'randconfig' that means we can turn on/off various options and
find interesting dependencies (if any).

Anyhow back to this patch.

The usual method for distros of compiling an Xen with and without debug (like Xenserver)
is:

make %{?_smp_mflags} max_phys_cpus=384 xen tools

make %{?_smp_mflags} -C xen clean
make %{?_smp_mflags} -C xen debug=y max_phys_cpus=384

It would be preferrable to still have this functionality. As in, if we
do 'debug=y' then verbose=y and frame_pointer=y are automatically enabled?

Is that something the Kconfig magic can still do?
> 
> 
> CC: Ian Jackson <ian.jackson@eu.citrix.com>
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Keir Fraser <keir@xen.org>
> CC: Tim Deegan <tim@xen.org>
> ---
>  xen/Kconfig       | 2 ++
>  xen/Kconfig.debug | 6 ++++++
>  2 files changed, 8 insertions(+)
>  create mode 100644 xen/Kconfig.debug
> 
> diff --git a/xen/Kconfig b/xen/Kconfig
> index fa8b27c..0fe7a1a 100644
> --- a/xen/Kconfig
> +++ b/xen/Kconfig
> @@ -26,3 +26,5 @@ config DEFCONFIG_LIST
>  config EXPERT
>  	string
>  	option env="XEN_CONFIG_EXPERT"
> +
> +source "Kconfig.debug"
> diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug
> new file mode 100644
> index 0000000..36890bd
> --- /dev/null
> +++ b/xen/Kconfig.debug
> @@ -0,0 +1,6 @@
> +
> +menuconfig DEBUG
> +	bool "Debugging Options"
> +	---help---
> +	  If you want to debug Xen say Y and select any additional debugging
> +	  support options.

.. You can also add:

Should not be used for production builds.

Note that any _ASSERTS_ in the code without debug are emitted.

> -- 
> 2.7.3
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel