Re: [RFC PATCH 2/2] build: convert crash_debug to Kconfig

From: Doug Goldstein <cardoe@cardoe.com>
To: Jan Beulich <JBeulich@suse.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Keir Fraser <keir@xen.org>,
	xen-devel@lists.xen.org
Subject: Re: [RFC PATCH 2/2] build: convert crash_debug to Kconfig
Date: Wed, 30 Mar 2016 10:38:28 -0500	[thread overview]
Message-ID: <56FBF2F4.6070809@cardoe.com> (raw)
In-Reply-To: <56FA5DDA02000078000E0BDB@prv-mh.provo.novell.com>

[-- Attachment #1.1.1: Type: text/plain, Size: 1437 bytes --]

On 3/29/16 3:50 AM, Jan Beulich wrote:
>>>> On 25.03.16 at 22:02, <cardoe@cardoe.com> wrote:
>> On 3/25/16 2:49 PM, Konrad Rzeszutek Wilk wrote:
>>> On Thu, Mar 24, 2016 at 11:48:19AM -0500, Doug Goldstein wrote:
>>>> --- a/xen/Kconfig.debug
>>>> +++ b/xen/Kconfig.debug
>>>> @@ -4,3 +4,14 @@ menuconfig DEBUG
>>>>  	---help---
>>>>  	  If you want to debug Xen say Y and select any additional debugging
>>>>  	  support options.
>>>> +
>>>> +if DEBUG
>>>
>>> Perhaps if !defined then atuomatically enable it? Looking at Config.mk
>>> it seems you could do crash_debug without debug=y?
>>
>> debug=y unfortunately is more than just a "meta" option that selects
>> verbose=y and frame_pointer=y. It also turns off NDEBUG so that debug
>> messages appear. I'm not sure how that should be mapped in the context
>> of this patch. Should the messages be enabled when DEBUG is enabled or
>> should there be another option?
> 
> Let's not make this too fine grained, at least for now. I.e. enabling
> DEBUG should mean exactly what "debug=y" so far meant.
> 
> Jan
> 

That's what I was stating this patch does. The question revolved around
the fact that you can do crash_debug=y debug=n right now and if that
made sense. Should crash_debug=y imply debug=y as well.

So things are more fine grained and I was proposing we make it less so
if the fine grained choices didn't make sense.

-- 
Doug Goldstein

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel