From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "George Dunlap" <george.dunlap@eu.citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
"Wei Liu" <wei.liu2@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH OSSTEST RFC 2/2] Make guest cdrom empty after installation completes
Date: Wed, 6 Apr 2016 16:06:01 +0100 [thread overview]
Message-ID: <20160406150601.GB8809@citrix.com> (raw)
In-Reply-To: <22277.9469.711192.234384@mariner.uk.xensource.com>
On Wed, Apr 06, 2016 at 04:02:21PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH OSSTEST RFC 2/2] Make guest cdrom empty after installation completes"):
> > Previously an iso image that contains nothing was inserted to cdrom
> > after guest installation had finished.
> >
> > With this patch we make cdrom really empty. This helps catch bug that
> > prevents booting hvm guest with empty cdrom drive.
> >
> > Remove empty iso image generate in ts-{debian-hvm,redhat}-install as
> > well.
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> However, given the bugs currently being discussed, and the fact that
> we're currently in a pre-freeze crunch, I'm reluctant to push this to
> osstest staging right now.
>
> On any stable branches with empty cd bugs, it would immediately fail
> and cause blockages.
>
> I'd like to make this change during the 4.7 freeze period, after fixes
> for these bugs are available in staging. During the freeze the fixes
> can be backported to stable branches.
>
I agree. I stated more or less the same opinion in cover letter. :-)
Wei.
> Thanks,
> Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-04-06 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 13:02 [PATCH OSSTEST RFC 0/2] Test booting hvm guest with empty cdrom drive Wei Liu
2016-04-06 13:02 ` [PATCH OSSTEST RFC 1/2] Testsupport: rename guest_editconfig_nocd to _postinstall Wei Liu
2016-04-06 14:59 ` Ian Jackson
2016-04-06 13:02 ` [PATCH OSSTEST RFC 2/2] Make guest cdrom empty after installation completes Wei Liu
2016-04-06 15:02 ` Ian Jackson
2016-04-06 15:06 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160406150601.GB8809@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.