From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: "George Dunlap" <george.dunlap@eu.citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH OSSTEST RFC 1/2] Testsupport: rename guest_editconfig_nocd to _postinstall
Date: Wed, 6 Apr 2016 15:59:11 +0100 [thread overview]
Message-ID: <22277.9279.970733.348181@mariner.uk.xensource.com> (raw)
In-Reply-To: <1459947777-26011-2-git-send-email-wei.liu2@citrix.com>
Wei Liu writes ("[PATCH OSSTEST RFC 1/2] Testsupport: rename guest_editconfig_nocd to _postinstall"):
> It does more than just replacing the disc in cdrom. It also modifies
> guest reboot action.
I think this probably ought to be called `midinstall' or something.
The installation isn't complete until firstboot stuff is done.
With that change,
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-06 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 13:02 [PATCH OSSTEST RFC 0/2] Test booting hvm guest with empty cdrom drive Wei Liu
2016-04-06 13:02 ` [PATCH OSSTEST RFC 1/2] Testsupport: rename guest_editconfig_nocd to _postinstall Wei Liu
2016-04-06 14:59 ` Ian Jackson [this message]
2016-04-06 13:02 ` [PATCH OSSTEST RFC 2/2] Make guest cdrom empty after installation completes Wei Liu
2016-04-06 15:02 ` Ian Jackson
2016-04-06 15:06 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22277.9279.970733.348181@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.