From: Mark Brown <broonie@kernel.org>
To: PC Liao <pc.liao@mediatek.com>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
srv_heupstream <srv_heupstream@mediatek.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Koro Chen (陳思翰)" <koro.chen@mediatek.com>
Subject: Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver
Date: Wed, 20 Apr 2016 17:11:22 +0100 [thread overview]
Message-ID: <20160420161122.GM3217@sirena.org.uk> (raw)
In-Reply-To: <1461145190.3774.5.camel@mtksdaap41>
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
On Wed, Apr 20, 2016 at 05:39:50PM +0800, PC Liao wrote:
> On Wed, 2016-04-20 at 16:29 +0800, Mark Brown wrote:
> > On Wed, Apr 20, 2016 at 02:40:47PM +0800, PC Liao wrote:
> > > +Optional properties:
> > > +- capture-dai: audio codec dai on capture path
> > > + <&rt5650 0> : Default setting. Connect rt5650 I2S1 for capture. (dai_name = rt5645-aif1)
> > > + <&rt5650 1> : Connect rt5650 I2S2 for capture. (dai_name = rt5645-aif2)
> > I sugggested changing this to use a subnode but you've ignored my
> > suggestion...
> Sorry.... It's my mistake.
> You mean that using a subnode.
> This is my example:
> codec-capture {
> sound-dai = <&rt5650 1>;
> };
> Does this is your suggestion?
Yeah. Having refreshed my mind about the APIs a bit the idea is that if
you do things this way then any additional parameters that are needed
for the DAI can be added within the subnode.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver
Date: Wed, 20 Apr 2016 17:11:22 +0100 [thread overview]
Message-ID: <20160420161122.GM3217@sirena.org.uk> (raw)
In-Reply-To: <1461145190.3774.5.camel@mtksdaap41>
On Wed, Apr 20, 2016 at 05:39:50PM +0800, PC Liao wrote:
> On Wed, 2016-04-20 at 16:29 +0800, Mark Brown wrote:
> > On Wed, Apr 20, 2016 at 02:40:47PM +0800, PC Liao wrote:
> > > +Optional properties:
> > > +- capture-dai: audio codec dai on capture path
> > > + <&rt5650 0> : Default setting. Connect rt5650 I2S1 for capture. (dai_name = rt5645-aif1)
> > > + <&rt5650 1> : Connect rt5650 I2S2 for capture. (dai_name = rt5645-aif2)
> > I sugggested changing this to use a subnode but you've ignored my
> > suggestion...
> Sorry.... It's my mistake.
> You mean that using a subnode.
> This is my example:
> codec-capture {
> sound-dai = <&rt5650 1>;
> };
> Does this is your suggestion?
Yeah. Having refreshed my mind about the APIs a bit the idea is that if
you do things this way then any additional parameters that are needed
for the DAI can be added within the subnode.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160420/f845ba28/attachment.sig>
next prev parent reply other threads:[~2016-04-20 16:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 6:40 [PATCH 0/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver PC Liao
2016-04-20 6:40 ` PC Liao
2016-04-20 6:40 ` PC Liao
2016-04-20 6:40 ` [PATCH 1/2 v6] ASoC: core: export snd_soc_get_dai_name PC Liao
2016-04-20 6:40 ` PC Liao
2016-04-20 6:40 ` PC Liao
2016-04-20 6:40 ` [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver PC Liao
2016-04-20 6:40 ` PC Liao
2016-04-20 6:40 ` PC Liao
2016-04-20 8:29 ` Mark Brown
2016-04-20 8:29 ` Mark Brown
2016-04-20 8:29 ` Mark Brown
2016-04-20 9:39 ` PC Liao
2016-04-20 9:39 ` PC Liao
2016-04-20 16:11 ` Mark Brown [this message]
2016-04-20 16:11 ` Mark Brown
2016-04-20 13:30 ` Matthias Brugger
2016-04-20 13:30 ` Matthias Brugger
2016-04-20 16:27 ` PC Liao
2016-04-20 16:27 ` PC Liao
2016-04-20 16:27 ` PC Liao
2016-04-21 9:22 ` Matthias Brugger
2016-04-21 9:22 ` Matthias Brugger
2016-04-21 9:38 ` PC Liao
2016-04-21 9:38 ` PC Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420161122.GM3217@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=koro.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=pc.liao@mediatek.com \
--cc=s.hauer@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.