From: Jerry Hoemann <jerry.hoemann@hpe.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [RFC v9 4/5] nvdimm: Add concept of cmd mask
Date: Fri, 22 Apr 2016 11:55:26 -0600 [thread overview]
Message-ID: <20160422175526.GA126763@tevye.fc.hp.com> (raw)
In-Reply-To: <CAPcyv4gt9_KbhYJb0RQ0_Pd8wx98HH6u0_Z+zy25f=wj5F8FHA@mail.gmail.com>
On Thu, Apr 21, 2016 at 11:25:37AM -0700, Dan Williams wrote:
> On Thu, Apr 21, 2016 at 10:28 AM, Jerry Hoemann <jerry.hoemann@hpe.com> wrote:
> > On Mon, Apr 18, 2016 at 08:03:14PM -0700, Dan Williams wrote:
> >> On Sun, Apr 17, 2016 at 4:38 PM, Jerry Hoemann <jerry.hoemann@hpe.com> wrote:
> >
> > ...
> >
> >
> >> > struct cmd_family_tbl nfit_cmd_family_tbl[] = {
> >> > - { NFIT_DEV_DIMM, ND_TYPE_DIMM_INTEL1, 1},
> >> > - { NFIT_DEV_DIMM_N_HPE1, ND_TYPE_DIMM_N_HPE1, 1},
> >> > - { NFIT_DEV_DIMM_N_HPE2, ND_TYPE_DIMM_N_HPE2, 1},
> >> > + { NFIT_DEV_DIMM, ND_TYPE_DIMM_INTEL1, 1, 1},
> >> > + { NFIT_DEV_DIMM_N_HPE1, ND_TYPE_DIMM_N_HPE1, 1, 0},
> >> > + { NFIT_DEV_DIMM_N_HPE2, ND_TYPE_DIMM_N_HPE2, 1, 0},
> >>
> >> Lets replace does_ioctl with a mask of the valid function numbers see below...
> >>
I think that the masking of dsm_mask is in addition to, not in
replacement of what does_ioctl is doing in creating the cmd_mask.
cmd_mask for *_N_HPE1 should only be (1 << ND_CMD_CALL) at least
for now.
> >
> > Is this new mask to be used in the construction of cmd_mask or in a bit
> > and with dsm_mask?
> >
>
> The latter, "and with dsm_mask".
>
--
-----------------------------------------------------------------------------
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-----------------------------------------------------------------------------
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2016-04-22 17:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-17 23:38 [RFC v9 0/5] nvdimm: Add an IOCTL pass thru for DSM calls Jerry Hoemann
2016-04-17 23:38 ` [RFC v9 1/5] nvdimm: Add IOCTL pass thru functions Jerry Hoemann
2016-04-18 8:07 ` Johannes Thumshirn
2016-04-19 2:15 ` Dan Williams
2016-04-20 16:46 ` Jerry Hoemann
2016-04-20 20:08 ` Dan Williams
2016-04-20 22:55 ` Jerry Hoemann
2016-04-21 1:29 ` Dan Williams
2016-04-21 11:39 ` Dan Williams
2016-04-17 23:38 ` [RFC v9 2/5] libnvdimm: nvdimm_bus_descriptor field name change Jerry Hoemann
2016-04-18 8:08 ` Johannes Thumshirn
2016-04-17 23:38 ` [RFC v9 3/5] Subject: [PATCH v8 07/10] tools/testing/nvdimm: 'call_dsm' support Jerry Hoemann
2016-04-18 8:08 ` Johannes Thumshirn
2016-04-19 2:22 ` Dan Williams
2016-04-20 16:50 ` Jerry Hoemann
2016-04-17 23:38 ` [RFC v9 4/5] nvdimm: Add concept of cmd mask Jerry Hoemann
2016-04-18 8:09 ` Johannes Thumshirn
2016-04-19 3:03 ` Dan Williams
2016-04-21 17:28 ` Jerry Hoemann
2016-04-21 18:25 ` Dan Williams
2016-04-22 17:55 ` Jerry Hoemann [this message]
2016-04-22 18:16 ` Dan Williams
2016-04-17 23:38 ` [RFC v9 5/5] nvdimm: Add ioctl to return command mask Jerry Hoemann
2016-04-18 8:09 ` Johannes Thumshirn
2016-04-19 17:45 ` Dan Williams
2016-04-20 17:41 ` Jerry Hoemann
2016-04-21 11:52 ` Dan Williams
2016-04-21 16:52 ` Jerry Hoemann
2016-04-21 18:18 ` Dan Williams
2016-04-22 23:15 ` Jerry Hoemann
2016-04-22 23:33 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422175526.GA126763@tevye.fc.hp.com \
--to=jerry.hoemann@hpe.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.